* v4 Exynos5422 odroidxu3 pwm-fan control using thermal sensors
@ 2015-04-12 18:44 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: linux-arm-kernel
Changes from v1
fixed the registration of thermal sensor to tmu_cpu0
Dropped patches.
0005-pwm-samsung-Fix-output-race-on-disabling.patch
0006-hwmon-pwm-fan-Update-the-duty-cycle-inorder-to-contr.patch
changes from v2
Added patch
0006-hwmon-pwm-fan-Update-the-duty-cycle-inorder-to-contr.patch
changes from v3
Simpilfy the commment in the patch.
-Anand Moon
^ permalink raw reply [flat|nested] 16+ messages in thread[parent not found: <1428864251-31780-1-git-send-email-linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* [PATCH v4 1/6] ARM: dts :exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board.
2015-04-12 18:44 ` Anand Moon
@ 2015-04-12 18:44 ` Anand Moon
-1 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: Lukasz Majewski, Guenter Roeck, Eduardo Valentin, Sjoerd Simons,
Markus Reichl, Russell King, Kukjin Kim
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Anand Moon
Add pwm-fan node to the OdroidXU3 board.
Tested on OdroidXU3 board.
Changes since v1 : None
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index a519c86..04d982b 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -278,6 +278,15 @@
rtc@101E0000 {
status = "okay";
};
+
+ fan0: pwm-fan {
+ compatible = "pwm-fan";
+ pwms = <&pwm 0 20972 0>;
+ cooling-min-state = <0>;
+ cooling-max-state = <3>;
+ #cooling-cells = <2>;
+ cooling-levels = <0 130 170 230>;
+ };
};
&hdmi {
@@ -369,3 +378,10 @@
shunt-resistor = <10000>;
};
};
+
+&pwm {
+ pinctrl-0 = <&pwm0_out>;
+ pinctrl-names = "default";
+ samsung,pwm-outputs = <0>;
+ status = "okay";
+};
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v4 1/6] ARM: dts :exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board.
@ 2015-04-12 18:44 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: linux-arm-kernel
Add pwm-fan node to the OdroidXU3 board.
Tested on OdroidXU3 board.
Changes since v1 : None
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index a519c86..04d982b 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -278,6 +278,15 @@
rtc at 101E0000 {
status = "okay";
};
+
+ fan0: pwm-fan {
+ compatible = "pwm-fan";
+ pwms = <&pwm 0 20972 0>;
+ cooling-min-state = <0>;
+ cooling-max-state = <3>;
+ #cooling-cells = <2>;
+ cooling-levels = <0 130 170 230>;
+ };
};
&hdmi {
@@ -369,3 +378,10 @@
shunt-resistor = <10000>;
};
};
+
+&pwm {
+ pinctrl-0 = <&pwm0_out>;
+ pinctrl-names = "default";
+ samsung,pwm-outputs = <0>;
+ status = "okay";
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v4 2/6] ARM: dts: OdroidXU3: Enable TMU at Exynos5422 base.
2015-04-12 18:44 ` Anand Moon
@ 2015-04-12 18:44 ` Anand Moon
-1 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: Lukasz Majewski, Guenter Roeck, Eduardo Valentin, Sjoerd Simons,
Markus Reichl, Russell King, Kukjin Kim
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA, Anand Moon
This commit enables TMU IP block on the Exynos5422 OdroidXU3
device.
Tested on OdroidXU3 board.
Changes since v1 : None
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 04d982b..6e7ee53 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -287,6 +287,31 @@
#cooling-cells = <2>;
cooling-levels = <0 130 170 230>;
};
+
+ tmu@10060000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
+
+ tmu@10064000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
+
+ tmu@10068000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
+
+ tmu@1006c000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
+
+ tmu@100a0000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
};
&hdmi {
--
1.9.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v4 2/6] ARM: dts: OdroidXU3: Enable TMU at Exynos5422 base.
@ 2015-04-12 18:44 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: linux-arm-kernel
This commit enables TMU IP block on the Exynos5422 OdroidXU3
device.
Tested on OdroidXU3 board.
Changes since v1 : None
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 04d982b..6e7ee53 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -287,6 +287,31 @@
#cooling-cells = <2>;
cooling-levels = <0 130 170 230>;
};
+
+ tmu at 10060000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
+
+ tmu at 10064000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
+
+ tmu at 10068000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
+
+ tmu at 1006c000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
+
+ tmu at 100a0000 {
+ vtmu-supply = <&ldo10_reg>;
+ status = "okay";
+ };
};
&hdmi {
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v4 3/6] ARM: dts: define default thermal-zones for exynos5
2015-04-12 18:44 ` Anand Moon
@ 2015-04-12 18:44 ` Anand Moon
-1 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: Lukasz Majewski, Guenter Roeck, Eduardo Valentin, Sjoerd Simons,
Markus Reichl, Russell King, Kukjin Kim
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, Anand Moon
Trip points corresponding to the one defined in the exynos_tmu_data.c
for Exynos5 have been included.
This thermal-zones attribute is afterwards reused for Exynos5422.
Changes since v1 : Fixed the thernal_sensor registration of the sensors tmu_cpu0
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5-cpu-thermal.dtsi | 59 ++++++++++++++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
diff --git a/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
new file mode 100644
index 0000000..3ce8872
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
@@ -0,0 +1,59 @@
+/*
+ * Device tree sources for Exynos5 thermal zone
+ *
+ * Copyright (c) 2015 Lukasz Majewski <l.majewski@samsung.com>
+ * Anand Moon <linux.amoon@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+ thermal-zones {
+ cpu0_thermal: cpu0-thermal {
+ thermal-sensors = <&tmu_cpu0 0>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
+ trips {
+ cpu_alert0: cpu-alert-0 {
+ temperature = <50000>; /* millicelsius */
+ hysteresis = <5000>; /* millicelsius */
+ type = "active";
+ };
+ cpu_alert1: cpu-alert-1 {
+ temperature = <60000>; /* millicelsius */
+ hysteresis = <5000>; /* millicelsius */
+ type = "active";
+ };
+ cpu_alert2: cpu-alert-2 {
+ temperature = <70000>; /* millicelsius */
+ hysteresis = <5000>; /* millicelsius */
+ type = "active";
+ };
+ cpu_crit0: cpu-crit-0 {
+ temperature = <100000>; /* millicelsius */
+ hysteresis = <0>; /* millicelsius */
+ type = "critical";
+ };
+ };
+ cooling-maps {
+ map0 {
+ trip = <&cpu_alert0>;
+ cooling-device = <&fan0 0 1>;
+ };
+ map1 {
+ trip = <&cpu_alert1>;
+ cooling-device = <&fan0 1 2>;
+ };
+ map2 {
+ trip = <&cpu_alert2>;
+ cooling-device = <&fan0 2 3>;
+ };
+ };
+ };
+ };
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v4 3/6] ARM: dts: define default thermal-zones for exynos5
@ 2015-04-12 18:44 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: linux-arm-kernel
Trip points corresponding to the one defined in the exynos_tmu_data.c
for Exynos5 have been included.
This thermal-zones attribute is afterwards reused for Exynos5422.
Changes since v1 : Fixed the thernal_sensor registration of the sensors tmu_cpu0
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5-cpu-thermal.dtsi | 59 ++++++++++++++++++++++++++++++
1 file changed, 59 insertions(+)
create mode 100644 arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
diff --git a/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
new file mode 100644
index 0000000..3ce8872
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
@@ -0,0 +1,59 @@
+/*
+ * Device tree sources for Exynos5 thermal zone
+ *
+ * Copyright (c) 2015 Lukasz Majewski <l.majewski@samsung.com>
+ * Anand Moon <linux.amoon@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+ thermal-zones {
+ cpu0_thermal: cpu0-thermal {
+ thermal-sensors = <&tmu_cpu0 0>;
+ polling-delay-passive = <0>;
+ polling-delay = <0>;
+ trips {
+ cpu_alert0: cpu-alert-0 {
+ temperature = <50000>; /* millicelsius */
+ hysteresis = <5000>; /* millicelsius */
+ type = "active";
+ };
+ cpu_alert1: cpu-alert-1 {
+ temperature = <60000>; /* millicelsius */
+ hysteresis = <5000>; /* millicelsius */
+ type = "active";
+ };
+ cpu_alert2: cpu-alert-2 {
+ temperature = <70000>; /* millicelsius */
+ hysteresis = <5000>; /* millicelsius */
+ type = "active";
+ };
+ cpu_crit0: cpu-crit-0 {
+ temperature = <100000>; /* millicelsius */
+ hysteresis = <0>; /* millicelsius */
+ type = "critical";
+ };
+ };
+ cooling-maps {
+ map0 {
+ trip = <&cpu_alert0>;
+ cooling-device = <&fan0 0 1>;
+ };
+ map1 {
+ trip = <&cpu_alert1>;
+ cooling-device = <&fan0 1 2>;
+ };
+ map2 {
+ trip = <&cpu_alert2>;
+ cooling-device = <&fan0 2 3>;
+ };
+ };
+ };
+ };
+};
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v4 4/6] ARM: dts exynos5420 update the cooling cells for core cpu0
2015-04-12 18:44 ` Anand Moon
@ 2015-04-12 18:44 ` Anand Moon
-1 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: Lukasz Majewski, Guenter Roeck, Eduardo Valentin, Sjoerd Simons,
Markus Reichl, Russell King, Kukjin Kim
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, Anand Moon
update the cooling level for cpu0 to avoid following message.
root@odroidxu3:~# dmesg | grep ther
[ 0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
could not get #cooling-cells for /cpus/cpu@0
Tested on OdroidXU3
Changes since v1 : None
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index c0e98cf..6b49f3c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -61,6 +61,10 @@
reg = <0x0>;
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
+
+ cooling-min-level = <10>;
+ cooling-max-level = <7>;
+ #cooling-cells = <2>; /* min followed by max */
};
cpu1: cpu@1 {
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v4 4/6] ARM: dts exynos5420 update the cooling cells for core cpu0
@ 2015-04-12 18:44 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: linux-arm-kernel
update the cooling level for cpu0 to avoid following message.
root at odroidxu3:~# dmesg | grep ther
[ 0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
could not get #cooling-cells for /cpus/cpu at 0
Tested on OdroidXU3
Changes since v1 : None
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index c0e98cf..6b49f3c 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -61,6 +61,10 @@
reg = <0x0>;
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
+
+ cooling-min-level = <10>;
+ cooling-max-level = <7>;
+ #cooling-cells = <2>; /* min followed by max */
};
cpu1: cpu at 1 {
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v4 5/6] ARM: dts: Enable thermal_zone for exynos5422.
2015-04-12 18:44 ` Anand Moon
@ 2015-04-12 18:44 ` Anand Moon
-1 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: Lukasz Majewski, Guenter Roeck, Eduardo Valentin, Sjoerd Simons,
Markus Reichl, Russell King, Kukjin Kim
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, Anand Moon
Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
Changes since v1 : Separate the include previous patch.
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 6e7ee53..16a5f10 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -12,6 +12,7 @@
/dts-v1/;
#include "exynos5800.dtsi"
+#include "exynos5-cpu-thermal.dtsi"
/ {
model = "Hardkernel Odroid XU3";
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v4 5/6] ARM: dts: Enable thermal_zone for exynos5422.
@ 2015-04-12 18:44 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: linux-arm-kernel
Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
Changes since v1 : Separate the include previous patch.
Changes since v2 : None
Changes since v3 : None
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
arch/arm/boot/dts/exynos5422-odroidxu3.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 6e7ee53..16a5f10 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -12,6 +12,7 @@
/dts-v1/;
#include "exynos5800.dtsi"
+#include "exynos5-cpu-thermal.dtsi"
/ {
model = "Hardkernel Odroid XU3";
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH v4 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan
2015-04-12 18:44 ` Anand Moon
@ 2015-04-12 18:44 ` Anand Moon
-1 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: Lukasz Majewski, Guenter Roeck, Eduardo Valentin, Sjoerd Simons,
Markus Reichl, Russell King, Kukjin Kim
Cc: devicetree, linux-arm-kernel, linux-samsung-soc, Anand Moon
pwm_config() must be called with a duty cycle of 0 prior to calling
pwm_disable() to ensure that the pwm signal is set to low.
Changes since v1 : None.
Changes since v2 : None
Changes since v3 : Simplify the comment.
Reported-by: Markus Reichl <m.reichl@fivetechno.de>
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
drivers/hwmon/pwm-fan.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 7c83dc4..c2a469e 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -47,23 +47,20 @@ static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm)
if (ctx->pwm_value == pwm)
goto exit_set_pwm_err;
- if (pwm == 0) {
- pwm_disable(ctx->pwm);
- goto exit_set_pwm;
- }
-
duty = DIV_ROUND_UP(pwm * (ctx->pwm->period - 1), MAX_PWM);
ret = pwm_config(ctx->pwm, duty, ctx->pwm->period);
if (ret)
goto exit_set_pwm_err;
+ if (pwm == 0)
+ pwm_disable(ctx->pwm);
+
if (ctx->pwm_value == 0) {
ret = pwm_enable(ctx->pwm);
if (ret)
goto exit_set_pwm_err;
}
-exit_set_pwm:
ctx->pwm_value = pwm;
exit_set_pwm_err:
mutex_unlock(&ctx->lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* [PATCH v4 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan
@ 2015-04-12 18:44 ` Anand Moon
0 siblings, 0 replies; 16+ messages in thread
From: Anand Moon @ 2015-04-12 18:44 UTC (permalink / raw)
To: linux-arm-kernel
pwm_config() must be called with a duty cycle of 0 prior to calling
pwm_disable() to ensure that the pwm signal is set to low.
Changes since v1 : None.
Changes since v2 : None
Changes since v3 : Simplify the comment.
Reported-by: Markus Reichl <m.reichl@fivetechno.de>
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
drivers/hwmon/pwm-fan.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c
index 7c83dc4..c2a469e 100644
--- a/drivers/hwmon/pwm-fan.c
+++ b/drivers/hwmon/pwm-fan.c
@@ -47,23 +47,20 @@ static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm)
if (ctx->pwm_value == pwm)
goto exit_set_pwm_err;
- if (pwm == 0) {
- pwm_disable(ctx->pwm);
- goto exit_set_pwm;
- }
-
duty = DIV_ROUND_UP(pwm * (ctx->pwm->period - 1), MAX_PWM);
ret = pwm_config(ctx->pwm, duty, ctx->pwm->period);
if (ret)
goto exit_set_pwm_err;
+ if (pwm == 0)
+ pwm_disable(ctx->pwm);
+
if (ctx->pwm_value == 0) {
ret = pwm_enable(ctx->pwm);
if (ret)
goto exit_set_pwm_err;
}
-exit_set_pwm:
ctx->pwm_value = pwm;
exit_set_pwm_err:
mutex_unlock(&ctx->lock);
--
1.9.1
^ permalink raw reply related [flat|nested] 16+ messages in thread* Re: [PATCH v4 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan
2015-04-12 18:44 ` Anand Moon
@ 2015-04-12 23:00 ` Guenter Roeck
-1 siblings, 0 replies; 16+ messages in thread
From: Guenter Roeck @ 2015-04-12 23:00 UTC (permalink / raw)
To: Anand Moon, Lukasz Majewski, Eduardo Valentin, Sjoerd Simons,
Markus Reichl, Russell King, Kukjin Kim
Cc: devicetree, linux-arm-kernel, linux-samsung-soc
On 04/12/2015 11:44 AM, Anand Moon wrote:
> pwm_config() must be called with a duty cycle of 0 prior to calling
> pwm_disable() to ensure that the pwm signal is set to low.
>
> Changes since v1 : None.
> Changes since v2 : None
> Changes since v3 : Simplify the comment.
>
> Reported-by: Markus Reichl <m.reichl@fivetechno.de>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Applied to hwmon-next (after removing the changelog from
the commit message).
Thanks,
Guenter
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH v4 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan
@ 2015-04-12 23:00 ` Guenter Roeck
0 siblings, 0 replies; 16+ messages in thread
From: Guenter Roeck @ 2015-04-12 23:00 UTC (permalink / raw)
To: linux-arm-kernel
On 04/12/2015 11:44 AM, Anand Moon wrote:
> pwm_config() must be called with a duty cycle of 0 prior to calling
> pwm_disable() to ensure that the pwm signal is set to low.
>
> Changes since v1 : None.
> Changes since v2 : None
> Changes since v3 : Simplify the comment.
>
> Reported-by: Markus Reichl <m.reichl@fivetechno.de>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Applied to hwmon-next (after removing the changelog from
the commit message).
Thanks,
Guenter
^ permalink raw reply [flat|nested] 16+ messages in thread