All of lore.kernel.org
 help / color / mirror / Atom feed
* [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
@ 2015-04-08  7:43 ` Igal.Liberman
  0 siblings, 0 replies; 12+ messages in thread
From: Igal.Liberman @ 2015-04-08  7:43 UTC (permalink / raw)
  To: devicetree, linuxppc-dev; +Cc: scottwood, Igal Liberman

From: Igal Liberman <Igal.Liberman@freescale.com>

v2: Addressed feedback from Scott:
	- Moved the "fman-clk-mux" clock provider details
	  under "clocks" property.

Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
---
 .../devicetree/bindings/clock/qoriq-clock.txt      |   63 +++++++++++++++++++-
 1 file changed, 61 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
index df4a259..4d63ac6 100644
--- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
+++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
@@ -65,9 +65,10 @@ Required properties:
 		It takes parent's clock-frequency as its clock.
 	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
 	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
+	* "fsl,fman-clk-mux" for the Frame Manager clock.
 - #clock-cells: From common clock binding. The number of cells in a
-	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
-	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
+	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
+	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
 	For "fsl,qoriq-core-pll-[1,2].0" clocks, the single
 	clock-specifier cell may take the following values:
 	* 0 - equal to the PLL frequency
@@ -76,6 +77,52 @@ Required properties:
 
 Recommended properties:
 - clocks: Should be the phandle of input parent clock
+	For "fsl,fman-clk-mux" clock there are several options for parent
+	clock (clock provider), the parent is determined according to the
+	Reset Configuration Word of the specific device:
+		* P2041, P3041:
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL2 divided by 2
+		* P4080 (Both FMans):
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL3 divided by 2
+		* P5020:
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL2 divided by 2
+			* 2 - equal to PLL2 divided by 4
+		* P5040 (Both FMans):
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL3 divided by 2
+			* 2 - equal to PLL3 divided by 4
+		* T1024:
+			* 0 - equal to PLL1 divided by 2
+		* T1040:
+			* 0 - equal to platform PLL
+		* T2080, B4860, B4420:
+			* 0 - equal to PLL1
+			* 1 - equal to PLL1 divided by 2
+			* 2 - equal to PLL1 divided by 3
+			* 3 - equal to PLL1 divided by 4
+			* 4 - equal to platform PLL
+			* 5 - equal to PLL2 divided by 2
+			* 6 - equal to PLL2 divided by 3
+		* T4240:
+			* FM1:
+			* 0 equal to PLL1 divided by 2
+			* 1 equal to PLL1 divided by 3
+			* 2 equal to PLL1 divided by 4
+			* 3 equal to platform PLL
+			* 4 equal to PLL2 divided by 2
+			* FM2:
+			* 0 equal to PLL2 divided by 2
+			* 1 equal to PLL2 divided by 3
+			* 2 equal to PLL2 divided by 4
+			* 3 equal to platform PLL
+			* 4 equal to PLL1 divided by 2
+			* 5 equal to PLL1 divided by 3
+	In Part of FMan V3 devices (B4, T2, T4) the single
+	clock-specifier cell may be determined by the CLKCGxHWACSR
+	register in addtion to RCW.
 - clock-names: From common clock binding, indicates the clock name
 - clock-output-names: From common clock binding, indicates the names of
 	output clocks
@@ -139,6 +186,18 @@ Example for clock block and clock provider:
 			clocks = <&sysclk>;
 			clock-output-names = "platform-pll", "platform-pll-div2";
 		};
+
+		fm0clk: fm0-clk-mux {
+			#clock-cells = <0>;
+			reg = <0x10 4>
+			compatible = "fsl,fman-clk-mux";
+			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
+				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
+			clock-names = "pll0", "pll0-div2", "pll0-div3",
+				      "pll0-div4", "platform-pll", "pll1-div2",
+				      "pll1-div3";
+			clock-output-names = "fm0-clk";
+		};
 	};
 };
 
-- 
1.7.9.5

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
@ 2015-04-08  7:43 ` Igal.Liberman
  0 siblings, 0 replies; 12+ messages in thread
From: Igal.Liberman @ 2015-04-08  7:43 UTC (permalink / raw)
  To: devicetree, linuxppc-dev; +Cc: scottwood, Igal Liberman

From: Igal Liberman <Igal.Liberman@freescale.com>

v2: Addressed feedback from Scott:
	- Moved the "fman-clk-mux" clock provider details
	  under "clocks" property.

Signed-off-by: Igal Liberman <Igal.Liberman@freescale.com>
---
 .../devicetree/bindings/clock/qoriq-clock.txt      |   63 +++++++++++++++++++-
 1 file changed, 61 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qoriq-clock.txt b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
index df4a259..4d63ac6 100644
--- a/Documentation/devicetree/bindings/clock/qoriq-clock.txt
+++ b/Documentation/devicetree/bindings/clock/qoriq-clock.txt
@@ -65,9 +65,10 @@ Required properties:
 		It takes parent's clock-frequency as its clock.
 	* "fsl,qoriq-platform-pll-1.0" for the platform PLL clock (v1.0)
 	* "fsl,qoriq-platform-pll-2.0" for the platform PLL clock (v2.0)
+	* "fsl,fman-clk-mux" for the Frame Manager clock.
 - #clock-cells: From common clock binding. The number of cells in a
-	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0"
-	clocks, or <1> for "fsl,qoriq-core-pll-[1,2].0" clocks.
+	clock-specifier. Should be <0> for "fsl,qoriq-sysclk-[1,2].0" and
+	"fsl,fman-clk-mux" clocks or <1> for "fsl,qoriq-core-pll-[1,2].0".
 	For "fsl,qoriq-core-pll-[1,2].0" clocks, the single
 	clock-specifier cell may take the following values:
 	* 0 - equal to the PLL frequency
@@ -76,6 +77,52 @@ Required properties:
 
 Recommended properties:
 - clocks: Should be the phandle of input parent clock
+	For "fsl,fman-clk-mux" clock there are several options for parent
+	clock (clock provider), the parent is determined according to the
+	Reset Configuration Word of the specific device:
+		* P2041, P3041:
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL2 divided by 2
+		* P4080 (Both FMans):
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL3 divided by 2
+		* P5020:
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL2 divided by 2
+			* 2 - equal to PLL2 divided by 4
+		* P5040 (Both FMans):
+			* 0 - equal to platform PLL divided by 2
+			* 1 - equal to PLL3 divided by 2
+			* 2 - equal to PLL3 divided by 4
+		* T1024:
+			* 0 - equal to PLL1 divided by 2
+		* T1040:
+			* 0 - equal to platform PLL
+		* T2080, B4860, B4420:
+			* 0 - equal to PLL1
+			* 1 - equal to PLL1 divided by 2
+			* 2 - equal to PLL1 divided by 3
+			* 3 - equal to PLL1 divided by 4
+			* 4 - equal to platform PLL
+			* 5 - equal to PLL2 divided by 2
+			* 6 - equal to PLL2 divided by 3
+		* T4240:
+			* FM1:
+			* 0 equal to PLL1 divided by 2
+			* 1 equal to PLL1 divided by 3
+			* 2 equal to PLL1 divided by 4
+			* 3 equal to platform PLL
+			* 4 equal to PLL2 divided by 2
+			* FM2:
+			* 0 equal to PLL2 divided by 2
+			* 1 equal to PLL2 divided by 3
+			* 2 equal to PLL2 divided by 4
+			* 3 equal to platform PLL
+			* 4 equal to PLL1 divided by 2
+			* 5 equal to PLL1 divided by 3
+	In Part of FMan V3 devices (B4, T2, T4) the single
+	clock-specifier cell may be determined by the CLKCGxHWACSR
+	register in addtion to RCW.
 - clock-names: From common clock binding, indicates the clock name
 - clock-output-names: From common clock binding, indicates the names of
 	output clocks
@@ -139,6 +186,18 @@ Example for clock block and clock provider:
 			clocks = <&sysclk>;
 			clock-output-names = "platform-pll", "platform-pll-div2";
 		};
+
+		fm0clk: fm0-clk-mux {
+			#clock-cells = <0>;
+			reg = <0x10 4>
+			compatible = "fsl,fman-clk-mux";
+			clocks = <&pll0 0>, <&pll0 1>, <&pll0 2>, <&pll0 3>,
+				 <&platform_pll 0>, <&pll1 1>, <&pll1 2>;
+			clock-names = "pll0", "pll0-div2", "pll0-div3",
+				      "pll0-div4", "platform-pll", "pll1-div2",
+				      "pll1-div3";
+			clock-output-names = "fm0-clk";
+		};
 	};
 };
 
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 12+ messages in thread

* Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
  2015-04-08  7:43 ` Igal.Liberman
@ 2015-04-08 21:11   ` Scott Wood
  -1 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2015-04-08 21:11 UTC (permalink / raw)
  To: Igal.Liberman; +Cc: devicetree, linuxppc-dev

On Wed, 2015-04-08 at 10:43 +0300, Igal.Liberman wrote:
> @@ -76,6 +77,52 @@ Required properties:
>  
>  Recommended properties:
>  - clocks: Should be the phandle of input parent clock
> +	For "fsl,fman-clk-mux" clock there are several options for parent
> +	clock (clock provider), the parent is determined according to the
> +	Reset Configuration Word of the specific device:
> +		* P2041, P3041:
> +			* 0 - equal to platform PLL divided by 2
> +			* 1 - equal to PLL2 divided by 2
> +		* P4080 (Both FMans):
> +			* 0 - equal to platform PLL divided by 2
> +			* 1 - equal to PLL3 divided by 2
...


Again, the clock specifier format is determined by the clock provider,
not the clock consumer.

-Scott


_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
@ 2015-04-08 21:11   ` Scott Wood
  0 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2015-04-08 21:11 UTC (permalink / raw)
  To: Igal.Liberman; +Cc: devicetree, linuxppc-dev

On Wed, 2015-04-08 at 10:43 +0300, Igal.Liberman wrote:
> @@ -76,6 +77,52 @@ Required properties:
>  
>  Recommended properties:
>  - clocks: Should be the phandle of input parent clock
> +	For "fsl,fman-clk-mux" clock there are several options for parent
> +	clock (clock provider), the parent is determined according to the
> +	Reset Configuration Word of the specific device:
> +		* P2041, P3041:
> +			* 0 - equal to platform PLL divided by 2
> +			* 1 - equal to PLL2 divided by 2
> +		* P4080 (Both FMans):
> +			* 0 - equal to platform PLL divided by 2
> +			* 1 - equal to PLL3 divided by 2
...


Again, the clock specifier format is determined by the clock provider,
not the clock consumer.

-Scott

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
  2015-04-08 21:11   ` Scott Wood
@ 2015-04-09  7:18     ` Igal.Liberman
  -1 siblings, 0 replies; 12+ messages in thread
From: Igal.Liberman @ 2015-04-09  7:18 UTC (permalink / raw)
  To: Scott Wood; +Cc: devicetree, linuxppc-dev



Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, April 09, 2015 12:12 AM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> 
> On Wed, 2015-04-08 at 10:43 +0300, Igal.Liberman wrote:
> > @@ -76,6 +77,52 @@ Required properties:
> >
> >  Recommended properties:
> >  - clocks: Should be the phandle of input parent clock
> > +	For "fsl,fman-clk-mux" clock there are several options for parent
> > +	clock (clock provider), the parent is determined according to the
> > +	Reset Configuration Word of the specific device:
> > +		* P2041, P3041:
> > +			* 0 - equal to platform PLL divided by 2
> > +			* 1 - equal to PLL2 divided by 2
> > +		* P4080 (Both FMans):
> > +			* 0 - equal to platform PLL divided by 2
> > +			* 1 - equal to PLL3 divided by 2
> ...
> 
> 
> Again, the clock specifier format is determined by the clock provider, not the
> clock consumer.
> 

Scott,
The "clocks" property contains all possible clock providers, right?
In the text above I'm trying to explain how the FMan clock provider is determined and what are the options for each SoC.
Do you think that we shouldn't have this explanation? Can you please elaborate?

Igal.

> -Scott
> 

_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
@ 2015-04-09  7:18     ` Igal.Liberman
  0 siblings, 0 replies; 12+ messages in thread
From: Igal.Liberman @ 2015-04-09  7:18 UTC (permalink / raw)
  To: Scott Wood; +Cc: devicetree, linuxppc-dev

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFRodXJzZGF5LCBBcHJpbCAw
OSwgMjAxNSAxMjoxMiBBTQ0KPiBUbzogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gQ2M6IGRldmlj
ZXRyZWVAdmdlci5rZXJuZWwub3JnOyBsaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZw0KPiBT
dWJqZWN0OiBSZTogW3YyXSBkdC9iaW5kaW5nczogcW9yaXEtY2xvY2s6IEFkZCBiaW5kaW5nIGZv
ciBGTWFuIGNsb2NrIG11eA0KPiANCj4gT24gV2VkLCAyMDE1LTA0LTA4IGF0IDEwOjQzICswMzAw
LCBJZ2FsLkxpYmVybWFuIHdyb3RlOg0KPiA+IEBAIC03Niw2ICs3Nyw1MiBAQCBSZXF1aXJlZCBw
cm9wZXJ0aWVzOg0KPiA+DQo+ID4gIFJlY29tbWVuZGVkIHByb3BlcnRpZXM6DQo+ID4gIC0gY2xv
Y2tzOiBTaG91bGQgYmUgdGhlIHBoYW5kbGUgb2YgaW5wdXQgcGFyZW50IGNsb2NrDQo+ID4gKwlG
b3IgImZzbCxmbWFuLWNsay1tdXgiIGNsb2NrIHRoZXJlIGFyZSBzZXZlcmFsIG9wdGlvbnMgZm9y
IHBhcmVudA0KPiA+ICsJY2xvY2sgKGNsb2NrIHByb3ZpZGVyKSwgdGhlIHBhcmVudCBpcyBkZXRl
cm1pbmVkIGFjY29yZGluZyB0byB0aGUNCj4gPiArCVJlc2V0IENvbmZpZ3VyYXRpb24gV29yZCBv
ZiB0aGUgc3BlY2lmaWMgZGV2aWNlOg0KPiA+ICsJCSogUDIwNDEsIFAzMDQxOg0KPiA+ICsJCQkq
IDAgLSBlcXVhbCB0byBwbGF0Zm9ybSBQTEwgZGl2aWRlZCBieSAyDQo+ID4gKwkJCSogMSAtIGVx
dWFsIHRvIFBMTDIgZGl2aWRlZCBieSAyDQo+ID4gKwkJKiBQNDA4MCAoQm90aCBGTWFucyk6DQo+
ID4gKwkJCSogMCAtIGVxdWFsIHRvIHBsYXRmb3JtIFBMTCBkaXZpZGVkIGJ5IDINCj4gPiArCQkJ
KiAxIC0gZXF1YWwgdG8gUExMMyBkaXZpZGVkIGJ5IDINCj4gLi4uDQo+IA0KPiANCj4gQWdhaW4s
IHRoZSBjbG9jayBzcGVjaWZpZXIgZm9ybWF0IGlzIGRldGVybWluZWQgYnkgdGhlIGNsb2NrIHBy
b3ZpZGVyLCBub3QgdGhlDQo+IGNsb2NrIGNvbnN1bWVyLg0KPiANCg0KU2NvdHQsDQpUaGUgImNs
b2NrcyIgcHJvcGVydHkgY29udGFpbnMgYWxsIHBvc3NpYmxlIGNsb2NrIHByb3ZpZGVycywgcmln
aHQ/DQpJbiB0aGUgdGV4dCBhYm92ZSBJJ20gdHJ5aW5nIHRvIGV4cGxhaW4gaG93IHRoZSBGTWFu
IGNsb2NrIHByb3ZpZGVyIGlzIGRldGVybWluZWQgYW5kIHdoYXQgYXJlIHRoZSBvcHRpb25zIGZv
ciBlYWNoIFNvQy4NCkRvIHlvdSB0aGluayB0aGF0IHdlIHNob3VsZG4ndCBoYXZlIHRoaXMgZXhw
bGFuYXRpb24/IENhbiB5b3UgcGxlYXNlIGVsYWJvcmF0ZT8NCg0KSWdhbC4NCg0KPiAtU2NvdHQN
Cj4gDQoNCg==

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
  2015-04-09  7:18     ` Igal.Liberman
@ 2015-04-09 17:02         ` Scott Wood
  -1 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2015-04-09 17:02 UTC (permalink / raw)
  To: Liberman Igal-B31950
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ

On Thu, 2015-04-09 at 02:18 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, April 09, 2015 12:12 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Wed, 2015-04-08 at 10:43 +0300, Igal.Liberman wrote:
> > > @@ -76,6 +77,52 @@ Required properties:
> > >
> > >  Recommended properties:
> > >  - clocks: Should be the phandle of input parent clock
> > > +	For "fsl,fman-clk-mux" clock there are several options for parent
> > > +	clock (clock provider), the parent is determined according to the
> > > +	Reset Configuration Word of the specific device:
> > > +		* P2041, P3041:
> > > +			* 0 - equal to platform PLL divided by 2
> > > +			* 1 - equal to PLL2 divided by 2
> > > +		* P4080 (Both FMans):
> > > +			* 0 - equal to platform PLL divided by 2
> > > +			* 1 - equal to PLL3 divided by 2
> > ...
> > 
> > 
> > Again, the clock specifier format is determined by the clock provider, not the
> > clock consumer.
> > 
> 
> Scott,
> The "clocks" property contains all possible clock providers, right?
> In the text above I'm trying to explain how the FMan clock provider is determined and what are the options for each SoC.
> Do you think that we shouldn't have this explanation? Can you please elaborate?

I'm saying that the clock specifiers must be the same regardless of the
node that is consuming the clock.  You can't define certain values as
only being "for fsl,fman-clk-mux".

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
@ 2015-04-09 17:02         ` Scott Wood
  0 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2015-04-09 17:02 UTC (permalink / raw)
  To: Liberman Igal-B31950; +Cc: devicetree, linuxppc-dev

On Thu, 2015-04-09 at 02:18 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, April 09, 2015 12:12 AM
> > To: Liberman Igal-B31950
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Wed, 2015-04-08 at 10:43 +0300, Igal.Liberman wrote:
> > > @@ -76,6 +77,52 @@ Required properties:
> > >
> > >  Recommended properties:
> > >  - clocks: Should be the phandle of input parent clock
> > > +	For "fsl,fman-clk-mux" clock there are several options for parent
> > > +	clock (clock provider), the parent is determined according to the
> > > +	Reset Configuration Word of the specific device:
> > > +		* P2041, P3041:
> > > +			* 0 - equal to platform PLL divided by 2
> > > +			* 1 - equal to PLL2 divided by 2
> > > +		* P4080 (Both FMans):
> > > +			* 0 - equal to platform PLL divided by 2
> > > +			* 1 - equal to PLL3 divided by 2
> > ...
> > 
> > 
> > Again, the clock specifier format is determined by the clock provider, not the
> > clock consumer.
> > 
> 
> Scott,
> The "clocks" property contains all possible clock providers, right?
> In the text above I'm trying to explain how the FMan clock provider is determined and what are the options for each SoC.
> Do you think that we shouldn't have this explanation? Can you please elaborate?

I'm saying that the clock specifiers must be the same regardless of the
node that is consuming the clock.  You can't define certain values as
only being "for fsl,fman-clk-mux".

-Scott

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
  2015-04-09 17:02         ` Scott Wood
@ 2015-04-12 15:54             ` Igal.Liberman
  -1 siblings, 0 replies; 12+ messages in thread
From: Igal.Liberman-KZfg59tc24xl57MIdRCFDg @ 2015-04-12 15:54 UTC (permalink / raw)
  To: Scott Wood
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ



Regards,
Igal Liberman.

> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Thursday, April 09, 2015 8:03 PM
> To: Liberman Igal-B31950
> Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> 
> On Thu, 2015-04-09 at 02:18 -0500, Liberman Igal-B31950 wrote:
> >
> >
> > Regards,
> > Igal Liberman.
> >
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Thursday, April 09, 2015 12:12 AM
> > > To: Liberman Igal-B31950
> > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan
> > > clock mux
> > >
> > > On Wed, 2015-04-08 at 10:43 +0300, Igal.Liberman wrote:
> > > > @@ -76,6 +77,52 @@ Required properties:
> > > >
> > > >  Recommended properties:
> > > >  - clocks: Should be the phandle of input parent clock
> > > > +	For "fsl,fman-clk-mux" clock there are several options for parent
> > > > +	clock (clock provider), the parent is determined according to the
> > > > +	Reset Configuration Word of the specific device:
> > > > +		* P2041, P3041:
> > > > +			* 0 - equal to platform PLL divided by 2
> > > > +			* 1 - equal to PLL2 divided by 2
> > > > +		* P4080 (Both FMans):
> > > > +			* 0 - equal to platform PLL divided by 2
> > > > +			* 1 - equal to PLL3 divided by 2
> > > ...
> > >
> > >
> > > Again, the clock specifier format is determined by the clock
> > > provider, not the clock consumer.
> > >
> >
> > Scott,
> > The "clocks" property contains all possible clock providers, right?
> > In the text above I'm trying to explain how the FMan clock provider is
> determined and what are the options for each SoC.
> > Do you think that we shouldn't have this explanation? Can you please
> elaborate?
> 
> I'm saying that the clock specifiers must be the same regardless of the node
> that is consuming the clock.  You can't define certain values as only being "for
> fsl,fman-clk-mux".
> 

Just to make things clear,
In "fm0clk/fm1clk" node, "clocks" holds a list of clock specifiers.
This list reflects all optional clock providers for a specific hardware, this list varies between different SoCs.
All those possible providers described by other nodes, as clock providers.
Please notice that this bindings describes the possible source clock for FMan mux, not the providers themselves.

You mentioned the following: "You can't define certain values as only being "for fsl,fman-clk-mux"."
I'm defining those values in the clock provider nodes and using those values as clock providers for FMan mux, it can be used be other HW blocks too.
 
Igal.

> -Scott
> 


^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
@ 2015-04-12 15:54             ` Igal.Liberman
  0 siblings, 0 replies; 12+ messages in thread
From: Igal.Liberman @ 2015-04-12 15:54 UTC (permalink / raw)
  To: Scott Wood; +Cc: devicetree, linuxppc-dev

DQoNClJlZ2FyZHMsDQpJZ2FsIExpYmVybWFuLg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0t
LS0tDQo+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+IFNlbnQ6IFRodXJzZGF5LCBBcHJpbCAw
OSwgMjAxNSA4OjAzIFBNDQo+IFRvOiBMaWJlcm1hbiBJZ2FsLUIzMTk1MA0KPiBDYzogZGV2aWNl
dHJlZUB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnDQo+IFN1
YmplY3Q6IFJlOiBbdjJdIGR0L2JpbmRpbmdzOiBxb3JpcS1jbG9jazogQWRkIGJpbmRpbmcgZm9y
IEZNYW4gY2xvY2sgbXV4DQo+IA0KPiBPbiBUaHUsIDIwMTUtMDQtMDkgYXQgMDI6MTggLTA1MDAs
IExpYmVybWFuIElnYWwtQjMxOTUwIHdyb3RlOg0KPiA+DQo+ID4NCj4gPiBSZWdhcmRzLA0KPiA+
IElnYWwgTGliZXJtYW4uDQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+
ID4gPiBGcm9tOiBXb29kIFNjb3R0LUIwNzQyMQ0KPiA+ID4gU2VudDogVGh1cnNkYXksIEFwcmls
IDA5LCAyMDE1IDEyOjEyIEFNDQo+ID4gPiBUbzogTGliZXJtYW4gSWdhbC1CMzE5NTANCj4gPiA+
IENjOiBkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZzsgbGludXhwcGMtZGV2QGxpc3RzLm96bGFi
cy5vcmcNCj4gPiA+IFN1YmplY3Q6IFJlOiBbdjJdIGR0L2JpbmRpbmdzOiBxb3JpcS1jbG9jazog
QWRkIGJpbmRpbmcgZm9yIEZNYW4NCj4gPiA+IGNsb2NrIG11eA0KPiA+ID4NCj4gPiA+IE9uIFdl
ZCwgMjAxNS0wNC0wOCBhdCAxMDo0MyArMDMwMCwgSWdhbC5MaWJlcm1hbiB3cm90ZToNCj4gPiA+
ID4gQEAgLTc2LDYgKzc3LDUyIEBAIFJlcXVpcmVkIHByb3BlcnRpZXM6DQo+ID4gPiA+DQo+ID4g
PiA+ICBSZWNvbW1lbmRlZCBwcm9wZXJ0aWVzOg0KPiA+ID4gPiAgLSBjbG9ja3M6IFNob3VsZCBi
ZSB0aGUgcGhhbmRsZSBvZiBpbnB1dCBwYXJlbnQgY2xvY2sNCj4gPiA+ID4gKwlGb3IgImZzbCxm
bWFuLWNsay1tdXgiIGNsb2NrIHRoZXJlIGFyZSBzZXZlcmFsIG9wdGlvbnMgZm9yIHBhcmVudA0K
PiA+ID4gPiArCWNsb2NrIChjbG9jayBwcm92aWRlciksIHRoZSBwYXJlbnQgaXMgZGV0ZXJtaW5l
ZCBhY2NvcmRpbmcgdG8gdGhlDQo+ID4gPiA+ICsJUmVzZXQgQ29uZmlndXJhdGlvbiBXb3JkIG9m
IHRoZSBzcGVjaWZpYyBkZXZpY2U6DQo+ID4gPiA+ICsJCSogUDIwNDEsIFAzMDQxOg0KPiA+ID4g
PiArCQkJKiAwIC0gZXF1YWwgdG8gcGxhdGZvcm0gUExMIGRpdmlkZWQgYnkgMg0KPiA+ID4gPiAr
CQkJKiAxIC0gZXF1YWwgdG8gUExMMiBkaXZpZGVkIGJ5IDINCj4gPiA+ID4gKwkJKiBQNDA4MCAo
Qm90aCBGTWFucyk6DQo+ID4gPiA+ICsJCQkqIDAgLSBlcXVhbCB0byBwbGF0Zm9ybSBQTEwgZGl2
aWRlZCBieSAyDQo+ID4gPiA+ICsJCQkqIDEgLSBlcXVhbCB0byBQTEwzIGRpdmlkZWQgYnkgMg0K
PiA+ID4gLi4uDQo+ID4gPg0KPiA+ID4NCj4gPiA+IEFnYWluLCB0aGUgY2xvY2sgc3BlY2lmaWVy
IGZvcm1hdCBpcyBkZXRlcm1pbmVkIGJ5IHRoZSBjbG9jaw0KPiA+ID4gcHJvdmlkZXIsIG5vdCB0
aGUgY2xvY2sgY29uc3VtZXIuDQo+ID4gPg0KPiA+DQo+ID4gU2NvdHQsDQo+ID4gVGhlICJjbG9j
a3MiIHByb3BlcnR5IGNvbnRhaW5zIGFsbCBwb3NzaWJsZSBjbG9jayBwcm92aWRlcnMsIHJpZ2h0
Pw0KPiA+IEluIHRoZSB0ZXh0IGFib3ZlIEknbSB0cnlpbmcgdG8gZXhwbGFpbiBob3cgdGhlIEZN
YW4gY2xvY2sgcHJvdmlkZXIgaXMNCj4gZGV0ZXJtaW5lZCBhbmQgd2hhdCBhcmUgdGhlIG9wdGlv
bnMgZm9yIGVhY2ggU29DLg0KPiA+IERvIHlvdSB0aGluayB0aGF0IHdlIHNob3VsZG4ndCBoYXZl
IHRoaXMgZXhwbGFuYXRpb24/IENhbiB5b3UgcGxlYXNlDQo+IGVsYWJvcmF0ZT8NCj4gDQo+IEkn
bSBzYXlpbmcgdGhhdCB0aGUgY2xvY2sgc3BlY2lmaWVycyBtdXN0IGJlIHRoZSBzYW1lIHJlZ2Fy
ZGxlc3Mgb2YgdGhlIG5vZGUNCj4gdGhhdCBpcyBjb25zdW1pbmcgdGhlIGNsb2NrLiAgWW91IGNh
bid0IGRlZmluZSBjZXJ0YWluIHZhbHVlcyBhcyBvbmx5IGJlaW5nICJmb3INCj4gZnNsLGZtYW4t
Y2xrLW11eCIuDQo+IA0KDQpKdXN0IHRvIG1ha2UgdGhpbmdzIGNsZWFyLA0KSW4gImZtMGNsay9m
bTFjbGsiIG5vZGUsICJjbG9ja3MiIGhvbGRzIGEgbGlzdCBvZiBjbG9jayBzcGVjaWZpZXJzLg0K
VGhpcyBsaXN0IHJlZmxlY3RzIGFsbCBvcHRpb25hbCBjbG9jayBwcm92aWRlcnMgZm9yIGEgc3Bl
Y2lmaWMgaGFyZHdhcmUsIHRoaXMgbGlzdCB2YXJpZXMgYmV0d2VlbiBkaWZmZXJlbnQgU29Dcy4N
CkFsbCB0aG9zZSBwb3NzaWJsZSBwcm92aWRlcnMgZGVzY3JpYmVkIGJ5IG90aGVyIG5vZGVzLCBh
cyBjbG9jayBwcm92aWRlcnMuDQpQbGVhc2Ugbm90aWNlIHRoYXQgdGhpcyBiaW5kaW5ncyBkZXNj
cmliZXMgdGhlIHBvc3NpYmxlIHNvdXJjZSBjbG9jayBmb3IgRk1hbiBtdXgsIG5vdCB0aGUgcHJv
dmlkZXJzIHRoZW1zZWx2ZXMuDQoNCllvdSBtZW50aW9uZWQgdGhlIGZvbGxvd2luZzogIllvdSBj
YW4ndCBkZWZpbmUgY2VydGFpbiB2YWx1ZXMgYXMgb25seSBiZWluZyAiZm9yIGZzbCxmbWFuLWNs
ay1tdXgiLiINCkknbSBkZWZpbmluZyB0aG9zZSB2YWx1ZXMgaW4gdGhlIGNsb2NrIHByb3ZpZGVy
IG5vZGVzIGFuZCB1c2luZyB0aG9zZSB2YWx1ZXMgYXMgY2xvY2sgcHJvdmlkZXJzIGZvciBGTWFu
IG11eCwgaXQgY2FuIGJlIHVzZWQgYmUgb3RoZXIgSFcgYmxvY2tzIHRvby4NCiANCklnYWwuDQoN
Cj4gLVNjb3R0DQo+IA0KDQo=

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
  2015-04-12 15:54             ` Igal.Liberman
@ 2015-04-13 20:20                 ` Scott Wood
  -1 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2015-04-13 20:20 UTC (permalink / raw)
  To: Liberman Igal-B31950
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ

On Sun, 2015-04-12 at 10:54 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, April 09, 2015 8:03 PM
> > To: Liberman Igal-B31950
> > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Thu, 2015-04-09 at 02:18 -0500, Liberman Igal-B31950 wrote:
> > >
> > >
> > > Regards,
> > > Igal Liberman.
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Thursday, April 09, 2015 12:12 AM
> > > > To: Liberman Igal-B31950
> > > > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
> > > > Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan
> > > > clock mux
> > > >
> > > > On Wed, 2015-04-08 at 10:43 +0300, Igal.Liberman wrote:
> > > > > @@ -76,6 +77,52 @@ Required properties:
> > > > >
> > > > >  Recommended properties:
> > > > >  - clocks: Should be the phandle of input parent clock
> > > > > +	For "fsl,fman-clk-mux" clock there are several options for parent
> > > > > +	clock (clock provider), the parent is determined according to the
> > > > > +	Reset Configuration Word of the specific device:
> > > > > +		* P2041, P3041:
> > > > > +			* 0 - equal to platform PLL divided by 2
> > > > > +			* 1 - equal to PLL2 divided by 2
> > > > > +		* P4080 (Both FMans):
> > > > > +			* 0 - equal to platform PLL divided by 2
> > > > > +			* 1 - equal to PLL3 divided by 2
> > > > ...
> > > >
> > > >
> > > > Again, the clock specifier format is determined by the clock
> > > > provider, not the clock consumer.
> > > >
> > >
> > > Scott,
> > > The "clocks" property contains all possible clock providers, right?
> > > In the text above I'm trying to explain how the FMan clock provider is
> > determined and what are the options for each SoC.
> > > Do you think that we shouldn't have this explanation? Can you please
> > elaborate?
> > 
> > I'm saying that the clock specifiers must be the same regardless of the node
> > that is consuming the clock.  You can't define certain values as only being "for
> > fsl,fman-clk-mux".
> > 
> 
> Just to make things clear,
> In "fm0clk/fm1clk" node, "clocks" holds a list of clock specifiers.
> This list reflects all optional clock providers for a specific hardware, this list varies between different SoCs.
> All those possible providers described by other nodes, as clock providers.
> Please notice that this bindings describes the possible source clock for FMan mux, not the providers themselves.
> 
> You mentioned the following: "You can't define certain values as only being "for fsl,fman-clk-mux"."
> I'm defining those values in the clock provider nodes and using those values as clock providers for FMan mux, it can be used be other HW blocks too.

My point is that the encoding of the clock specifier is not
fman-specific and thus fman should not appear in the description.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
@ 2015-04-13 20:20                 ` Scott Wood
  0 siblings, 0 replies; 12+ messages in thread
From: Scott Wood @ 2015-04-13 20:20 UTC (permalink / raw)
  To: Liberman Igal-B31950; +Cc: devicetree, linuxppc-dev

On Sun, 2015-04-12 at 10:54 -0500, Liberman Igal-B31950 wrote:
> 
> 
> Regards,
> Igal Liberman.
> 
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Thursday, April 09, 2015 8:03 PM
> > To: Liberman Igal-B31950
> > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux
> > 
> > On Thu, 2015-04-09 at 02:18 -0500, Liberman Igal-B31950 wrote:
> > >
> > >
> > > Regards,
> > > Igal Liberman.
> > >
> > > > -----Original Message-----
> > > > From: Wood Scott-B07421
> > > > Sent: Thursday, April 09, 2015 12:12 AM
> > > > To: Liberman Igal-B31950
> > > > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> > > > Subject: Re: [v2] dt/bindings: qoriq-clock: Add binding for FMan
> > > > clock mux
> > > >
> > > > On Wed, 2015-04-08 at 10:43 +0300, Igal.Liberman wrote:
> > > > > @@ -76,6 +77,52 @@ Required properties:
> > > > >
> > > > >  Recommended properties:
> > > > >  - clocks: Should be the phandle of input parent clock
> > > > > +	For "fsl,fman-clk-mux" clock there are several options for parent
> > > > > +	clock (clock provider), the parent is determined according to the
> > > > > +	Reset Configuration Word of the specific device:
> > > > > +		* P2041, P3041:
> > > > > +			* 0 - equal to platform PLL divided by 2
> > > > > +			* 1 - equal to PLL2 divided by 2
> > > > > +		* P4080 (Both FMans):
> > > > > +			* 0 - equal to platform PLL divided by 2
> > > > > +			* 1 - equal to PLL3 divided by 2
> > > > ...
> > > >
> > > >
> > > > Again, the clock specifier format is determined by the clock
> > > > provider, not the clock consumer.
> > > >
> > >
> > > Scott,
> > > The "clocks" property contains all possible clock providers, right?
> > > In the text above I'm trying to explain how the FMan clock provider is
> > determined and what are the options for each SoC.
> > > Do you think that we shouldn't have this explanation? Can you please
> > elaborate?
> > 
> > I'm saying that the clock specifiers must be the same regardless of the node
> > that is consuming the clock.  You can't define certain values as only being "for
> > fsl,fman-clk-mux".
> > 
> 
> Just to make things clear,
> In "fm0clk/fm1clk" node, "clocks" holds a list of clock specifiers.
> This list reflects all optional clock providers for a specific hardware, this list varies between different SoCs.
> All those possible providers described by other nodes, as clock providers.
> Please notice that this bindings describes the possible source clock for FMan mux, not the providers themselves.
> 
> You mentioned the following: "You can't define certain values as only being "for fsl,fman-clk-mux"."
> I'm defining those values in the clock provider nodes and using those values as clock providers for FMan mux, it can be used be other HW blocks too.

My point is that the encoding of the clock specifier is not
fman-specific and thus fman should not appear in the description.

-Scott

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2015-04-13 20:21 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-08  7:43 [v2] dt/bindings: qoriq-clock: Add binding for FMan clock mux Igal.Liberman
2015-04-08  7:43 ` Igal.Liberman
2015-04-08 21:11 ` Scott Wood
2015-04-08 21:11   ` Scott Wood
2015-04-09  7:18   ` Igal.Liberman
2015-04-09  7:18     ` Igal.Liberman
     [not found]     ` <DM2PR03MB383D9FD2888970950261FB2E6FB0-ufbTtyGzTTRJonC5hhDUuuO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2015-04-09 17:02       ` Scott Wood
2015-04-09 17:02         ` Scott Wood
     [not found]         ` <1428598976.22867.535.camel-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2015-04-12 15:54           ` Igal.Liberman-KZfg59tc24xl57MIdRCFDg
2015-04-12 15:54             ` Igal.Liberman
     [not found]             ` <DM2PR03MB3835E1F5A269C969994FDA0E6F80-ufbTtyGzTTRJonC5hhDUuuO6mTEJWrR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2015-04-13 20:20               ` Scott Wood
2015-04-13 20:20                 ` Scott Wood

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.