* [Qemu-devel] [PATCH] block/iscsi: do not forget to logout from target
@ 2015-04-14 8:37 Peter Lieven
2015-04-14 22:47 ` ronnie sahlberg
0 siblings, 1 reply; 2+ messages in thread
From: Peter Lieven @ 2015-04-14 8:37 UTC (permalink / raw)
To: qemu-devel
Cc: pbonzini, Peter Lieven, ronniesahlberg, qemu-block, qemu-stable
We actually were always impolitely dropping the connection and
not cleanly logging out.
Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block/iscsi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/block/iscsi.c b/block/iscsi.c
index ab20e4d..0b6d3dd 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1503,6 +1503,9 @@ out:
if (ret) {
if (iscsi != NULL) {
+ if (iscsi_is_logged_in(iscsi)) {
+ iscsi_logout_sync(iscsi);
+ }
iscsi_destroy_context(iscsi);
}
memset(iscsilun, 0, sizeof(IscsiLun));
@@ -1516,6 +1519,9 @@ static void iscsi_close(BlockDriverState *bs)
struct iscsi_context *iscsi = iscsilun->iscsi;
iscsi_detach_aio_context(bs);
+ if (iscsi_is_logged_in(iscsi)) {
+ iscsi_logout_sync(iscsi);
+ }
iscsi_destroy_context(iscsi);
g_free(iscsilun->zeroblock);
g_free(iscsilun->allocationmap);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] block/iscsi: do not forget to logout from target
2015-04-14 8:37 [Qemu-devel] [PATCH] block/iscsi: do not forget to logout from target Peter Lieven
@ 2015-04-14 22:47 ` ronnie sahlberg
0 siblings, 0 replies; 2+ messages in thread
From: ronnie sahlberg @ 2015-04-14 22:47 UTC (permalink / raw)
To: Peter Lieven; +Cc: Paolo Bonzini, qemu-devel, qemu-block, qemu-stable
Reviewed-By: Ronnie Sahlberg <ronniesahlberg@gmail.com>
On Tue, Apr 14, 2015 at 1:37 AM, Peter Lieven <pl@kamp.de> wrote:
> We actually were always impolitely dropping the connection and
> not cleanly logging out.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
> block/iscsi.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/block/iscsi.c b/block/iscsi.c
> index ab20e4d..0b6d3dd 100644
> --- a/block/iscsi.c
> +++ b/block/iscsi.c
> @@ -1503,6 +1503,9 @@ out:
>
> if (ret) {
> if (iscsi != NULL) {
> + if (iscsi_is_logged_in(iscsi)) {
> + iscsi_logout_sync(iscsi);
> + }
> iscsi_destroy_context(iscsi);
> }
> memset(iscsilun, 0, sizeof(IscsiLun));
> @@ -1516,6 +1519,9 @@ static void iscsi_close(BlockDriverState *bs)
> struct iscsi_context *iscsi = iscsilun->iscsi;
>
> iscsi_detach_aio_context(bs);
> + if (iscsi_is_logged_in(iscsi)) {
> + iscsi_logout_sync(iscsi);
> + }
> iscsi_destroy_context(iscsi);
> g_free(iscsilun->zeroblock);
> g_free(iscsilun->allocationmap);
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-14 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-14 8:37 [Qemu-devel] [PATCH] block/iscsi: do not forget to logout from target Peter Lieven
2015-04-14 22:47 ` ronnie sahlberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.