All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gpio-backlight: Discover driver during boot time
@ 2015-04-16  0:21 ` Arun Bharadwaj
  0 siblings, 0 replies; 6+ messages in thread
From: Arun Bharadwaj @ 2015-04-16  0:21 UTC (permalink / raw)
  To: linux-fbdev, linux-kernel
  Cc: Jingoo Han, Lee Jones, Jean-Christophe Plagniol-Villard,
	Tomi Valkeinen, Ash Charles

The gpio-backlight driver seems to be missing the
MODULE_DEVICE_TABLE line which is preventing it from
being modprobed during boot time even if the
gpio-backlight device exists.

This seems to be a bug and this patch attempts to
fix that.

Signed-off-by: Arun Bharadwaj <arun@gumstix.com>
Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
 drivers/video/backlight/gpio_backlight.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index 439feb2..5fbbc2e 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = {
 	{ .compatible = "gpio-backlight" },
 	{ /* sentinel */ }
 };
+
+MODULE_DEVICE_TABLE(of, gpio_backlight_of_match);
 #endif
 
 static struct platform_driver gpio_backlight_driver = {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] gpio-backlight: Discover driver during boot time
@ 2015-04-16  0:21 ` Arun Bharadwaj
  0 siblings, 0 replies; 6+ messages in thread
From: Arun Bharadwaj @ 2015-04-16  0:21 UTC (permalink / raw)
  To: linux-fbdev, linux-kernel
  Cc: Jingoo Han, Lee Jones, Jean-Christophe Plagniol-Villard,
	Tomi Valkeinen, Ash Charles

The gpio-backlight driver seems to be missing the
MODULE_DEVICE_TABLE line which is preventing it from
being modprobed during boot time even if the
gpio-backlight device exists.

This seems to be a bug and this patch attempts to
fix that.

Signed-off-by: Arun Bharadwaj <arun@gumstix.com>
Signed-off-by: Ash Charles <ashcharles@gmail.com>
---
 drivers/video/backlight/gpio_backlight.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
index 439feb2..5fbbc2e 100644
--- a/drivers/video/backlight/gpio_backlight.c
+++ b/drivers/video/backlight/gpio_backlight.c
@@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = {
 	{ .compatible = "gpio-backlight" },
 	{ /* sentinel */ }
 };
+
+MODULE_DEVICE_TABLE(of, gpio_backlight_of_match);
 #endif
 
 static struct platform_driver gpio_backlight_driver = {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] gpio-backlight: Discover driver during boot time
  2015-04-16  0:21 ` Arun Bharadwaj
@ 2015-04-29 12:32   ` Lee Jones
  -1 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2015-04-29 12:32 UTC (permalink / raw)
  To: Arun Bharadwaj
  Cc: linux-fbdev, linux-kernel, Jingoo Han,
	Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Ash Charles

Jingoo?

> The gpio-backlight driver seems to be missing the
> MODULE_DEVICE_TABLE line which is preventing it from
> being modprobed during boot time even if the
> gpio-backlight device exists.
> 
> This seems to be a bug and this patch attempts to
> fix that.
> 
> Signed-off-by: Arun Bharadwaj <arun@gumstix.com>
> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> ---
>  drivers/video/backlight/gpio_backlight.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 439feb2..5fbbc2e 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = {
>  	{ .compatible = "gpio-backlight" },
>  	{ /* sentinel */ }
>  };
> +
> +MODULE_DEVICE_TABLE(of, gpio_backlight_of_match);
>  #endif
>  
>  static struct platform_driver gpio_backlight_driver = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gpio-backlight: Discover driver during boot time
@ 2015-04-29 12:32   ` Lee Jones
  0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2015-04-29 12:32 UTC (permalink / raw)
  To: Arun Bharadwaj
  Cc: linux-fbdev, linux-kernel, Jingoo Han,
	Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Ash Charles

Jingoo?

> The gpio-backlight driver seems to be missing the
> MODULE_DEVICE_TABLE line which is preventing it from
> being modprobed during boot time even if the
> gpio-backlight device exists.
> 
> This seems to be a bug and this patch attempts to
> fix that.
> 
> Signed-off-by: Arun Bharadwaj <arun@gumstix.com>
> Signed-off-by: Ash Charles <ashcharles@gmail.com>
> ---
>  drivers/video/backlight/gpio_backlight.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> index 439feb2..5fbbc2e 100644
> --- a/drivers/video/backlight/gpio_backlight.c
> +++ b/drivers/video/backlight/gpio_backlight.c
> @@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = {
>  	{ .compatible = "gpio-backlight" },
>  	{ /* sentinel */ }
>  };
> +
> +MODULE_DEVICE_TABLE(of, gpio_backlight_of_match);
>  #endif
>  
>  static struct platform_driver gpio_backlight_driver = {

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gpio-backlight: Discover driver during boot time
  2015-04-29 12:32   ` Lee Jones
@ 2015-04-29 12:33     ` Lee Jones
  -1 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2015-04-29 12:33 UTC (permalink / raw)
  To: Arun Bharadwaj
  Cc: linux-fbdev, linux-kernel, Jingoo Han,
	Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Ash Charles

> Jingoo?

Never mind.

Applied, thanks.

> > The gpio-backlight driver seems to be missing the
> > MODULE_DEVICE_TABLE line which is preventing it from
> > being modprobed during boot time even if the
> > gpio-backlight device exists.
> > 
> > This seems to be a bug and this patch attempts to
> > fix that.
> > 
> > Signed-off-by: Arun Bharadwaj <arun@gumstix.com>
> > Signed-off-by: Ash Charles <ashcharles@gmail.com>
> > ---
> >  drivers/video/backlight/gpio_backlight.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> > index 439feb2..5fbbc2e 100644
> > --- a/drivers/video/backlight/gpio_backlight.c
> > +++ b/drivers/video/backlight/gpio_backlight.c
> > @@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = {
> >  	{ .compatible = "gpio-backlight" },
> >  	{ /* sentinel */ }
> >  };
> > +
> > +MODULE_DEVICE_TABLE(of, gpio_backlight_of_match);
> >  #endif
> >  
> >  static struct platform_driver gpio_backlight_driver = {
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] gpio-backlight: Discover driver during boot time
@ 2015-04-29 12:33     ` Lee Jones
  0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2015-04-29 12:33 UTC (permalink / raw)
  To: Arun Bharadwaj
  Cc: linux-fbdev, linux-kernel, Jingoo Han,
	Jean-Christophe Plagniol-Villard, Tomi Valkeinen, Ash Charles

> Jingoo?

Never mind.

Applied, thanks.

> > The gpio-backlight driver seems to be missing the
> > MODULE_DEVICE_TABLE line which is preventing it from
> > being modprobed during boot time even if the
> > gpio-backlight device exists.
> > 
> > This seems to be a bug and this patch attempts to
> > fix that.
> > 
> > Signed-off-by: Arun Bharadwaj <arun@gumstix.com>
> > Signed-off-by: Ash Charles <ashcharles@gmail.com>
> > ---
> >  drivers/video/backlight/gpio_backlight.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/video/backlight/gpio_backlight.c b/drivers/video/backlight/gpio_backlight.c
> > index 439feb2..5fbbc2e 100644
> > --- a/drivers/video/backlight/gpio_backlight.c
> > +++ b/drivers/video/backlight/gpio_backlight.c
> > @@ -146,6 +146,8 @@ static struct of_device_id gpio_backlight_of_match[] = {
> >  	{ .compatible = "gpio-backlight" },
> >  	{ /* sentinel */ }
> >  };
> > +
> > +MODULE_DEVICE_TABLE(of, gpio_backlight_of_match);
> >  #endif
> >  
> >  static struct platform_driver gpio_backlight_driver = {
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-04-29 12:33 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-16  0:21 [PATCH] gpio-backlight: Discover driver during boot time Arun Bharadwaj
2015-04-16  0:21 ` Arun Bharadwaj
2015-04-29 12:32 ` Lee Jones
2015-04-29 12:32   ` Lee Jones
2015-04-29 12:33   ` Lee Jones
2015-04-29 12:33     ` Lee Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.