* [PATCH] f2fs: remove duplicated code in the f2fs_lookup()
@ 2015-04-16 8:42 Taehee Yoo
2015-04-16 17:00 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Taehee Yoo @ 2015-04-16 8:42 UTC (permalink / raw)
To: jaegeuk, cm224.lee, linux-f2fs-devel
in the f2fs_lookup(), checks that inode isn't null
but d_splice_alias() has same routine at first line.
so i remove this routine.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
fs/f2fs/namei.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
index e79639a9..f17b4b5 100644
--- a/fs/f2fs/namei.c
+++ b/fs/f2fs/namei.c
@@ -204,8 +204,6 @@ static struct dentry *f2fs_lookup(struct inode *dir, struct dentry *dentry,
f2fs_put_page(page, 0);
inode = f2fs_iget(dir->i_sb, ino);
- if (IS_ERR(inode))
- return ERR_CAST(inode);
}
return d_splice_alias(inode, dentry);
--
1.9.1
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: remove duplicated code in the f2fs_lookup()
2015-04-16 8:42 [PATCH] f2fs: remove duplicated code in the f2fs_lookup() Taehee Yoo
@ 2015-04-16 17:00 ` Jaegeuk Kim
2015-04-16 17:37 ` Taehee Yoo
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2015-04-16 17:00 UTC (permalink / raw)
To: Taehee Yoo; +Cc: linux-f2fs-devel
Hi Taehee,
On Thu, Apr 16, 2015 at 05:42:43PM +0900, Taehee Yoo wrote:
> in the f2fs_lookup(), checks that inode isn't null
> but d_splice_alias() has same routine at first line.
> so i remove this routine.
In the latest f2fs, we cannot merge this patch.
Since some inline_dots codes were added with a valid inode before
d_splice_alias.
Thanks,
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
> fs/f2fs/namei.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
> index e79639a9..f17b4b5 100644
> --- a/fs/f2fs/namei.c
> +++ b/fs/f2fs/namei.c
> @@ -204,8 +204,6 @@ static struct dentry *f2fs_lookup(struct inode *dir, struct dentry *dentry,
> f2fs_put_page(page, 0);
>
> inode = f2fs_iget(dir->i_sb, ino);
> - if (IS_ERR(inode))
> - return ERR_CAST(inode);
> }
>
> return d_splice_alias(inode, dentry);
> --
> 1.9.1
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: remove duplicated code in the f2fs_lookup()
2015-04-16 17:00 ` Jaegeuk Kim
@ 2015-04-16 17:37 ` Taehee Yoo
0 siblings, 0 replies; 3+ messages in thread
From: Taehee Yoo @ 2015-04-16 17:37 UTC (permalink / raw)
To: Jaegeuk Kim; +Cc: linux-f2fs-devel
2015-04-17 2:00 GMT+09:00 Jaegeuk Kim <jaegeuk@kernel.org>:
> Hi Taehee,
>
> On Thu, Apr 16, 2015 at 05:42:43PM +0900, Taehee Yoo wrote:
>> in the f2fs_lookup(), checks that inode isn't null
>> but d_splice_alias() has same routine at first line.
>> so i remove this routine.
>
> In the latest f2fs, we cannot merge this patch.
> Since some inline_dots codes were added with a valid inode before
> d_splice_alias.
>
> Thanks,
>
>>
>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>> ---
>> fs/f2fs/namei.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c
>> index e79639a9..f17b4b5 100644
>> --- a/fs/f2fs/namei.c
>> +++ b/fs/f2fs/namei.c
>> @@ -204,8 +204,6 @@ static struct dentry *f2fs_lookup(struct inode *dir, struct dentry *dentry,
>> f2fs_put_page(page, 0);
>>
>> inode = f2fs_iget(dir->i_sb, ino);
>> - if (IS_ERR(inode))
>> - return ERR_CAST(inode);
>> }
>>
>> return d_splice_alias(inode, dentry);
>> --
>> 1.9.1
apologize about imperfect patch.
Thank you for your review!
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-04-16 17:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-16 8:42 [PATCH] f2fs: remove duplicated code in the f2fs_lookup() Taehee Yoo
2015-04-16 17:00 ` Jaegeuk Kim
2015-04-16 17:37 ` Taehee Yoo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.