* [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
@ 2015-04-18 16:55 ` Heiko Stübner
0 siblings, 0 replies; 22+ messages in thread
From: Heiko Stübner @ 2015-04-18 16:55 UTC (permalink / raw)
To: linux-arm-kernel
Am Donnerstag, 16. April 2015, 16:41:51 schrieb ?rjan Eide:
> Set vm_pgoff to 0 after using it to look up the GEM node, before passing
> it on rockchip_gem_mmap_buf() where the offset must be from the start of
> the buffer.
>
> Passing in the fake offset currently works because the
> dma_mmap_attrs implementation that is used for this device,
> arm_iommu_mmap_attrs, ignores the offset completely.
>
> Signed-off-by: ?rjan Eide <orjan.eide@arm.com>
both patches on a rk3288-veyron-pinky
Tested-by: Heiko Stuebner <heiko@sntech.de>
Through which tree do you want to take these patches? I guess the rockchip-drm
related patch should go through the tree that will take the dma-mapping patch,
so you'll probably need an "Ack" from Mark Yao (Cc'ed).
Heiko
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
> 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
> vm_area_struct *vma) return -EACCES;
> }
>
> + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the
> + * whole buffer from the start.
> + */
> + vma->vm_pgoff = 0;
> +
> obj = container_of(node, struct drm_gem_object, vma_node);
> ret = rockchip_gem_mmap_buf(obj, vma);
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
@ 2015-04-18 16:55 ` Heiko Stübner
0 siblings, 0 replies; 22+ messages in thread
From: Heiko Stübner @ 2015-04-18 16:55 UTC (permalink / raw)
To: linux-rockchip, mark.yao
Cc: dri-devel, Ørjan Eide, linux-kernel, linux-arm-kernel
Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ørjan Eide:
> Set vm_pgoff to 0 after using it to look up the GEM node, before passing
> it on rockchip_gem_mmap_buf() where the offset must be from the start of
> the buffer.
>
> Passing in the fake offset currently works because the
> dma_mmap_attrs implementation that is used for this device,
> arm_iommu_mmap_attrs, ignores the offset completely.
>
> Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
both patches on a rk3288-veyron-pinky
Tested-by: Heiko Stuebner <heiko@sntech.de>
Through which tree do you want to take these patches? I guess the rockchip-drm
related patch should go through the tree that will take the dma-mapping patch,
so you'll probably need an "Ack" from Mark Yao (Cc'ed).
Heiko
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
> 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
> vm_area_struct *vma) return -EACCES;
> }
>
> + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the
> + * whole buffer from the start.
> + */
> + vma->vm_pgoff = 0;
> +
> obj = container_of(node, struct drm_gem_object, vma_node);
> ret = rockchip_gem_mmap_buf(obj, vma);
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
2015-04-18 16:55 ` Heiko Stübner
(?)
@ 2015-04-20 5:34 ` Mark yao
-1 siblings, 0 replies; 22+ messages in thread
From: Mark yao @ 2015-04-20 5:34 UTC (permalink / raw)
To: Heiko Stübner, linux-rockchip
Cc: Ørjan Eide, linux-arm-kernel, linux-kernel, dri-devel, djkurtz
On 2015年04月19日 00:55, Heiko Stübner wrote:
> Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ørjan Eide:
>> Set vm_pgoff to 0 after using it to look up the GEM node, before passing
>> it on rockchip_gem_mmap_buf() where the offset must be from the start of
>> the buffer.
>>
>> Passing in the fake offset currently works because the
>> dma_mmap_attrs implementation that is used for this device,
>> arm_iommu_mmap_attrs, ignores the offset completely.
>>
>> Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
> both patches on a rk3288-veyron-pinky
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Through which tree do you want to take these patches? I guess the rockchip-drm
> related patch should go through the tree that will take the dma-mapping patch,
> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
>
>
> Heiko
>
>> ---
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
>> 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
>> vm_area_struct *vma) return -EACCES;
>> }
>>
>> + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the
>> + * whole buffer from the start.
>> + */
>> + vma->vm_pgoff = 0;
>> +
>> obj = container_of(node, struct drm_gem_object, vma_node);
>> ret = rockchip_gem_mmap_buf(obj, vma);
>
>
>
Thanks for this fix,
Acked-by: Mark Yao <mark.yao@rock-chips.com>
--
Mark
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
@ 2015-04-20 5:34 ` Mark yao
0 siblings, 0 replies; 22+ messages in thread
From: Mark yao @ 2015-04-20 5:34 UTC (permalink / raw)
To: linux-arm-kernel
On 2015?04?19? 00:55, Heiko St?bner wrote:
> Am Donnerstag, 16. April 2015, 16:41:51 schrieb ?rjan Eide:
>> Set vm_pgoff to 0 after using it to look up the GEM node, before passing
>> it on rockchip_gem_mmap_buf() where the offset must be from the start of
>> the buffer.
>>
>> Passing in the fake offset currently works because the
>> dma_mmap_attrs implementation that is used for this device,
>> arm_iommu_mmap_attrs, ignores the offset completely.
>>
>> Signed-off-by: ?rjan Eide <orjan.eide@arm.com>
> both patches on a rk3288-veyron-pinky
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Through which tree do you want to take these patches? I guess the rockchip-drm
> related patch should go through the tree that will take the dma-mapping patch,
> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
>
>
> Heiko
>
>> ---
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
>> 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
>> vm_area_struct *vma) return -EACCES;
>> }
>>
>> + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the
>> + * whole buffer from the start.
>> + */
>> + vma->vm_pgoff = 0;
>> +
>> obj = container_of(node, struct drm_gem_object, vma_node);
>> ret = rockchip_gem_mmap_buf(obj, vma);
>
>
>
Thanks for this fix,
Acked-by: Mark Yao <mark.yao@rock-chips.com>
--
?ark
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
@ 2015-04-20 5:34 ` Mark yao
0 siblings, 0 replies; 22+ messages in thread
From: Mark yao @ 2015-04-20 5:34 UTC (permalink / raw)
To: Heiko Stübner, linux-rockchip
Cc: dri-devel, Ørjan Eide, linux-kernel, linux-arm-kernel
On 2015年04月19日 00:55, Heiko Stübner wrote:
> Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ørjan Eide:
>> Set vm_pgoff to 0 after using it to look up the GEM node, before passing
>> it on rockchip_gem_mmap_buf() where the offset must be from the start of
>> the buffer.
>>
>> Passing in the fake offset currently works because the
>> dma_mmap_attrs implementation that is used for this device,
>> arm_iommu_mmap_attrs, ignores the offset completely.
>>
>> Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
> both patches on a rk3288-veyron-pinky
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Through which tree do you want to take these patches? I guess the rockchip-drm
> related patch should go through the tree that will take the dma-mapping patch,
> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
>
>
> Heiko
>
>> ---
>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
>> 100644
>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>> @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
>> vm_area_struct *vma) return -EACCES;
>> }
>>
>> + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the
>> + * whole buffer from the start.
>> + */
>> + vma->vm_pgoff = 0;
>> +
>> obj = container_of(node, struct drm_gem_object, vma_node);
>> ret = rockchip_gem_mmap_buf(obj, vma);
>
>
>
Thanks for this fix,
Acked-by: Mark Yao <mark.yao@rock-chips.com>
--
Mark
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
2015-04-20 5:34 ` Mark yao
(?)
@ 2015-04-20 5:44 ` Mark yao
-1 siblings, 0 replies; 22+ messages in thread
From: Mark yao @ 2015-04-20 5:44 UTC (permalink / raw)
To: Heiko Stübner, linux-rockchip
Cc: Ørjan Eide, linux-arm-kernel, linux-kernel, dri-devel, djkurtz
On 2015年04月20日 13:34, Mark yao wrote:
> On 2015年04月19日 00:55, Heiko Stübner wrote:
>> Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ørjan Eide:
>>> Set vm_pgoff to 0 after using it to look up the GEM node, before
>>> passing
>>> it on rockchip_gem_mmap_buf() where the offset must be from the
>>> start of
>>> the buffer.
>>>
>>> Passing in the fake offset currently works because the
>>> dma_mmap_attrs implementation that is used for this device,
>>> arm_iommu_mmap_attrs, ignores the offset completely.
>>>
>>> Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
>> both patches on a rk3288-veyron-pinky
>>
>> Tested-by: Heiko Stuebner <heiko@sntech.de>
>>
>> Through which tree do you want to take these patches? I guess the
>> rockchip-drm
>> related patch should go through the tree that will take the
>> dma-mapping patch,
>> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
>>
>>
>> Heiko
>>
>>> ---
>>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
>>> 100644
>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
>>> vm_area_struct *vma) return -EACCES;
>>> }
>>>
>>> + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and
>>> map the
>>> + * whole buffer from the start.
>>> + */
>>> + vma->vm_pgoff = 0;
>>> +
>>> obj = container_of(node, struct drm_gem_object, vma_node);
>>> ret = rockchip_gem_mmap_buf(obj, vma);
>>
>>
>>
> Thanks for this fix,
> Acked-by: Mark Yao <mark.yao@rock-chips.com>
>
I met this problem when work with gem non-iommu path, set vma->vm_pgoff
= 0 solved it. :-)
--
Mark
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
@ 2015-04-20 5:44 ` Mark yao
0 siblings, 0 replies; 22+ messages in thread
From: Mark yao @ 2015-04-20 5:44 UTC (permalink / raw)
To: linux-arm-kernel
On 2015?04?20? 13:34, Mark yao wrote:
> On 2015?04?19? 00:55, Heiko St?bner wrote:
>> Am Donnerstag, 16. April 2015, 16:41:51 schrieb ?rjan Eide:
>>> Set vm_pgoff to 0 after using it to look up the GEM node, before
>>> passing
>>> it on rockchip_gem_mmap_buf() where the offset must be from the
>>> start of
>>> the buffer.
>>>
>>> Passing in the fake offset currently works because the
>>> dma_mmap_attrs implementation that is used for this device,
>>> arm_iommu_mmap_attrs, ignores the offset completely.
>>>
>>> Signed-off-by: ?rjan Eide <orjan.eide@arm.com>
>> both patches on a rk3288-veyron-pinky
>>
>> Tested-by: Heiko Stuebner <heiko@sntech.de>
>>
>> Through which tree do you want to take these patches? I guess the
>> rockchip-drm
>> related patch should go through the tree that will take the
>> dma-mapping patch,
>> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
>>
>>
>> Heiko
>>
>>> ---
>>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
>>> 100644
>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
>>> vm_area_struct *vma) return -EACCES;
>>> }
>>>
>>> + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and
>>> map the
>>> + * whole buffer from the start.
>>> + */
>>> + vma->vm_pgoff = 0;
>>> +
>>> obj = container_of(node, struct drm_gem_object, vma_node);
>>> ret = rockchip_gem_mmap_buf(obj, vma);
>>
>>
>>
> Thanks for this fix,
> Acked-by: Mark Yao <mark.yao@rock-chips.com>
>
I met this problem when work with gem non-iommu path, set vma->vm_pgoff
= 0 solved it. :-)
--
?ark
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
@ 2015-04-20 5:44 ` Mark yao
0 siblings, 0 replies; 22+ messages in thread
From: Mark yao @ 2015-04-20 5:44 UTC (permalink / raw)
To: Heiko Stübner, linux-rockchip
Cc: dri-devel, Ørjan Eide, linux-kernel, linux-arm-kernel
On 2015年04月20日 13:34, Mark yao wrote:
> On 2015年04月19日 00:55, Heiko Stübner wrote:
>> Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ørjan Eide:
>>> Set vm_pgoff to 0 after using it to look up the GEM node, before
>>> passing
>>> it on rockchip_gem_mmap_buf() where the offset must be from the
>>> start of
>>> the buffer.
>>>
>>> Passing in the fake offset currently works because the
>>> dma_mmap_attrs implementation that is used for this device,
>>> arm_iommu_mmap_attrs, ignores the offset completely.
>>>
>>> Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
>> both patches on a rk3288-veyron-pinky
>>
>> Tested-by: Heiko Stuebner <heiko@sntech.de>
>>
>> Through which tree do you want to take these patches? I guess the
>> rockchip-drm
>> related patch should go through the tree that will take the
>> dma-mapping patch,
>> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
>>
>>
>> Heiko
>>
>>> ---
>>> drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
>>> 100644
>>> --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
>>> @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
>>> vm_area_struct *vma) return -EACCES;
>>> }
>>>
>>> + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and
>>> map the
>>> + * whole buffer from the start.
>>> + */
>>> + vma->vm_pgoff = 0;
>>> +
>>> obj = container_of(node, struct drm_gem_object, vma_node);
>>> ret = rockchip_gem_mmap_buf(obj, vma);
>>
>>
>>
> Thanks for this fix,
> Acked-by: Mark Yao <mark.yao@rock-chips.com>
>
I met this problem when work with gem non-iommu path, set vma->vm_pgoff
= 0 solved it. :-)
--
Mark
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
2015-04-18 16:55 ` Heiko Stübner
(?)
@ 2015-07-07 7:02 ` Daniel Kurtz
-1 siblings, 0 replies; 22+ messages in thread
From: Daniel Kurtz @ 2015-07-07 7:02 UTC (permalink / raw)
To: Heiko Stübner, Russell King
Cc: open list:ARM/Rockchip SoC..., 姚智情,
Ørjan Eide, linux-arm-kernel, linux-kernel, dri-devel
On Sun, Apr 19, 2015 at 12:55 AM, Heiko Stübner <heiko@sntech.de> wrote:
>
> Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ørjan Eide:
> > Set vm_pgoff to 0 after using it to look up the GEM node, before passing
> > it on rockchip_gem_mmap_buf() where the offset must be from the start of
> > the buffer.
> >
> > Passing in the fake offset currently works because the
> > dma_mmap_attrs implementation that is used for this device,
> > arm_iommu_mmap_attrs, ignores the offset completely.
> >
> > Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
>
> both patches on a rk3288-veyron-pinky
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Through which tree do you want to take these patches? I guess the rockchip-drm
> related patch should go through the tree that will take the dma-mapping patch,
> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
As far as I can tell, these two patches ([0] & [1]) were never picked up.
Russell, can you pick both of them up in your tree?
[0] https://patchwork.kernel.org/patch/6226591/
[1] https://patchwork.kernel.org/patch/6226581/
-Dan
> Heiko
>
> > ---
> > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
> > 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
> > vm_area_struct *vma) return -EACCES;
> > }
> >
> > + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the
> > + * whole buffer from the start.
> > + */
> > + vma->vm_pgoff = 0;
> > +
> > obj = container_of(node, struct drm_gem_object, vma_node);
> > ret = rockchip_gem_mmap_buf(obj, vma);
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
@ 2015-07-07 7:02 ` Daniel Kurtz
0 siblings, 0 replies; 22+ messages in thread
From: Daniel Kurtz @ 2015-07-07 7:02 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Apr 19, 2015 at 12:55 AM, Heiko St?bner <heiko@sntech.de> wrote:
>
> Am Donnerstag, 16. April 2015, 16:41:51 schrieb ?rjan Eide:
> > Set vm_pgoff to 0 after using it to look up the GEM node, before passing
> > it on rockchip_gem_mmap_buf() where the offset must be from the start of
> > the buffer.
> >
> > Passing in the fake offset currently works because the
> > dma_mmap_attrs implementation that is used for this device,
> > arm_iommu_mmap_attrs, ignores the offset completely.
> >
> > Signed-off-by: ?rjan Eide <orjan.eide@arm.com>
>
> both patches on a rk3288-veyron-pinky
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Through which tree do you want to take these patches? I guess the rockchip-drm
> related patch should go through the tree that will take the dma-mapping patch,
> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
As far as I can tell, these two patches ([0] & [1]) were never picked up.
Russell, can you pick both of them up in your tree?
[0] https://patchwork.kernel.org/patch/6226591/
[1] https://patchwork.kernel.org/patch/6226581/
-Dan
> Heiko
>
> > ---
> > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
> > 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
> > vm_area_struct *vma) return -EACCES;
> > }
> >
> > + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the
> > + * whole buffer from the start.
> > + */
> > + vma->vm_pgoff = 0;
> > +
> > obj = container_of(node, struct drm_gem_object, vma_node);
> > ret = rockchip_gem_mmap_buf(obj, vma);
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] drm: rockchip: Don't pass DRM fake offset to dma-api
@ 2015-07-07 7:02 ` Daniel Kurtz
0 siblings, 0 replies; 22+ messages in thread
From: Daniel Kurtz @ 2015-07-07 7:02 UTC (permalink / raw)
To: Heiko Stübner, Russell King
Cc: linux-kernel, dri-devel, open list:ARM/Rockchip SoC...,
Ørjan Eide, linux-arm-kernel
On Sun, Apr 19, 2015 at 12:55 AM, Heiko Stübner <heiko@sntech.de> wrote:
>
> Am Donnerstag, 16. April 2015, 16:41:51 schrieb Ørjan Eide:
> > Set vm_pgoff to 0 after using it to look up the GEM node, before passing
> > it on rockchip_gem_mmap_buf() where the offset must be from the start of
> > the buffer.
> >
> > Passing in the fake offset currently works because the
> > dma_mmap_attrs implementation that is used for this device,
> > arm_iommu_mmap_attrs, ignores the offset completely.
> >
> > Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
>
> both patches on a rk3288-veyron-pinky
>
> Tested-by: Heiko Stuebner <heiko@sntech.de>
>
> Through which tree do you want to take these patches? I guess the rockchip-drm
> related patch should go through the tree that will take the dma-mapping patch,
> so you'll probably need an "Ack" from Mark Yao (Cc'ed).
As far as I can tell, these two patches ([0] & [1]) were never picked up.
Russell, can you pick both of them up in your tree?
[0] https://patchwork.kernel.org/patch/6226591/
[1] https://patchwork.kernel.org/patch/6226581/
-Dan
> Heiko
>
> > ---
> > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c index 7ca8799e..69f01c3
> > 100644
> > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c
> > @@ -94,6 +94,11 @@ int rockchip_gem_mmap(struct file *filp, struct
> > vm_area_struct *vma) return -EACCES;
> > }
> >
> > + /* Set vm_pgoff (used as a fake buffer offset by DRM) to 0 and map the
> > + * whole buffer from the start.
> > + */
> > + vma->vm_pgoff = 0;
> > +
> > obj = container_of(node, struct drm_gem_object, vma_node);
> > ret = rockchip_gem_mmap_buf(obj, vma);
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 22+ messages in thread