* [PATCH RFT] ASoC: rt5645: Fix mask for setting RT5645_DMIC_2_DP_GPIO12 bit
@ 2015-04-21 4:19 Axel Lin
2015-04-27 19:58 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2015-04-21 4:19 UTC (permalink / raw)
To: Mark Brown; +Cc: Oder Chiou, Bard Liao, alsa-devel, Liam Girdwood
Current code uses wrong mask when setting RT5645_DMIC_2_DP_GPIO12 bit,
fix it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Bard,
I don't have the h/w to test, so please review and test this patch.
Thanks,
Axel
sound/soc/codecs/rt5645.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/rt5645.c b/sound/soc/codecs/rt5645.c
index 69528ae..a249f65 100644
--- a/sound/soc/codecs/rt5645.c
+++ b/sound/soc/codecs/rt5645.c
@@ -2770,7 +2770,7 @@ static int rt5645_i2c_probe(struct i2c_client *i2c,
case RT5645_DMIC_DATA_GPIO12:
regmap_update_bits(rt5645->regmap, RT5645_DMIC_CTRL1,
- RT5645_DMIC_1_DP_MASK, RT5645_DMIC_2_DP_GPIO12);
+ RT5645_DMIC_2_DP_MASK, RT5645_DMIC_2_DP_GPIO12);
regmap_update_bits(rt5645->regmap, RT5645_GPIO_CTRL1,
RT5645_GP12_PIN_MASK,
RT5645_GP12_PIN_DMIC2_SDA);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RFT] ASoC: rt5645: Fix mask for setting RT5645_DMIC_2_DP_GPIO12 bit
2015-04-21 4:19 [PATCH RFT] ASoC: rt5645: Fix mask for setting RT5645_DMIC_2_DP_GPIO12 bit Axel Lin
@ 2015-04-27 19:58 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2015-04-27 19:58 UTC (permalink / raw)
To: Axel Lin; +Cc: Oder Chiou, Bard Liao, alsa-devel, Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 159 bytes --]
On Tue, Apr 21, 2015 at 12:19:49PM +0800, Axel Lin wrote:
> Current code uses wrong mask when setting RT5645_DMIC_2_DP_GPIO12 bit,
> fix it.
Applied, thanks.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-04-27 19:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-21 4:19 [PATCH RFT] ASoC: rt5645: Fix mask for setting RT5645_DMIC_2_DP_GPIO12 bit Axel Lin
2015-04-27 19:58 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.