All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH]  hpfs: Remove unessary cast
@ 2015-04-23  9:28 Firo Yang
  2015-05-02  8:10 ` Mikulas Patocka
  0 siblings, 1 reply; 7+ messages in thread
From: Firo Yang @ 2015-04-23  9:28 UTC (permalink / raw)
  To: mikulas; +Cc: linux-kernel, Firo Yang

Avoid a pointless kmem_cache_alloc() return value cast in
fs/hpfs/super.c::hpfs_alloc_inode()

Signed-off-by: Firo Yang <firogm@gmail.com>
---
 fs/hpfs/super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index 7cd00d3..ccace08 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
 static struct inode *hpfs_alloc_inode(struct super_block *sb)
 {
 	struct hpfs_inode_info *ei;
-	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
 	if (!ei)
 		return NULL;
 	ei->vfs_inode.i_version = 1;
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [PATCH]  hpfs: Remove unessary cast
  2015-04-23  9:28 [PATCH] hpfs: Remove unessary cast Firo Yang
@ 2015-05-02  8:10 ` Mikulas Patocka
  2015-05-02 16:30   ` Linus Torvalds
  0 siblings, 1 reply; 7+ messages in thread
From: Mikulas Patocka @ 2015-05-02  8:10 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Firo Yang

Avoid a pointless kmem_cache_alloc() return value cast in
fs/hpfs/super.c::hpfs_alloc_inode()

Signed-off-by: Firo Yang <firogm@gmail.com>
Acked-by: Mikulas Patocka <mikulas@twibright.com>

---
fs/hpfs/super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
>
diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index 7cd00d3..ccace08 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
static struct inode *hpfs_alloc_inode(struct super_block *sb)
{
 	struct hpfs_inode_info *ei;
-	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
 	if (!ei)
 		return NULL;
 	ei->vfs_inode.i_version = 1;

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* Re: [PATCH] hpfs: Remove unessary cast
  2015-05-02  8:10 ` Mikulas Patocka
@ 2015-05-02 16:30   ` Linus Torvalds
  2015-05-02 17:13     ` Mikulas Patocka
  0 siblings, 1 reply; 7+ messages in thread
From: Linus Torvalds @ 2015-05-02 16:30 UTC (permalink / raw)
  To: Mikulas Patocka; +Cc: Linux Kernel Mailing List, Firo Yang

Mikulas, when forwarding patches from others, you also need to add that

   "From: Firo Yang <firogm@gmail.com>"

at the top (and it can be nice if you also add the date-line).
Otherwise authorship gets lost.

Sign-off lines _normally_ show the whole authorship chain too, but no,
it's not enough to just have the sign-off line there.

                     Linus

On Sat, May 2, 2015 at 1:10 AM, Mikulas Patocka <mikulas@twibright.com> wrote:
> Avoid a pointless kmem_cache_alloc() return value cast in
> fs/hpfs/super.c::hpfs_alloc_inode()
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> Acked-by: Mikulas Patocka <mikulas@twibright.com>
>
>
> ---
> fs/hpfs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
> diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
> index 7cd00d3..ccace08 100644
> --- a/fs/hpfs/super.c
> +++ b/fs/hpfs/super.c
> @@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
> static struct inode *hpfs_alloc_inode(struct super_block *sb)
> {
>         struct hpfs_inode_info *ei;
> -       ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep,
> GFP_NOFS);
> +       ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
>         if (!ei)
>                 return NULL;
>         ei->vfs_inode.i_version = 1;

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] hpfs: Remove unessary cast
  2015-05-02 16:30   ` Linus Torvalds
@ 2015-05-02 17:13     ` Mikulas Patocka
  0 siblings, 0 replies; 7+ messages in thread
From: Mikulas Patocka @ 2015-05-02 17:13 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Linux Kernel Mailing List, Firo Yang



On Sat, 2 May 2015, Linus Torvalds wrote:

> Mikulas, when forwarding patches from others, you also need to add that
>
>   "From: Firo Yang <firogm@gmail.com>"
>
> at the top (and it can be nice if you also add the date-line).
> Otherwise authorship gets lost.
>
> Sign-off lines _normally_ show the whole authorship chain too, but no,
> it's not enough to just have the sign-off line there.
>
>                     Linus

OK, so I sent it the second time, I hope that your script processes it 
better.

Mikulas

^ permalink raw reply	[flat|nested] 7+ messages in thread
* Re: [PATCH] hpfs: Remove unessary cast
  2015-06-28 13:18 Mikulas Patocka
@ 2015-06-29  8:19 ` Sohny Thomas
  0 siblings, 0 replies; 7+ messages in thread
From: Sohny Thomas @ 2015-06-29  8:19 UTC (permalink / raw)
  To: Mikulas Patocka, Linus Torvalds, linux-fsdevel

IMHO I think its better of being cast since you do have another pointer 
inside the struct.

On 28-06-2015 18:48, Mikulas Patocka wrote:
> From: Firo Yang <firogm@gmail.com>
> Date: Thu, 23 Apr 2015 17:28:45 +0800
>
> Avoid a pointless kmem_cache_alloc() return value cast in
> fs/hpfs/super.c::hpfs_alloc_inode()
>
> Signed-off-by: Firo Yang <firogm@gmail.com>
> Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
> ---
>   fs/hpfs/super.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-4.1/fs/hpfs/super.c
> ===================================================================
> --- linux-4.1.orig/fs/hpfs/super.c	2015-06-22 20:17:54.000000000 +0200
> +++ linux-4.1/fs/hpfs/super.c	2015-06-22 21:27:59.000000000 +0200
> @@ -238,7 +238,7 @@ static struct kmem_cache * hpfs_inode_ca
>   static struct inode *hpfs_alloc_inode(struct super_block *sb)
>   {
>   	struct hpfs_inode_info *ei;
> -	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
> +	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
>   	if (!ei)
>   		return NULL;
>   	ei->vfs_inode.i_version = 1;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus



^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] hpfs: Remove unessary cast
@ 2015-06-28 13:18 Mikulas Patocka
  2015-06-29  8:19 ` Sohny Thomas
  0 siblings, 1 reply; 7+ messages in thread
From: Mikulas Patocka @ 2015-06-28 13:18 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, linux-fsdevel

From: Firo Yang <firogm@gmail.com>
Date: Thu, 23 Apr 2015 17:28:45 +0800

Avoid a pointless kmem_cache_alloc() return value cast in
fs/hpfs/super.c::hpfs_alloc_inode()

Signed-off-by: Firo Yang <firogm@gmail.com>
Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
---
 fs/hpfs/super.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-4.1/fs/hpfs/super.c
===================================================================
--- linux-4.1.orig/fs/hpfs/super.c	2015-06-22 20:17:54.000000000 +0200
+++ linux-4.1/fs/hpfs/super.c	2015-06-22 21:27:59.000000000 +0200
@@ -238,7 +238,7 @@ static struct kmem_cache * hpfs_inode_ca
 static struct inode *hpfs_alloc_inode(struct super_block *sb)
 {
 	struct hpfs_inode_info *ei;
-	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
 	if (!ei)
 		return NULL;
 	ei->vfs_inode.i_version = 1;

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [PATCH] hpfs: Remove unessary cast
@ 2015-05-02 17:12 Mikulas Patocka
  0 siblings, 0 replies; 7+ messages in thread
From: Mikulas Patocka @ 2015-05-02 17:12 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: linux-kernel, Firo Yang

From: Firo Yang <firogm@gmail.com>
Date: Thu, 23 Apr 2015 17:28:45 +0800

Avoid a pointless kmem_cache_alloc() return value cast in
fs/hpfs/super.c::hpfs_alloc_inode()

Signed-off-by: Firo Yang <firogm@gmail.com>
Signed-off-by: Mikulas Patocka <mikulas@twibright.com>
---
  fs/hpfs/super.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/hpfs/super.c b/fs/hpfs/super.c
index 7cd00d3..ccace08 100644
--- a/fs/hpfs/super.c
+++ b/fs/hpfs/super.c
@@ -201,7 +201,7 @@ static struct kmem_cache * hpfs_inode_cachep;
  static struct inode *hpfs_alloc_inode(struct super_block *sb)
  {
  	struct hpfs_inode_info *ei;
-	ei = (struct hpfs_inode_info *)kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
+	ei = kmem_cache_alloc(hpfs_inode_cachep, GFP_NOFS);
  	if (!ei)
  		return NULL;
  	ei->vfs_inode.i_version = 1;
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-06-29  9:02 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-23  9:28 [PATCH] hpfs: Remove unessary cast Firo Yang
2015-05-02  8:10 ` Mikulas Patocka
2015-05-02 16:30   ` Linus Torvalds
2015-05-02 17:13     ` Mikulas Patocka
2015-05-02 17:12 Mikulas Patocka
2015-06-28 13:18 Mikulas Patocka
2015-06-29  8:19 ` Sohny Thomas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.