All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name
@ 2015-04-24  3:16 Marek Vasut
  2015-04-24  6:56 ` Stefan Wahren
  0 siblings, 1 reply; 3+ messages in thread
From: Marek Vasut @ 2015-04-24  3:16 UTC (permalink / raw)
  To: linux-arm-kernel

Fix a typo in the TX DMA interrupt name for AUART4.
This patch makes AUART4 operational again.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: stable at vger.kernel.org
---
 arch/arm/boot/dts/imx28.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

NOTE: This bug goes all the way back to at least Linux 3.10
NOTE: I am not the author of the patch, but I am not allowed to disclose
      the name of the original author due to the circumstances.

diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
index 25e25f8..4e073e8 100644
--- a/arch/arm/boot/dts/imx28.dtsi
+++ b/arch/arm/boot/dts/imx28.dtsi
@@ -913,7 +913,7 @@
 					      80 81 68 69
 					      70 71 72 73
 					      74 75 76 77>;
-				interrupt-names = "auart4-rx", "aurat4-tx", "spdif-tx", "empty",
+				interrupt-names = "auart4-rx", "auart4-tx", "spdif-tx", "empty",
 						  "saif0", "saif1", "i2c0", "i2c1",
 						  "auart0-rx", "auart0-tx", "auart1-rx", "auart1-tx",
 						  "auart2-rx", "auart2-tx", "auart3-rx", "auart3-tx";
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name
  2015-04-24  3:16 [PATCH] ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name Marek Vasut
@ 2015-04-24  6:56 ` Stefan Wahren
  2015-04-24 11:30   ` Marek Vasut
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Wahren @ 2015-04-24  6:56 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Marek,

Am 24.04.2015 um 05:16 schrieb Marek Vasut:
> Fix a typo in the TX DMA interrupt name for AUART4.
> This patch makes AUART4 operational again.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: stable at vger.kernel.org
> ---
>  arch/arm/boot/dts/imx28.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> NOTE: This bug goes all the way back to at least Linux 3.10
> NOTE: I am not the author of the patch, but I am not allowed to disclose
>       the name of the original author due to the circumstances.
>
> diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> index 25e25f8..4e073e8 100644
> --- a/arch/arm/boot/dts/imx28.dtsi
> +++ b/arch/arm/boot/dts/imx28.dtsi
> @@ -913,7 +913,7 @@
>  					      80 81 68 69
>  					      70 71 72 73
>  					      74 75 76 77>;
> -				interrupt-names = "auart4-rx", "aurat4-tx", "spdif-tx", "empty",
> +				interrupt-names = "auart4-rx", "auart4-tx", "spdif-tx", "empty",
>  						  "saif0", "saif1", "i2c0", "i2c1",
>  						  "auart0-rx", "auart0-tx", "auart1-rx", "auart1-tx",
>  						  "auart2-rx", "auart2-tx", "auart3-rx", "auart3-tx";

looks good, but shouldn't we patch also the wrong documentation?

Documentation/devicetree/bindings/dma/fsl-mxs-dma.txt

Best regards
Stefan

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name
  2015-04-24  6:56 ` Stefan Wahren
@ 2015-04-24 11:30   ` Marek Vasut
  0 siblings, 0 replies; 3+ messages in thread
From: Marek Vasut @ 2015-04-24 11:30 UTC (permalink / raw)
  To: linux-arm-kernel

On Friday, April 24, 2015 at 08:56:39 AM, Stefan Wahren wrote:
> Hi Marek,
> 
> Am 24.04.2015 um 05:16 schrieb Marek Vasut:
> > Fix a typo in the TX DMA interrupt name for AUART4.
> > This patch makes AUART4 operational again.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Shawn Guo <shawn.guo@linaro.org>
> > Cc: stable at vger.kernel.org
> > ---
> > 
> >  arch/arm/boot/dts/imx28.dtsi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > NOTE: This bug goes all the way back to at least Linux 3.10
> > NOTE: I am not the author of the patch, but I am not allowed to disclose
> > 
> >       the name of the original author due to the circumstances.
> > 
> > diff --git a/arch/arm/boot/dts/imx28.dtsi b/arch/arm/boot/dts/imx28.dtsi
> > index 25e25f8..4e073e8 100644
> > --- a/arch/arm/boot/dts/imx28.dtsi
> > +++ b/arch/arm/boot/dts/imx28.dtsi
> > @@ -913,7 +913,7 @@
> > 
> >  					      80 81 68 69
> >  					      70 71 72 73
> >  					      74 75 76 77>;
> > 
> > -				interrupt-names = "auart4-rx", "aurat4-tx", 
"spdif-tx", "empty",
> > +				interrupt-names = "auart4-rx", "auart4-tx", 
"spdif-tx", "empty",
> > 
> >  						  "saif0", "saif1", "i2c0", 
"i2c1",
> >  						  "auart0-rx", "auart0-tx", 
"auart1-rx", "auart1-tx",
> >  						  "auart2-rx", "auart2-tx", 
"auart3-rx", "auart3-tx";
> 
> looks good, but shouldn't we patch also the wrong documentation?
> 
> Documentation/devicetree/bindings/dma/fsl-mxs-dma.txt

Nice catch, I sent out a fixed V2 patch.

Thank you!

Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-04-24 11:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-24  3:16 [PATCH] ARM: dts: imx28: Fix AUART4 TX-DMA interrupt name Marek Vasut
2015-04-24  6:56 ` Stefan Wahren
2015-04-24 11:30   ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.