[Qemu-devel] [PATCH] mb: cpu: Renumber EXCP_* constants to close gap

[Qemu-devel] [PATCH] mb: cpu: Renumber EXCP_* constants to close gap

[Michael Tokarev]

After removal of EXCP_NMI there's a gap in EXCP_*
numbering. Let's remove it.

Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
Since I applied Peter's series already, without renumbering,
b/c he wanted to make no code changes and that's a good plan,
I send this renumbering as a separate change.  Hopefully this
way it is possible to get Reviewed-by from Edgar for the whole
series including this my change in a separate patch, because
Edgar only gave his R-b for the series with the change :)

 target-microblaze/cpu.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h
index 6522af7..d389597 100644
--- a/target-microblaze/cpu.h
+++ b/target-microblaze/cpu.h
@@ -36,11 +36,11 @@ typedef struct CPUMBState CPUMBState;
 
 #define ELF_MACHINE	EM_MICROBLAZE
 
-#define EXCP_MMU        2
-#define EXCP_IRQ        3
-#define EXCP_BREAK      4
-#define EXCP_HW_BREAK   5
-#define EXCP_HW_EXCP    6
+#define EXCP_MMU        1
+#define EXCP_IRQ        2
+#define EXCP_BREAK      3
+#define EXCP_HW_BREAK   4
+#define EXCP_HW_EXCP    5
 
 /* MicroBlaze-specific interrupt pending bits.  */
 #define CPU_INTERRUPT_NMI       CPU_INTERRUPT_TGT_EXT_3
-- 
2.1.4

Re: [Qemu-devel] [PATCH] mb: cpu: Renumber EXCP_* constants to close gap

[Edgar E. Iglesias]

On Wed, Apr 29, 2015 at 08:40:01AM +0300, Michael Tokarev wrote:
> After removal of EXCP_NMI there's a gap in EXCP_*
> numbering. Let's remove it.


Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>


> 
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> Since I applied Peter's series already, without renumbering,
> b/c he wanted to make no code changes and that's a good plan,
> I send this renumbering as a separate change.  Hopefully this
> way it is possible to get Reviewed-by from Edgar for the whole
> series including this my change in a separate patch, because
> Edgar only gave his R-b for the series with the change :)
> 
>  target-microblaze/cpu.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/target-microblaze/cpu.h b/target-microblaze/cpu.h
> index 6522af7..d389597 100644
> --- a/target-microblaze/cpu.h
> +++ b/target-microblaze/cpu.h
> @@ -36,11 +36,11 @@ typedef struct CPUMBState CPUMBState;
>  
>  #define ELF_MACHINE	EM_MICROBLAZE
>  
> -#define EXCP_MMU        2
> -#define EXCP_IRQ        3
> -#define EXCP_BREAK      4
> -#define EXCP_HW_BREAK   5
> -#define EXCP_HW_EXCP    6
> +#define EXCP_MMU        1
> +#define EXCP_IRQ        2
> +#define EXCP_BREAK      3
> +#define EXCP_HW_BREAK   4
> +#define EXCP_HW_EXCP    5
>  
>  /* MicroBlaze-specific interrupt pending bits.  */
>  #define CPU_INTERRUPT_NMI       CPU_INTERRUPT_TGT_EXT_3
> -- 
> 2.1.4
>