* [PATCH] powerpc/eeh: Delay probing EEH device during hotplug
@ 2015-04-30 23:22 Gavin Shan
2015-04-30 23:50 ` Michael Ellerman
0 siblings, 1 reply; 5+ messages in thread
From: Gavin Shan @ 2015-04-30 23:22 UTC (permalink / raw)
To: linuxppc-dev; +Cc: weiyang, Gavin Shan
Commit 1c509148b ("powerpc/eeh: Do probe on pci_dn") probes EEH
devices in early stage, which is reasonable to pSeries platform.
However, it's wrong for PowerNV platform because the PE# isn't
determined until the resources (IO and MMIO) are assigned to
PE in hotplug case. So we have to delay probing EEH devices
for PowerNV platform until the PE# is assigned.
Fixes: 1c509148b ("powerpc/eeh: Do probe on pci_dn")
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
---
arch/powerpc/kernel/eeh.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c
index b798c86..04b5d94 100644
--- a/arch/powerpc/kernel/eeh.c
+++ b/arch/powerpc/kernel/eeh.c
@@ -1061,6 +1061,9 @@ void eeh_add_device_early(struct pci_dn *pdn)
if (!edev || !eeh_enabled())
return;
+ if (!eeh_has_flag(EEH_PROBE_MODE_DEVTREE))
+ return;
+
/* USB Bus children of PCI devices will not have BUID's */
phb = edev->phb;
if (NULL == phb ||
@@ -1115,6 +1118,9 @@ void eeh_add_device_late(struct pci_dev *dev)
return;
}
+ if (eeh_has_flag(EEH_PROBE_MODE_DEV))
+ eeh_ops->probe(pdn, NULL);
+
/*
* The EEH cache might not be removed correctly because of
* unbalanced kref to the device during unplug time, which
--
2.1.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/eeh: Delay probing EEH device during hotplug
2015-04-30 23:22 [PATCH] powerpc/eeh: Delay probing EEH device during hotplug Gavin Shan
@ 2015-04-30 23:50 ` Michael Ellerman
2015-05-01 1:28 ` Gavin Shan
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2015-04-30 23:50 UTC (permalink / raw)
To: Gavin Shan; +Cc: weiyang, linuxppc-dev
On Fri, 2015-05-01 at 09:22 +1000, Gavin Shan wrote:
> Commit 1c509148b ("powerpc/eeh: Do probe on pci_dn") probes EEH
> devices in early stage, which is reasonable to pSeries platform.
> However, it's wrong for PowerNV platform because the PE# isn't
> determined until the resources (IO and MMIO) are assigned to
> PE in hotplug case. So we have to delay probing EEH devices
> for PowerNV platform until the PE# is assigned.
>
> Fixes: 1c509148b ("powerpc/eeh: Do probe on pci_dn")
I don't have that SHA.
I've have a commit with the same subject which is ff57b454ddb9.
Is that the same thing?
I also have 89a51df5ab1d, which Fixes that commit (ff57..).
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/eeh: Delay probing EEH device during hotplug
2015-04-30 23:50 ` Michael Ellerman
@ 2015-05-01 1:28 ` Gavin Shan
2015-05-01 3:51 ` Michael Ellerman
0 siblings, 1 reply; 5+ messages in thread
From: Gavin Shan @ 2015-05-01 1:28 UTC (permalink / raw)
To: Michael Ellerman; +Cc: weiyang, linuxppc-dev, Gavin Shan
On Fri, May 01, 2015 at 09:50:57AM +1000, Michael Ellerman wrote:
>On Fri, 2015-05-01 at 09:22 +1000, Gavin Shan wrote:
>> Commit 1c509148b ("powerpc/eeh: Do probe on pci_dn") probes EEH
>> devices in early stage, which is reasonable to pSeries platform.
>> However, it's wrong for PowerNV platform because the PE# isn't
>> determined until the resources (IO and MMIO) are assigned to
>> PE in hotplug case. So we have to delay probing EEH devices
>> for PowerNV platform until the PE# is assigned.
>>
>> Fixes: 1c509148b ("powerpc/eeh: Do probe on pci_dn")
>
>I don't have that SHA.
>
>I've have a commit with the same subject which is ff57b454ddb9.
>
>Is that the same thing?
>
Yes, they're same thing.
>I also have 89a51df5ab1d, which Fixes that commit (ff57..).
>
There seems something wrong at local because "git show 1c509148b" leads
me to the patch as well. However, I believe ff57b454ddb9 is the correct
one. I'll send v2 to fix it up.
---
gwshan@gwshan:~/sandbox/linux$ git show 1c509148b
1 commit 1c509148bd6b5199dc1d97e146eda496f9f22a06
2 Author: Gavin Shan <gwshan@linux.vnet.ibm.com>
3 Date: Tue Mar 17 10:49:45 2015 +1100
4
5 powerpc/eeh: Do probe on pci_dn
gwshan@gwshan:~/sandbox/linux$ git show ff57b454ddb9
1 commit ff57b454ddb938d98d48d8df356357000fedc88c
2 Author: Gavin Shan <gwshan@linux.vnet.ibm.com>
3 Date: Tue Mar 17 16:15:06 2015 +1100
4
5 powerpc/eeh: Do probe on pci_dn
Thanks,
Gavin
>cheers
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/eeh: Delay probing EEH device during hotplug
2015-05-01 1:28 ` Gavin Shan
@ 2015-05-01 3:51 ` Michael Ellerman
2015-05-01 4:05 ` Gavin Shan
0 siblings, 1 reply; 5+ messages in thread
From: Michael Ellerman @ 2015-05-01 3:51 UTC (permalink / raw)
To: Gavin Shan; +Cc: weiyang, linuxppc-dev
On Fri, 2015-05-01 at 11:28 +1000, Gavin Shan wrote:
> On Fri, May 01, 2015 at 09:50:57AM +1000, Michael Ellerman wrote:
> >On Fri, 2015-05-01 at 09:22 +1000, Gavin Shan wrote:
> >> Commit 1c509148b ("powerpc/eeh: Do probe on pci_dn") probes EEH
> >> devices in early stage, which is reasonable to pSeries platform.
> >> However, it's wrong for PowerNV platform because the PE# isn't
> >> determined until the resources (IO and MMIO) are assigned to
> >> PE in hotplug case. So we have to delay probing EEH devices
> >> for PowerNV platform until the PE# is assigned.
> >>
> >> Fixes: 1c509148b ("powerpc/eeh: Do probe on pci_dn")
> >
> >I don't have that SHA.
> >
> >I've have a commit with the same subject which is ff57b454ddb9.
> >
> >Is that the same thing?
>
> Yes, they're same thing.
OK.
> There seems something wrong at local because "git show 1c509148b" leads
> me to the patch as well. However, I believe ff57b454ddb9 is the correct
> one. I'll send v2 to fix it up.
You just have it in your tree from when you were developing it I guess?
If you do:
$ git show --format=fuller 1c509148b
It should show you the committer etc.
cheers
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] powerpc/eeh: Delay probing EEH device during hotplug
2015-05-01 3:51 ` Michael Ellerman
@ 2015-05-01 4:05 ` Gavin Shan
0 siblings, 0 replies; 5+ messages in thread
From: Gavin Shan @ 2015-05-01 4:05 UTC (permalink / raw)
To: Michael Ellerman; +Cc: weiyang, linuxppc-dev, Gavin Shan
On Fri, May 01, 2015 at 01:51:37PM +1000, Michael Ellerman wrote:
>On Fri, 2015-05-01 at 11:28 +1000, Gavin Shan wrote:
>> On Fri, May 01, 2015 at 09:50:57AM +1000, Michael Ellerman wrote:
>> >On Fri, 2015-05-01 at 09:22 +1000, Gavin Shan wrote:
>> >> Commit 1c509148b ("powerpc/eeh: Do probe on pci_dn") probes EEH
>> >> devices in early stage, which is reasonable to pSeries platform.
>> >> However, it's wrong for PowerNV platform because the PE# isn't
>> >> determined until the resources (IO and MMIO) are assigned to
>> >> PE in hotplug case. So we have to delay probing EEH devices
>> >> for PowerNV platform until the PE# is assigned.
>> >>
>> >> Fixes: 1c509148b ("powerpc/eeh: Do probe on pci_dn")
>> >
>> >I don't have that SHA.
>> >
>> >I've have a commit with the same subject which is ff57b454ddb9.
>> >
>> >Is that the same thing?
>>
>> Yes, they're same thing.
>
>OK.
>
>> There seems something wrong at local because "git show 1c509148b" leads
>> me to the patch as well. However, I believe ff57b454ddb9 is the correct
>> one. I'll send v2 to fix it up.
>
>You just have it in your tree from when you were developing it I guess?
>
>If you do:
>
> $ git show --format=fuller 1c509148b
>
>It should show you the committer etc.
>
Yeah, it's true. The committer is myself for commit 1c509148b.
Thanks,
Gavin
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-05-01 4:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-04-30 23:22 [PATCH] powerpc/eeh: Delay probing EEH device during hotplug Gavin Shan
2015-04-30 23:50 ` Michael Ellerman
2015-05-01 1:28 ` Gavin Shan
2015-05-01 3:51 ` Michael Ellerman
2015-05-01 4:05 ` Gavin Shan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.