All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>, backports@vger.kernel.org
Subject: Re: [PATCH] backports: mac80211: revert to old stats behaviour for older kernels
Date: Sun, 03 May 2015 21:07:39 +0200	[thread overview]
Message-ID: <1430680059.3276.1.camel@sipsolutions.net> (raw)
In-Reply-To: <1430487994-20598-1-git-send-email-arend@broadcom.com> (sfid-20150501_154642_126166_7597CA83)

On Fri, 2015-05-01 at 15:46 +0200, Arend van Spriel wrote:
> Commit 5a490510ba5f ("mac80211: use per-CPU TX/RX statistics") introduced
> the use of per-cpu statistics, ie. struct netdevice::tstats. This is not
> supported in kernel 3.14 and older.
> 
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
> ---
> I am not entirely sure whether 3.14 is the correct version to check for. The
> functionality seems introduced there but there were some subsequent patches
> on the per-cpu netdev stats functionality.

I don't really like just reverting to the old behaviour - that'll make
this very hard to port.

What part of this isn't supported? Is there no pointer whatsoever that
we can use? We still implement the ndo_getstats64 [or whatever it's
called] ourselves anyway, so we don't really use any API here apart from
 * netdev_alloc_pcpu_stats, which is trivially backported
 * dev->tstats, which is just a single pointer and we could use anything
else,
   even perhaps in sdata

johannes


  reply	other threads:[~2015-05-03 19:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 13:46 [PATCH] backports: mac80211: revert to old stats behaviour for older kernels Arend van Spriel
2015-05-03 19:07 ` Johannes Berg [this message]
2015-05-03 19:49   ` Arend van Spriel
2015-05-04  7:43     ` Johannes Berg
2015-05-04  8:05       ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430680059.3276.1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend@broadcom.com \
    --cc=backports@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.