All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend@broadcom.com>
Cc: "Luis R. Rodriguez" <mcgrof@kernel.org>, backports@vger.kernel.org
Subject: Re: [PATCH] backports: mac80211: revert to old stats behaviour for older kernels
Date: Mon, 04 May 2015 09:43:14 +0200	[thread overview]
Message-ID: <1430725394.2013.5.camel@sipsolutions.net> (raw)
In-Reply-To: <55467BCF.8040705@broadcom.com>

On Sun, 2015-05-03 at 21:49 +0200, Arend van Spriel wrote:

> I don't either, but I had a bunch of test systems that I wanted to get 
> going.

While on vacation? :)

> > What part of this isn't supported? Is there no pointer whatsoever that
> > we can use? We still implement the ndo_getstats64 [or whatever it's
> > called] ourselves anyway, so we don't really use any API here apart from
> >   * netdev_alloc_pcpu_stats, which is trivially backported
> >   * dev->tstats, which is just a single pointer and we could use anything
> > else,
> >     even perhaps in sdata
> 
> I have to learn about the per-cpu operations someday so why not now 
> while spending two weeks vacation ;-)

Heh. Go enjoy your vacation, I can handle this :)

I think you arrived at kernel 3.14 due to 8f84985fec10d. However, I
think we can just do the following

 * backport "struct pcpu_sw_netstats" (needed on < 3.14)
 * backport "netdev_alloc_pcpu_stats" (needed on < 3.15)
 * make an spatch replacing dev->tstats with ((struct pcpu_sw_netstats *)dev->ml_priv)
   (since ml_priv has existed for a long time, and they're in a union)

johannes


  reply	other threads:[~2015-05-04  7:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-01 13:46 [PATCH] backports: mac80211: revert to old stats behaviour for older kernels Arend van Spriel
2015-05-03 19:07 ` Johannes Berg
2015-05-03 19:49   ` Arend van Spriel
2015-05-04  7:43     ` Johannes Berg [this message]
2015-05-04  8:05       ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430725394.2013.5.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend@broadcom.com \
    --cc=backports@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.