* [PATCH] drm/amdkfd: allow unregister process with queues
@ 2015-05-05 8:39 Oded Gabbay
2015-05-05 16:28 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Oded Gabbay @ 2015-05-05 8:39 UTC (permalink / raw)
To: dri-devel
Sometimes we might unregister process that have queues, because we couldn't
preempt the queues. Until now we blocked it with BUG_ON but instead just
print it as debug.
Reviewed-by: Ben Goz <ben.goz@amd.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index 69af73f..7b1d510 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -430,9 +430,10 @@ static int unregister_process_nocpsch(struct device_queue_manager *dqm,
BUG_ON(!dqm || !qpd);
- BUG_ON(!list_empty(&qpd->queues_list));
+ pr_debug("In func %s\n", __func__);
- pr_debug("kfd: In func %s\n", __func__);
+ pr_debug("qpd->queues_list is %s\n",
+ list_empty(&qpd->queues_list) ? "empty" : "not empty");
retval = 0;
mutex_lock(&dqm->lock);
--
1.9.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdkfd: allow unregister process with queues
2015-05-05 8:39 [PATCH] drm/amdkfd: allow unregister process with queues Oded Gabbay
@ 2015-05-05 16:28 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2015-05-05 16:28 UTC (permalink / raw)
To: Oded Gabbay; +Cc: Maling list - DRI developers
On Tue, May 5, 2015 at 4:39 AM, Oded Gabbay <oded.gabbay@gmail.com> wrote:
> Sometimes we might unregister process that have queues, because we couldn't
> preempt the queues. Until now we blocked it with BUG_ON but instead just
> print it as debug.
>
> Reviewed-by: Ben Goz <ben.goz@amd.com>
> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index 69af73f..7b1d510 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -430,9 +430,10 @@ static int unregister_process_nocpsch(struct device_queue_manager *dqm,
>
> BUG_ON(!dqm || !qpd);
>
> - BUG_ON(!list_empty(&qpd->queues_list));
> + pr_debug("In func %s\n", __func__);
>
> - pr_debug("kfd: In func %s\n", __func__);
> + pr_debug("qpd->queues_list is %s\n",
> + list_empty(&qpd->queues_list) ? "empty" : "not empty");
>
> retval = 0;
> mutex_lock(&dqm->lock);
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-05 16:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-05 8:39 [PATCH] drm/amdkfd: allow unregister process with queues Oded Gabbay
2015-05-05 16:28 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.