All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code.
@ 2015-05-05 15:58 Taehee Yoo
  2015-05-08 13:01 ` Kalle Valo
  0 siblings, 1 reply; 6+ messages in thread
From: Taehee Yoo @ 2015-05-05 15:58 UTC (permalink / raw)
  To: Larry.Finger, ap420073; +Cc: linux-wireless

1. Remove setting REG_BCN_MAX_ERR code in _rtl92cu_set_media_status().
Initialization routine set REG_BCN_MAX_ERR to 0xFF.
also _rtl92cu_set_media_status set REG_BCN_MAX_ERR to same value.
so i remove this code.

2. Remove rtl92c_init_beacon_max_error's parameter.
because parameter "infra_mode" is not used.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
 drivers/net/wireless/rtlwifi/rtl8192cu/hw.c  | 3 +--
 drivers/net/wireless/rtlwifi/rtl8192cu/mac.c | 2 +-
 drivers/net/wireless/rtlwifi/rtl8192cu/mac.h | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
index d310d55..1898596 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -889,7 +889,7 @@ static int _rtl92cu_init_mac(struct ieee80211_hw *hw)
 	rtl92c_set_min_space(hw, IS_92C_SERIAL(rtlhal->version));
 	rtl92c_init_beacon_parameters(hw, rtlhal->version);
 	rtl92c_init_ampdu_aggregation(hw);
-	rtl92c_init_beacon_max_error(hw, true);
+	rtl92c_init_beacon_max_error(hw);
 	return err;
 }
 
@@ -1323,7 +1323,6 @@ static int _rtl92cu_set_media_status(struct ieee80211_hw *hw,
 	enum led_ctl_mode ledaction = LED_CTL_NO_LINK;
 
 	bt_msr &= 0xfc;
-	rtl_write_byte(rtlpriv, REG_BCN_MAX_ERR, 0xFF);
 	if (type == NL80211_IFTYPE_UNSPECIFIED || type ==
 	    NL80211_IFTYPE_STATION) {
 		_rtl92cu_stop_tx_beacon(hw);
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c b/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c
index adb8107..f3db6bc 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/mac.c
@@ -613,7 +613,7 @@ void rtl92c_init_ampdu_aggregation(struct ieee80211_hw *hw)
 	rtl_write_word(rtlpriv, 0x4CA, 0x0708);
 }
 
-void rtl92c_init_beacon_max_error(struct ieee80211_hw *hw, bool infra_mode)
+void rtl92c_init_beacon_max_error(struct ieee80211_hw *hw)
 {
 	struct rtl_priv *rtlpriv = rtl_priv(hw);
 
diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/mac.h b/drivers/net/wireless/rtlwifi/rtl8192cu/mac.h
index bf53652..58548e8 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/mac.h
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/mac.h
@@ -66,7 +66,7 @@ void rtl92c_init_edca_param(struct ieee80211_hw *hw,
 
 void rtl92c_init_edca(struct ieee80211_hw *hw);
 void rtl92c_init_ampdu_aggregation(struct ieee80211_hw *hw);
-void rtl92c_init_beacon_max_error(struct ieee80211_hw *hw, bool infra_mode);
+void rtl92c_init_beacon_max_error(struct ieee80211_hw *hw);
 void rtl92c_init_rdg_setting(struct ieee80211_hw *hw);
 void rtl92c_init_retry_function(struct ieee80211_hw *hw);
 
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code.
  2015-05-05 15:58 [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code Taehee Yoo
@ 2015-05-08 13:01 ` Kalle Valo
  2015-05-09  9:11   ` Taehee Yoo
  0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2015-05-08 13:01 UTC (permalink / raw)
  To: Taehee Yoo; +Cc: Larry.Finger, linux-wireless

Taehee Yoo <ap420073@gmail.com> writes:

> 1. Remove setting REG_BCN_MAX_ERR code in _rtl92cu_set_media_status().
> Initialization routine set REG_BCN_MAX_ERR to 0xFF.
> also _rtl92cu_set_media_status set REG_BCN_MAX_ERR to same value.
> so i remove this code.
>
> 2. Remove rtl92c_init_beacon_max_error's parameter.
> because parameter "infra_mode" is not used.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>

Please split the patches into two. Having a numbered list of changes in
the commit log is a strong indication that the patch should be split
into smaller patches.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code.
  2015-05-08 13:01 ` Kalle Valo
@ 2015-05-09  9:11   ` Taehee Yoo
  2015-05-09 12:02     ` Kalle Valo
  0 siblings, 1 reply; 6+ messages in thread
From: Taehee Yoo @ 2015-05-09  9:11 UTC (permalink / raw)
  To: Kalle Valo; +Cc: Larry Finger, linux-wireless

2015-05-08 22:01 GMT+09:00 Kalle Valo <kvalo@codeaurora.org>:
> Taehee Yoo <ap420073@gmail.com> writes:
>
>> 1. Remove setting REG_BCN_MAX_ERR code in _rtl92cu_set_media_status().
>> Initialization routine set REG_BCN_MAX_ERR to 0xFF.
>> also _rtl92cu_set_media_status set REG_BCN_MAX_ERR to same value.
>> so i remove this code.
>>
>> 2. Remove rtl92c_init_beacon_max_error's parameter.
>> because parameter "infra_mode" is not used.
>>
>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>
> Please split the patches into two. Having a numbered list of changes in
> the commit log is a strong indication that the patch should be split
> into smaller patches.
>
> --
> Kalle Valo

Thank you for your review!
I'll resend two patchs.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code.
  2015-05-09  9:11   ` Taehee Yoo
@ 2015-05-09 12:02     ` Kalle Valo
  2015-05-09 18:12       ` Taehee Yoo
  0 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2015-05-09 12:02 UTC (permalink / raw)
  To: Taehee Yoo; +Cc: Larry Finger, linux-wireless

Taehee Yoo <ap420073@gmail.com> writes:

> 2015-05-08 22:01 GMT+09:00 Kalle Valo <kvalo@codeaurora.org>:
>> Taehee Yoo <ap420073@gmail.com> writes:
>>
>>> 1. Remove setting REG_BCN_MAX_ERR code in _rtl92cu_set_media_status().
>>> Initialization routine set REG_BCN_MAX_ERR to 0xFF.
>>> also _rtl92cu_set_media_status set REG_BCN_MAX_ERR to same value.
>>> so i remove this code.
>>>
>>> 2. Remove rtl92c_init_beacon_max_error's parameter.
>>> because parameter "infra_mode" is not used.
>>>
>>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>>
>> Please split the patches into two. Having a numbered list of changes in
>> the commit log is a strong indication that the patch should be split
>> into smaller patches.
>>
>> --
>> Kalle Valo
>
> Thank you for your review!
> I'll resend two patchs.

Thanks. But when you send new versions please mark them as v2, v3 and so
on as that makes it easy for me to see what is the latest version.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code.
  2015-05-09 12:02     ` Kalle Valo
@ 2015-05-09 18:12       ` Taehee Yoo
  2015-05-11  6:39         ` Kalle Valo
  0 siblings, 1 reply; 6+ messages in thread
From: Taehee Yoo @ 2015-05-09 18:12 UTC (permalink / raw)
  To: Kalle Valo; +Cc: Larry Finger, linux-wireless

2015-05-09 21:02 GMT+09:00 Kalle Valo <kvalo@codeaurora.org>:
> Taehee Yoo <ap420073@gmail.com> writes:
>
>> 2015-05-08 22:01 GMT+09:00 Kalle Valo <kvalo@codeaurora.org>:
>>> Taehee Yoo <ap420073@gmail.com> writes:
>>>
>>>> 1. Remove setting REG_BCN_MAX_ERR code in _rtl92cu_set_media_status().
>>>> Initialization routine set REG_BCN_MAX_ERR to 0xFF.
>>>> also _rtl92cu_set_media_status set REG_BCN_MAX_ERR to same value.
>>>> so i remove this code.
>>>>
>>>> 2. Remove rtl92c_init_beacon_max_error's parameter.
>>>> because parameter "infra_mode" is not used.
>>>>
>>>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>>>
>>> Please split the patches into two. Having a numbered list of changes in
>>> the commit log is a strong indication that the patch should be split
>>> into smaller patches.
>>>
>>> --
>>> Kalle Valo
>>
>> Thank you for your review!
>> I'll resend two patchs.
>
> Thanks. But when you send new versions please mark them as v2, v3 and so
> on as that makes it easy for me to see what is the latest version.
>
> --
> Kalle Valo


I already sent two patchs as "rtlwifi: rtl8192cu: Remove setting
REG_BCN_MAX_ERR code in _rtl92cu_set_media_status()." and "rtlwifi:
rtl8192cu: Remove rtl92c_init_beacon_max_error's parameter"

is it right? or would I resend as V2?

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code.
  2015-05-09 18:12       ` Taehee Yoo
@ 2015-05-11  6:39         ` Kalle Valo
  0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2015-05-11  6:39 UTC (permalink / raw)
  To: Taehee Yoo; +Cc: Larry Finger, linux-wireless

Taehee Yoo <ap420073@gmail.com> writes:

>>> Thank you for your review!
>>> I'll resend two patchs.
>>
>> Thanks. But when you send new versions please mark them as v2, v3 and so
>> on as that makes it easy for me to see what is the latest version.
>
> I already sent two patchs as "rtlwifi: rtl8192cu: Remove setting
> REG_BCN_MAX_ERR code in _rtl92cu_set_media_status()." and "rtlwifi:
> rtl8192cu: Remove rtl92c_init_beacon_max_error's parameter"
>
> is it right? or would I resend as V2?

No need to resend this time, but in the future please always increase
the version when changing patches.

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-05-11  6:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-05 15:58 [PATCH] rtlwifi: rtl8192cu: Modify REG_BCN_MAX_ERR related code Taehee Yoo
2015-05-08 13:01 ` Kalle Valo
2015-05-09  9:11   ` Taehee Yoo
2015-05-09 12:02     ` Kalle Valo
2015-05-09 18:12       ` Taehee Yoo
2015-05-11  6:39         ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.