* [PATCH] powerpc/corenet: enable eSDHC
@ 2015-05-06 6:29 Yangbo Lu
2015-05-30 0:03 ` Scott Wood
0 siblings, 1 reply; 14+ messages in thread
From: Yangbo Lu @ 2015-05-06 6:29 UTC (permalink / raw)
To: linuxppc-dev, linux-kernel, scottwood; +Cc: Yangbo Lu
Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com>
---
arch/powerpc/configs/corenet32_smp_defconfig | 2 ++
arch/powerpc/configs/corenet64_smp_defconfig | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/configs/corenet32_smp_defconfig
index ca7957b..17fb2e0 100644
--- a/arch/powerpc/configs/corenet32_smp_defconfig
+++ b/arch/powerpc/configs/corenet32_smp_defconfig
@@ -130,6 +130,8 @@ CONFIG_USB_OHCI_HCD_PPC_OF_LE=y
CONFIG_USB_STORAGE=y
CONFIG_MMC=y
CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_PLTFM=y
+CONFIG_MMC_SDHCI_OF_ESDHC=y
CONFIG_EDAC=y
CONFIG_EDAC_MM_EDAC=y
CONFIG_EDAC_MPC85XX=y
diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig
index 04737aa..4605a55 100644
--- a/arch/powerpc/configs/corenet64_smp_defconfig
+++ b/arch/powerpc/configs/corenet64_smp_defconfig
@@ -112,6 +112,8 @@ CONFIG_USB_EHCI_FSL=y
CONFIG_USB_STORAGE=y
CONFIG_MMC=y
CONFIG_MMC_SDHCI=y
+CONFIG_MMC_SDHCI_PLTFM=y
+CONFIG_MMC_SDHCI_OF_ESDHC=y
CONFIG_EDAC=y
CONFIG_EDAC_MM_EDAC=y
CONFIG_RTC_CLASS=y
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: powerpc/corenet: enable eSDHC
2015-05-06 6:29 [PATCH] powerpc/corenet: enable eSDHC Yangbo Lu
@ 2015-05-30 0:03 ` Scott Wood
0 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2015-05-30 0:03 UTC (permalink / raw)
To: Yangbo Lu; +Cc: linux-mmc, linuxppc-dev
On Wed, May 06, 2015 at 02:29:08PM +0800, Yangbo Lu wrote:
> Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com>
> ---
> arch/powerpc/configs/corenet32_smp_defconfig | 2 ++
> arch/powerpc/configs/corenet64_smp_defconfig | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/configs/corenet32_smp_defconfig
> index ca7957b..17fb2e0 100644
> --- a/arch/powerpc/configs/corenet32_smp_defconfig
> +++ b/arch/powerpc/configs/corenet32_smp_defconfig
> @@ -130,6 +130,8 @@ CONFIG_USB_OHCI_HCD_PPC_OF_LE=y
> CONFIG_USB_STORAGE=y
> CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_PLTFM=y
> +CONFIG_MMC_SDHCI_OF_ESDHC=y
> CONFIG_EDAC=y
> CONFIG_EDAC_MM_EDAC=y
> CONFIG_EDAC_MPC85XX=y
> diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig
> index 04737aa..4605a55 100644
> --- a/arch/powerpc/configs/corenet64_smp_defconfig
> +++ b/arch/powerpc/configs/corenet64_smp_defconfig
> @@ -112,6 +112,8 @@ CONFIG_USB_EHCI_FSL=y
> CONFIG_USB_STORAGE=y
> CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_PLTFM=y
> +CONFIG_MMC_SDHCI_OF_ESDHC=y
> CONFIG_EDAC=y
> CONFIG_EDAC_MM_EDAC=y
> CONFIG_RTC_CLASS=y
With this on t4240rdb I'm continually spammed with:
sdhci-esdhc ffe114000.sdhc: no support for card's volts
mmc0: error -22 whilst initialising SD card
sdhci-esdhc ffe114000.sdhc: no support for card's volts
mmc0: error -22 whilst initialising SD card
Releveant boot messages include:
sdhci: Secure Digital Host Controller Interface driver
sdhci: Copyright(c) Pierre Ossman
sdhci-pltfm: SDHCI platform and OF driver helper
sdhci-esdhc ffe114000.sdhc: No vmmc regulator found
sdhci-esdhc ffe114000.sdhc: No vqmmc regulator found
mmc0: SDHCI controller on ffe114000.sdhc [ffe114000.sdhc] using ADMA
...
mmc0: error -22 whilst initialising SD card
...
sdhci-esdhc ffe114000.sdhc: no support for card's volts
mmc0: error -22 whilst initialising SD card
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: powerpc/corenet: enable eSDHC
@ 2015-05-30 0:03 ` Scott Wood
0 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2015-05-30 0:03 UTC (permalink / raw)
To: Yangbo Lu; +Cc: linuxppc-dev, linux-mmc
On Wed, May 06, 2015 at 02:29:08PM +0800, Yangbo Lu wrote:
> Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com>
> ---
> arch/powerpc/configs/corenet32_smp_defconfig | 2 ++
> arch/powerpc/configs/corenet64_smp_defconfig | 2 ++
> 2 files changed, 4 insertions(+)
>
> diff --git a/arch/powerpc/configs/corenet32_smp_defconfig b/arch/powerpc/configs/corenet32_smp_defconfig
> index ca7957b..17fb2e0 100644
> --- a/arch/powerpc/configs/corenet32_smp_defconfig
> +++ b/arch/powerpc/configs/corenet32_smp_defconfig
> @@ -130,6 +130,8 @@ CONFIG_USB_OHCI_HCD_PPC_OF_LE=y
> CONFIG_USB_STORAGE=y
> CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_PLTFM=y
> +CONFIG_MMC_SDHCI_OF_ESDHC=y
> CONFIG_EDAC=y
> CONFIG_EDAC_MM_EDAC=y
> CONFIG_EDAC_MPC85XX=y
> diff --git a/arch/powerpc/configs/corenet64_smp_defconfig b/arch/powerpc/configs/corenet64_smp_defconfig
> index 04737aa..4605a55 100644
> --- a/arch/powerpc/configs/corenet64_smp_defconfig
> +++ b/arch/powerpc/configs/corenet64_smp_defconfig
> @@ -112,6 +112,8 @@ CONFIG_USB_EHCI_FSL=y
> CONFIG_USB_STORAGE=y
> CONFIG_MMC=y
> CONFIG_MMC_SDHCI=y
> +CONFIG_MMC_SDHCI_PLTFM=y
> +CONFIG_MMC_SDHCI_OF_ESDHC=y
> CONFIG_EDAC=y
> CONFIG_EDAC_MM_EDAC=y
> CONFIG_RTC_CLASS=y
With this on t4240rdb I'm continually spammed with:
sdhci-esdhc ffe114000.sdhc: no support for card's volts
mmc0: error -22 whilst initialising SD card
sdhci-esdhc ffe114000.sdhc: no support for card's volts
mmc0: error -22 whilst initialising SD card
Releveant boot messages include:
sdhci: Secure Digital Host Controller Interface driver
sdhci: Copyright(c) Pierre Ossman
sdhci-pltfm: SDHCI platform and OF driver helper
sdhci-esdhc ffe114000.sdhc: No vmmc regulator found
sdhci-esdhc ffe114000.sdhc: No vqmmc regulator found
mmc0: SDHCI controller on ffe114000.sdhc [ffe114000.sdhc] using ADMA
...
mmc0: error -22 whilst initialising SD card
...
sdhci-esdhc ffe114000.sdhc: no support for card's volts
mmc0: error -22 whilst initialising SD card
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: powerpc/corenet: enable eSDHC
2015-05-30 0:03 ` Scott Wood
@ 2015-06-08 10:12 ` Lu Y.B.
-1 siblings, 0 replies; 14+ messages in thread
From: Lu Y.B. @ 2015-06-08 10:12 UTC (permalink / raw)
To: Scott Wood; +Cc: linux-mmc, linuxppc-dev
Thanks a lot, Scott.
And now a patch was merged on git://git.linaro.org/people/ulf.hansson/mmc.git next branch to fix this issue.
It should be no problem.
From 5fd26c7ecb32082745b0bd33c8e35badd1cb5a91 Mon Sep 17 00:00:00 2001
From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Fri, 5 Jun 2015 11:40:08 +0200
Subject: [PATCH] mmc: sdhci: Restore behavior while creating OCR mask
Commit 3a48edc4bd68 ("mmc: sdhci: Use mmc core regulator infrastucture")
changed the behavior for how to assign the ocr_avail mask for the mmc
host. More precisely it started to mask the bits instead of assigning
them.
Restore the behavior, but also make it clear that an OCR mask created
from an external regulator overrides the other ones. The OCR mask is
determined by one of the following with this priority:
1. Supported ranges of external regulator if one supplies VDD
2. Host OCR mask if set by the driver (based on DT properties)
3. The capabilities reported by the controller itself
Fixes: 3a48edc4bd68 ("mmc: sdhci: Use mmc core regulator infrastucture")
Cc: Tim Kryger <tim.kryger@gmail.com>
Reported-by: Yangbo Lu <yangbo.lu@freescale.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Tim Kryger <tim.kryger@gmail.com>
---
drivers/mmc/host/sdhci.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1b4861d..706bb60 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -3256,13 +3256,14 @@ int sdhci_add_host(struct sdhci_host *host)
SDHCI_MAX_CURRENT_MULTIPLIER;
}
- /* If OCR set by external regulators, use it instead */
+ /* If OCR set by host, use it instead. */
+ if (host->ocr_mask)
+ ocr_avail = host->ocr_mask;
+
+ /* If OCR set by external regulators, give it highest prio. */
if (mmc->ocr_avail)
ocr_avail = mmc->ocr_avail;
- if (host->ocr_mask)
- ocr_avail &= host->ocr_mask;
-
mmc->ocr_avail = ocr_avail;
mmc->ocr_avail_sdio = ocr_avail;
if (host->ocr_avail_sdio)
--
2.1.0.27.g96db324
Best regards,
Yangbo Lu
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, May 30, 2015 8:04 AM
> To: Lu Yangbo-B47093
> Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org
> Subject: Re: powerpc/corenet: enable eSDHC
>
> On Wed, May 06, 2015 at 02:29:08PM +0800, Yangbo Lu wrote:
> > Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com>
> > ---
> > arch/powerpc/configs/corenet32_smp_defconfig | 2 ++
> > arch/powerpc/configs/corenet64_smp_defconfig | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/arch/powerpc/configs/corenet32_smp_defconfig
> > b/arch/powerpc/configs/corenet32_smp_defconfig
> > index ca7957b..17fb2e0 100644
> > --- a/arch/powerpc/configs/corenet32_smp_defconfig
> > +++ b/arch/powerpc/configs/corenet32_smp_defconfig
> > @@ -130,6 +130,8 @@ CONFIG_USB_OHCI_HCD_PPC_OF_LE=y
> > CONFIG_USB_STORAGE=y CONFIG_MMC=y CONFIG_MMC_SDHCI=y
> > +CONFIG_MMC_SDHCI_PLTFM=y
> > +CONFIG_MMC_SDHCI_OF_ESDHC=y
> > CONFIG_EDAC=y
> > CONFIG_EDAC_MM_EDAC=y
> > CONFIG_EDAC_MPC85XX=y
> > diff --git a/arch/powerpc/configs/corenet64_smp_defconfig
> > b/arch/powerpc/configs/corenet64_smp_defconfig
> > index 04737aa..4605a55 100644
> > --- a/arch/powerpc/configs/corenet64_smp_defconfig
> > +++ b/arch/powerpc/configs/corenet64_smp_defconfig
> > @@ -112,6 +112,8 @@ CONFIG_USB_EHCI_FSL=y CONFIG_USB_STORAGE=y
> > CONFIG_MMC=y CONFIG_MMC_SDHCI=y
> > +CONFIG_MMC_SDHCI_PLTFM=y
> > +CONFIG_MMC_SDHCI_OF_ESDHC=y
> > CONFIG_EDAC=y
> > CONFIG_EDAC_MM_EDAC=y
> > CONFIG_RTC_CLASS=y
>
> With this on t4240rdb I'm continually spammed with:
> sdhci-esdhc ffe114000.sdhc: no support for card's volts
> mmc0: error -22 whilst initialising SD card sdhci-esdhc ffe114000.sdhc:
> no support for card's volts
> mmc0: error -22 whilst initialising SD card
>
> Releveant boot messages include:
> sdhci: Secure Digital Host Controller Interface driver
> sdhci: Copyright(c) Pierre Ossman
> sdhci-pltfm: SDHCI platform and OF driver helper sdhci-esdhc
> ffe114000.sdhc: No vmmc regulator found sdhci-esdhc ffe114000.sdhc: No
> vqmmc regulator found
> mmc0: SDHCI controller on ffe114000.sdhc [ffe114000.sdhc] using ADMA ...
> mmc0: error -22 whilst initialising SD card ...
> sdhci-esdhc ffe114000.sdhc: no support for card's volts
> mmc0: error -22 whilst initialising SD card
>
> -Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* RE: powerpc/corenet: enable eSDHC
@ 2015-06-08 10:12 ` Lu Y.B.
0 siblings, 0 replies; 14+ messages in thread
From: Lu Y.B. @ 2015-06-08 10:12 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, linux-mmc
Thanks a lot, Scott.
And now a patch was merged on git://git.linaro.org/people/ulf.hansson/mmc.g=
it next branch to fix this issue.
It should be no problem.
>From 5fd26c7ecb32082745b0bd33c8e35badd1cb5a91 Mon Sep 17 00:00:00 2001
From: Ulf Hansson <ulf.hansson@linaro.org>
Date: Fri, 5 Jun 2015 11:40:08 +0200
Subject: [PATCH] mmc: sdhci: Restore behavior while creating OCR mask
Commit 3a48edc4bd68 ("mmc: sdhci: Use mmc core regulator infrastucture")
changed the behavior for how to assign the ocr_avail mask for the mmc
host. More precisely it started to mask the bits instead of assigning
them.
Restore the behavior, but also make it clear that an OCR mask created
from an external regulator overrides the other ones. The OCR mask is
determined by one of the following with this priority:
1. Supported ranges of external regulator if one supplies VDD
2. Host OCR mask if set by the driver (based on DT properties)
3. The capabilities reported by the controller itself
Fixes: 3a48edc4bd68 ("mmc: sdhci: Use mmc core regulator infrastucture")
Cc: Tim Kryger <tim.kryger@gmail.com>
Reported-by: Yangbo Lu <yangbo.lu@freescale.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Tim Kryger <tim.kryger@gmail.com>
---
drivers/mmc/host/sdhci.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1b4861d..706bb60 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -3256,13 +3256,14 @@ int sdhci_add_host(struct sdhci_host *host)
SDHCI_MAX_CURRENT_MULTIPLIER;
}
=20
- /* If OCR set by external regulators, use it instead */
+ /* If OCR set by host, use it instead. */
+ if (host->ocr_mask)
+ ocr_avail =3D host->ocr_mask;
+
+ /* If OCR set by external regulators, give it highest prio. */
if (mmc->ocr_avail)
ocr_avail =3D mmc->ocr_avail;
=20
- if (host->ocr_mask)
- ocr_avail &=3D host->ocr_mask;
-
mmc->ocr_avail =3D ocr_avail;
mmc->ocr_avail_sdio =3D ocr_avail;
if (host->ocr_avail_sdio)
--=20
2.1.0.27.g96db324
Best regards,
Yangbo Lu
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Saturday, May 30, 2015 8:04 AM
> To: Lu Yangbo-B47093
> Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org
> Subject: Re: powerpc/corenet: enable eSDHC
>=20
> On Wed, May 06, 2015 at 02:29:08PM +0800, Yangbo Lu wrote:
> > Signed-off-by: Yangbo Lu <yangbo.lu@freescale.com>
> > ---
> > arch/powerpc/configs/corenet32_smp_defconfig | 2 ++
> > arch/powerpc/configs/corenet64_smp_defconfig | 2 ++
> > 2 files changed, 4 insertions(+)
> >
> > diff --git a/arch/powerpc/configs/corenet32_smp_defconfig
> > b/arch/powerpc/configs/corenet32_smp_defconfig
> > index ca7957b..17fb2e0 100644
> > --- a/arch/powerpc/configs/corenet32_smp_defconfig
> > +++ b/arch/powerpc/configs/corenet32_smp_defconfig
> > @@ -130,6 +130,8 @@ CONFIG_USB_OHCI_HCD_PPC_OF_LE=3Dy
> > CONFIG_USB_STORAGE=3Dy CONFIG_MMC=3Dy CONFIG_MMC_SDHCI=3Dy
> > +CONFIG_MMC_SDHCI_PLTFM=3Dy
> > +CONFIG_MMC_SDHCI_OF_ESDHC=3Dy
> > CONFIG_EDAC=3Dy
> > CONFIG_EDAC_MM_EDAC=3Dy
> > CONFIG_EDAC_MPC85XX=3Dy
> > diff --git a/arch/powerpc/configs/corenet64_smp_defconfig
> > b/arch/powerpc/configs/corenet64_smp_defconfig
> > index 04737aa..4605a55 100644
> > --- a/arch/powerpc/configs/corenet64_smp_defconfig
> > +++ b/arch/powerpc/configs/corenet64_smp_defconfig
> > @@ -112,6 +112,8 @@ CONFIG_USB_EHCI_FSL=3Dy CONFIG_USB_STORAGE=3Dy
> > CONFIG_MMC=3Dy CONFIG_MMC_SDHCI=3Dy
> > +CONFIG_MMC_SDHCI_PLTFM=3Dy
> > +CONFIG_MMC_SDHCI_OF_ESDHC=3Dy
> > CONFIG_EDAC=3Dy
> > CONFIG_EDAC_MM_EDAC=3Dy
> > CONFIG_RTC_CLASS=3Dy
>=20
> With this on t4240rdb I'm continually spammed with:
> sdhci-esdhc ffe114000.sdhc: no support for card's volts
> mmc0: error -22 whilst initialising SD card sdhci-esdhc ffe114000.sdhc:
> no support for card's volts
> mmc0: error -22 whilst initialising SD card
>=20
> Releveant boot messages include:
> sdhci: Secure Digital Host Controller Interface driver
> sdhci: Copyright(c) Pierre Ossman
> sdhci-pltfm: SDHCI platform and OF driver helper sdhci-esdhc
> ffe114000.sdhc: No vmmc regulator found sdhci-esdhc ffe114000.sdhc: No
> vqmmc regulator found
> mmc0: SDHCI controller on ffe114000.sdhc [ffe114000.sdhc] using ADMA ...
> mmc0: error -22 whilst initialising SD card ...
> sdhci-esdhc ffe114000.sdhc: no support for card's volts
> mmc0: error -22 whilst initialising SD card
>=20
> -Scott
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: powerpc/corenet: enable eSDHC
2015-06-08 10:12 ` Lu Y.B.
(?)
@ 2015-06-08 20:30 ` Scott Wood
2015-07-16 2:37 ` Lu Y.B.
-1 siblings, 1 reply; 14+ messages in thread
From: Scott Wood @ 2015-06-08 20:30 UTC (permalink / raw)
To: Lu Yangbo-B47093; +Cc: linuxppc-dev, linux-mmc
On Mon, 2015-06-08 at 05:12 -0500, Lu Yangbo-B47093 wrote:
> Thanks a lot, Scott.
> And now a patch was merged on
> git://git.linaro.org/people/ulf.hansson/mmc.git next branch to fix
> this issue.
> It should be no problem.
Assuming that patch fixes it and gets pulled for 4.2, this config
patch can go in for 4.3.
That said, it would be nice if, apart from fixing the problem itself,
the MMC code failed more gracefully instead of endlessly repeating and
filling up the log/console.
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: powerpc/corenet: enable eSDHC
2015-06-08 20:30 ` Scott Wood
@ 2015-07-16 2:37 ` Lu Y.B.
0 siblings, 0 replies; 14+ messages in thread
From: Lu Y.B. @ 2015-07-16 2:37 UTC (permalink / raw)
To: Scott Wood; +Cc: linux-mmc, linuxppc-dev
Hi Scott,
Now the patch below has been merged on git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git.
This issue should have been resolved.
Thanks.
commit 5fd26c7ecb32082745b0bd33c8e35badd1cb5a91
Author: Ulf Hansson <ulf.hansson@linaro.org>
Date: Fri Jun 5 11:40:08 2015 +0200
mmc: sdhci: Restore behavior while creating OCR mask
> -----Original Message-----
> From: Wood Scott-B07421
> Sent: Tuesday, June 09, 2015 4:31 AM
> To: Lu Yangbo-B47093
> Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org
> Subject: Re: powerpc/corenet: enable eSDHC
>
> On Mon, 2015-06-08 at 05:12 -0500, Lu Yangbo-B47093 wrote:
> > Thanks a lot, Scott.
> > And now a patch was merged on
> > git://git.linaro.org/people/ulf.hansson/mmc.git next branch to fix
> > this issue.
> > It should be no problem.
>
> Assuming that patch fixes it and gets pulled for 4.2, this config patch
> can go in for 4.3.
>
> That said, it would be nice if, apart from fixing the problem itself, the
> MMC code failed more gracefully instead of endlessly repeating and
> filling up the log/console.
>
> -Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: powerpc/corenet: enable eSDHC
@ 2015-07-16 2:37 ` Lu Y.B.
0 siblings, 0 replies; 14+ messages in thread
From: Lu Y.B. @ 2015-07-16 2:37 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, linux-mmc
SGkgU2NvdHQsDQoNCk5vdyB0aGUgcGF0Y2ggYmVsb3cgaGFzIGJlZW4gbWVyZ2VkIG9uIGdpdDov
L2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5n
aXQuDQpUaGlzIGlzc3VlIHNob3VsZCBoYXZlIGJlZW4gcmVzb2x2ZWQuIA0KVGhhbmtzLg0KDQoN
CmNvbW1pdCA1ZmQyNmM3ZWNiMzIwODI3NDViMGJkMzNjOGUzNWJhZGQxY2I1YTkxDQpBdXRob3I6
IFVsZiBIYW5zc29uIDx1bGYuaGFuc3NvbkBsaW5hcm8ub3JnPg0KRGF0ZTogICBGcmkgSnVuIDUg
MTE6NDA6MDggMjAxNSArMDIwMA0KDQogICAgbW1jOiBzZGhjaTogUmVzdG9yZSBiZWhhdmlvciB3
aGlsZSBjcmVhdGluZyBPQ1IgbWFzaw0KDQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0N
Cj4gRnJvbTogV29vZCBTY290dC1CMDc0MjENCj4gU2VudDogVHVlc2RheSwgSnVuZSAwOSwgMjAx
NSA0OjMxIEFNDQo+IFRvOiBMdSBZYW5nYm8tQjQ3MDkzDQo+IENjOiBsaW51eHBwYy1kZXZAbGlz
dHMub3psYWJzLm9yZzsgbGludXgtbW1jQHZnZXIua2VybmVsLm9yZw0KPiBTdWJqZWN0OiBSZTog
cG93ZXJwYy9jb3JlbmV0OiBlbmFibGUgZVNESEMNCj4gDQo+IE9uIE1vbiwgMjAxNS0wNi0wOCBh
dCAwNToxMiAtMDUwMCwgTHUgWWFuZ2JvLUI0NzA5MyB3cm90ZToNCj4gPiBUaGFua3MgYSBsb3Qs
IFNjb3R0Lg0KPiA+IEFuZCBub3cgYSBwYXRjaCB3YXMgbWVyZ2VkIG9uDQo+ID4gZ2l0Oi8vZ2l0
LmxpbmFyby5vcmcvcGVvcGxlL3VsZi5oYW5zc29uL21tYy5naXQgbmV4dCBicmFuY2ggdG8gZml4
DQo+ID4gdGhpcyBpc3N1ZS4NCj4gPiBJdCBzaG91bGQgYmUgbm8gcHJvYmxlbS4NCj4gDQo+IEFz
c3VtaW5nIHRoYXQgcGF0Y2ggZml4ZXMgaXQgYW5kIGdldHMgcHVsbGVkIGZvciA0LjIsIHRoaXMg
Y29uZmlnIHBhdGNoDQo+IGNhbiBnbyBpbiBmb3IgNC4zLg0KPiANCj4gVGhhdCBzYWlkLCBpdCB3
b3VsZCBiZSBuaWNlIGlmLCBhcGFydCBmcm9tIGZpeGluZyB0aGUgcHJvYmxlbSBpdHNlbGYsIHRo
ZQ0KPiBNTUMgY29kZSBmYWlsZWQgbW9yZSBncmFjZWZ1bGx5IGluc3RlYWQgb2YgZW5kbGVzc2x5
IHJlcGVhdGluZyBhbmQNCj4gZmlsbGluZyB1cCB0aGUgbG9nL2NvbnNvbGUuDQo+IA0KPiAtU2Nv
dHQNCg0K
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: powerpc/corenet: enable eSDHC
2015-07-16 2:37 ` Lu Y.B.
@ 2015-07-16 20:30 ` Scott Wood
-1 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2015-07-16 20:30 UTC (permalink / raw)
To: Lu Yangbo-B47093; +Cc: linux-mmc, linuxppc-dev
OK, thanks. Assuming no similar issues when testing, I'll apply this patch
the next time I do a batch of patch application.
Any thoughts regarding better error handling?
-Scott
On Wed, 2015-07-15 at 21:37 -0500, Lu Yangbo-B47093 wrote:
> Hi Scott,
>
> Now the patch below has been merged on
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git.
> This issue should have been resolved.
> Thanks.
>
>
> commit 5fd26c7ecb32082745b0bd33c8e35badd1cb5a91
> Author: Ulf Hansson <ulf.hansson@linaro.org>
> Date: Fri Jun 5 11:40:08 2015 +0200
>
> mmc: sdhci: Restore behavior while creating OCR mask
>
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, June 09, 2015 4:31 AM
> > To: Lu Yangbo-B47093
> > Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org
> > Subject: Re: powerpc/corenet: enable eSDHC
> >
> > On Mon, 2015-06-08 at 05:12 -0500, Lu Yangbo-B47093 wrote:
> > > Thanks a lot, Scott.
> > > And now a patch was merged on
> > > git://git.linaro.org/people/ulf.hansson/mmc.git next branch to fix
> > > this issue.
> > > It should be no problem.
> >
> > Assuming that patch fixes it and gets pulled for 4.2, this config patch
> > can go in for 4.3.
> >
> > That said, it would be nice if, apart from fixing the problem itself, the
> > MMC code failed more gracefully instead of endlessly repeating and
> > filling up the log/console.
> >
> > -Scott
>
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: powerpc/corenet: enable eSDHC
@ 2015-07-16 20:30 ` Scott Wood
0 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2015-07-16 20:30 UTC (permalink / raw)
To: Lu Yangbo-B47093; +Cc: linuxppc-dev, linux-mmc
OK, thanks. Assuming no similar issues when testing, I'll apply this patch
the next time I do a batch of patch application.
Any thoughts regarding better error handling?
-Scott
On Wed, 2015-07-15 at 21:37 -0500, Lu Yangbo-B47093 wrote:
> Hi Scott,
>
> Now the patch below has been merged on
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git.
> This issue should have been resolved.
> Thanks.
>
>
> commit 5fd26c7ecb32082745b0bd33c8e35badd1cb5a91
> Author: Ulf Hansson <ulf.hansson@linaro.org>
> Date: Fri Jun 5 11:40:08 2015 +0200
>
> mmc: sdhci: Restore behavior while creating OCR mask
>
>
> > -----Original Message-----
> > From: Wood Scott-B07421
> > Sent: Tuesday, June 09, 2015 4:31 AM
> > To: Lu Yangbo-B47093
> > Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org
> > Subject: Re: powerpc/corenet: enable eSDHC
> >
> > On Mon, 2015-06-08 at 05:12 -0500, Lu Yangbo-B47093 wrote:
> > > Thanks a lot, Scott.
> > > And now a patch was merged on
> > > git://git.linaro.org/people/ulf.hansson/mmc.git next branch to fix
> > > this issue.
> > > It should be no problem.
> >
> > Assuming that patch fixes it and gets pulled for 4.2, this config patch
> > can go in for 4.3.
> >
> > That said, it would be nice if, apart from fixing the problem itself, the
> > MMC code failed more gracefully instead of endlessly repeating and
> > filling up the log/console.
> >
> > -Scott
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: powerpc/corenet: enable eSDHC
2015-07-16 20:30 ` Scott Wood
@ 2015-07-20 6:43 ` Lu Y.B.
-1 siblings, 0 replies; 14+ messages in thread
From: Lu Y.B. @ 2015-07-20 6:43 UTC (permalink / raw)
To: Scott Wood; +Cc: linux-mmc, linuxppc-dev
> OK, thanks. Assuming no similar issues when testing, I'll apply this
> patch the next time I do a batch of patch application.
>
> Any thoughts regarding better error handling?
>
> -Scott
Do you mean SD test?
Actually SD patches needing to sent to upstream are tested on Li Yang's Linux tree.
And the JIRA ticket is QORIQLU-19.
>
> On Wed, 2015-07-15 at 21:37 -0500, Lu Yangbo-B47093 wrote:
> > Hi Scott,
> >
> > Now the patch below has been merged on
> > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git.
> > This issue should have been resolved.
> > Thanks.
> >
> >
> > commit 5fd26c7ecb32082745b0bd33c8e35badd1cb5a91
> > Author: Ulf Hansson <ulf.hansson@linaro.org>
> > Date: Fri Jun 5 11:40:08 2015 +0200
> >
> > mmc: sdhci: Restore behavior while creating OCR mask
> >
> >
> > > -----Original Message-----
> > > From: Wood Scott-B07421
> > > Sent: Tuesday, June 09, 2015 4:31 AM
> > > To: Lu Yangbo-B47093
> > > Cc: linuxppc-dev@lists.ozlabs.org; linux-mmc@vger.kernel.org
> > > Subject: Re: powerpc/corenet: enable eSDHC
> > >
> > > On Mon, 2015-06-08 at 05:12 -0500, Lu Yangbo-B47093 wrote:
> > > > Thanks a lot, Scott.
> > > > And now a patch was merged on
> > > > git://git.linaro.org/people/ulf.hansson/mmc.git next branch to fix
> > > > this issue.
> > > > It should be no problem.
> > >
> > > Assuming that patch fixes it and gets pulled for 4.2, this config
> > > patch can go in for 4.3.
> > >
> > > That said, it would be nice if, apart from fixing the problem
> > > itself, the MMC code failed more gracefully instead of endlessly
> > > repeating and filling up the log/console.
> > >
> > > -Scott
> >
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: powerpc/corenet: enable eSDHC
@ 2015-07-20 6:43 ` Lu Y.B.
0 siblings, 0 replies; 14+ messages in thread
From: Lu Y.B. @ 2015-07-20 6:43 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, linux-mmc
PiBPSywgdGhhbmtzLiAgQXNzdW1pbmcgbm8gc2ltaWxhciBpc3N1ZXMgd2hlbiB0ZXN0aW5nLCBJ
J2xsIGFwcGx5IHRoaXMNCj4gcGF0Y2ggdGhlIG5leHQgdGltZSBJIGRvIGEgYmF0Y2ggb2YgcGF0
Y2ggYXBwbGljYXRpb24uDQo+IA0KPiBBbnkgdGhvdWdodHMgcmVnYXJkaW5nIGJldHRlciBlcnJv
ciBoYW5kbGluZz8NCj4gDQo+IC1TY290dA0KDQpEbyB5b3UgbWVhbiBTRCB0ZXN0Pw0KQWN0dWFs
bHkgU0QgcGF0Y2hlcyBuZWVkaW5nIHRvIHNlbnQgdG8gdXBzdHJlYW0gYXJlIHRlc3RlZCBvbiBM
aSBZYW5nJ3MgTGludXggdHJlZS4NCkFuZCB0aGUgSklSQSB0aWNrZXQgaXMgUU9SSVFMVS0xOS4N
Cg0KDQo+IA0KPiBPbiBXZWQsIDIwMTUtMDctMTUgYXQgMjE6MzcgLTA1MDAsIEx1IFlhbmdiby1C
NDcwOTMgd3JvdGU6DQo+ID4gSGkgU2NvdHQsDQo+ID4NCj4gPiBOb3cgdGhlIHBhdGNoIGJlbG93
IGhhcyBiZWVuIG1lcmdlZCBvbg0KPiA+IGdpdDovL2dpdC5rZXJuZWwub3JnL3B1Yi9zY20vbGlu
dXgva2VybmVsL2dpdC90b3J2YWxkcy9saW51eC5naXQuDQo+ID4gVGhpcyBpc3N1ZSBzaG91bGQg
aGF2ZSBiZWVuIHJlc29sdmVkLg0KPiA+IFRoYW5rcy4NCj4gPg0KPiA+DQo+ID4gY29tbWl0IDVm
ZDI2YzdlY2IzMjA4Mjc0NWIwYmQzM2M4ZTM1YmFkZDFjYjVhOTENCj4gPiBBdXRob3I6IFVsZiBI
YW5zc29uIDx1bGYuaGFuc3NvbkBsaW5hcm8ub3JnPg0KPiA+IERhdGU6ICAgRnJpIEp1biA1IDEx
OjQwOjA4IDIwMTUgKzAyMDANCj4gPg0KPiA+ICAgICBtbWM6IHNkaGNpOiBSZXN0b3JlIGJlaGF2
aW9yIHdoaWxlIGNyZWF0aW5nIE9DUiBtYXNrDQo+ID4NCj4gPg0KPiA+ID4gLS0tLS1PcmlnaW5h
bCBNZXNzYWdlLS0tLS0NCj4gPiA+IEZyb206IFdvb2QgU2NvdHQtQjA3NDIxDQo+ID4gPiBTZW50
OiBUdWVzZGF5LCBKdW5lIDA5LCAyMDE1IDQ6MzEgQU0NCj4gPiA+IFRvOiBMdSBZYW5nYm8tQjQ3
MDkzDQo+ID4gPiBDYzogbGludXhwcGMtZGV2QGxpc3RzLm96bGFicy5vcmc7IGxpbnV4LW1tY0B2
Z2VyLmtlcm5lbC5vcmcNCj4gPiA+IFN1YmplY3Q6IFJlOiBwb3dlcnBjL2NvcmVuZXQ6IGVuYWJs
ZSBlU0RIQw0KPiA+ID4NCj4gPiA+IE9uIE1vbiwgMjAxNS0wNi0wOCBhdCAwNToxMiAtMDUwMCwg
THUgWWFuZ2JvLUI0NzA5MyB3cm90ZToNCj4gPiA+ID4gVGhhbmtzIGEgbG90LCBTY290dC4NCj4g
PiA+ID4gQW5kIG5vdyBhIHBhdGNoIHdhcyBtZXJnZWQgb24NCj4gPiA+ID4gZ2l0Oi8vZ2l0Lmxp
bmFyby5vcmcvcGVvcGxlL3VsZi5oYW5zc29uL21tYy5naXQgbmV4dCBicmFuY2ggdG8gZml4DQo+
ID4gPiA+IHRoaXMgaXNzdWUuDQo+ID4gPiA+IEl0IHNob3VsZCBiZSBubyBwcm9ibGVtLg0KPiA+
ID4NCj4gPiA+IEFzc3VtaW5nIHRoYXQgcGF0Y2ggZml4ZXMgaXQgYW5kIGdldHMgcHVsbGVkIGZv
ciA0LjIsIHRoaXMgY29uZmlnDQo+ID4gPiBwYXRjaCBjYW4gZ28gaW4gZm9yIDQuMy4NCj4gPiA+
DQo+ID4gPiBUaGF0IHNhaWQsIGl0IHdvdWxkIGJlIG5pY2UgaWYsIGFwYXJ0IGZyb20gZml4aW5n
IHRoZSBwcm9ibGVtDQo+ID4gPiBpdHNlbGYsIHRoZSBNTUMgY29kZSBmYWlsZWQgbW9yZSBncmFj
ZWZ1bGx5IGluc3RlYWQgb2YgZW5kbGVzc2x5DQo+ID4gPiByZXBlYXRpbmcgYW5kIGZpbGxpbmcg
dXAgdGhlIGxvZy9jb25zb2xlLg0KPiA+ID4NCj4gPiA+IC1TY290dA0KPiA+DQo=
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: powerpc/corenet: enable eSDHC
2015-07-20 6:43 ` Lu Y.B.
@ 2015-07-24 15:09 ` Scott Wood
-1 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2015-07-24 15:09 UTC (permalink / raw)
To: Lu Yangbo-B47093; +Cc: linux-mmc, linuxppc-dev
On Mon, 2015-07-20 at 01:43 -0500, Lu Yangbo-B47093 wrote:
> > OK, thanks. Assuming no similar issues when testing, I'll apply this
> > patch the next time I do a batch of patch application.
> >
> > Any thoughts regarding better error handling?
> >
> > -Scott
>
> Do you mean SD test?
I just mean that I will verify that enabling the option doesn't make things
worse.
> Actually SD patches needing to sent to upstream are tested on Li Yang's
> Linux tree.
I thought you said the patch was already merged.
> And the JIRA ticket is QORIQLU-19.
Don't reference internal tickets on upstream lists.
-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: powerpc/corenet: enable eSDHC
@ 2015-07-24 15:09 ` Scott Wood
0 siblings, 0 replies; 14+ messages in thread
From: Scott Wood @ 2015-07-24 15:09 UTC (permalink / raw)
To: Lu Yangbo-B47093; +Cc: linuxppc-dev, linux-mmc
On Mon, 2015-07-20 at 01:43 -0500, Lu Yangbo-B47093 wrote:
> > OK, thanks. Assuming no similar issues when testing, I'll apply this
> > patch the next time I do a batch of patch application.
> >
> > Any thoughts regarding better error handling?
> >
> > -Scott
>
> Do you mean SD test?
I just mean that I will verify that enabling the option doesn't make things
worse.
> Actually SD patches needing to sent to upstream are tested on Li Yang's
> Linux tree.
I thought you said the patch was already merged.
> And the JIRA ticket is QORIQLU-19.
Don't reference internal tickets on upstream lists.
-Scott
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2015-07-24 15:09 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-06 6:29 [PATCH] powerpc/corenet: enable eSDHC Yangbo Lu
2015-05-30 0:03 ` Scott Wood
2015-05-30 0:03 ` Scott Wood
2015-06-08 10:12 ` Lu Y.B.
2015-06-08 10:12 ` Lu Y.B.
2015-06-08 20:30 ` Scott Wood
2015-07-16 2:37 ` Lu Y.B.
2015-07-16 2:37 ` Lu Y.B.
2015-07-16 20:30 ` Scott Wood
2015-07-16 20:30 ` Scott Wood
2015-07-20 6:43 ` Lu Y.B.
2015-07-20 6:43 ` Lu Y.B.
2015-07-24 15:09 ` Scott Wood
2015-07-24 15:09 ` Scott Wood
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.