[Buildroot] [PATCH 1/3] package/gnuchess: add gettext dependency

[Buildroot] [PATCH 1/3] package/gnuchess: add gettext dependency

[Romain Naour]

gnuchess check for libintl library if BR2_NEEDS_GETTEXT_IF_LOCALE is set.

checking for GNU gettext in libintl... yes
checking whether to use NLS... yes
checking where the gettext function comes from... external libintl
checking how to link with libintl... -lintl

But the dependency on gettext package is missing to ensures
reproducible builds.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/gnuchess/Config.in   | 1 +
 package/gnuchess/gnuchess.mk | 3 ++-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/package/gnuchess/Config.in b/package/gnuchess/Config.in
index aa446f4..4993b1a 100644
--- a/package/gnuchess/Config.in
+++ b/package/gnuchess/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_GNUCHESS
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_FLEX
+	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE
 	help
 	  GNU Chess lets most modern computers play a full game of chess.
 
diff --git a/package/gnuchess/gnuchess.mk b/package/gnuchess/gnuchess.mk
index 48e8bc8..0555cb1 100644
--- a/package/gnuchess/gnuchess.mk
+++ b/package/gnuchess/gnuchess.mk
@@ -10,6 +10,7 @@ GNUCHESS_LICENSE = GPLv2+
 GNUCHESS_LICENSE_FILES = COPYING
 
 GNUCHESS_DEPENDENCIES = host-flex flex
-GNUCHESS_DEPENDENCIES += $(if $(BR2_PACKAGE_READLINE),readline)
+GNUCHESS_DEPENDENCIES += $(if $(BR2_PACKAGE_READLINE),readline) \
+	$(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),gettext)
 
 $(eval $(autotools-package))
-- 
1.9.3

[Buildroot] [PATCH 2/3] package/gnuchess: fix static build with uClibc

[Romain Naour]

Patch src/Makefile.in to avoid to use autoconf and it's
dependencies.

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 .../0001-fix-static-build-with-uClibc.patch        | 47 ++++++++++++++++++++++
 1 file changed, 47 insertions(+)
 create mode 100644 package/gnuchess/0001-fix-static-build-with-uClibc.patch

diff --git a/package/gnuchess/0001-fix-static-build-with-uClibc.patch b/package/gnuchess/0001-fix-static-build-with-uClibc.patch
new file mode 100644
index 0000000..20a0835
--- /dev/null
+++ b/package/gnuchess/0001-fix-static-build-with-uClibc.patch
@@ -0,0 +1,47 @@
+From 5bb2bc6384024c2344ef5cc6785131b382c38170 Mon Sep 17 00:00:00 2001
+From: Romain Naour <romain.naour@openwide.fr>
+Date: Sun, 10 May 2015 22:19:03 +0200
+Subject: [PATCH] fix static build with uClibc
+
+uClibc doesn't provide lintl which should be provided
+by gettext. If gnuchess is linked statically, -lintl should
+be placed after libfrontend.a libadapter.a libengine.a.
+
+Fixes:
+http://autobuild.buildroot.net/results/dcb/dcb1c0eb7212bd8d1e0d8b51fd517b73b7569cea/
+
+Signed-off-by: Romain Naour <romain.naour@openwide.fr>
+---
+ src/Makefile.am | 2 +-
+ src/Makefile.in | 2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+diff --git a/src/Makefile.am b/src/Makefile.am
+index ba90bce..fc02543 100644
+--- a/src/Makefile.am
++++ b/src/Makefile.am
+@@ -34,7 +34,7 @@ DEFS = -DLOCALEDIR=\"$(localedir)\" @DEFS@
+ DISTCLEANFILES = *~
+ 
+ SUBDIRS = frontend adapter engine
+-gnuchess_LDADD = $(LIBINTL) frontend/libfrontend.a adapter/libadapter.a engine/libengine.a
++gnuchess_LDADD = frontend/libfrontend.a adapter/libadapter.a engine/libengine.a $(LIBINTL)
+ 
+ configmake.h: Makefile
+ 	rm -f $@-t $@
+diff --git a/src/Makefile.in b/src/Makefile.in
+index 9460bfd..424da52 100644
+--- a/src/Makefile.in
++++ b/src/Makefile.in
+@@ -395,7 +395,7 @@ AM_LDFLAGS = $(PTHREAD_LDFLAGS) $(PTHREAD_LIBS)
+ AM_CPPFLAGS = -I$(top_srcdir)/lib -I$(top_builddir)/lib
+ DISTCLEANFILES = *~
+ SUBDIRS = frontend adapter engine
+-gnuchess_LDADD = $(LIBINTL) frontend/libfrontend.a adapter/libadapter.a engine/libengine.a
++gnuchess_LDADD = frontend/libfrontend.a adapter/libadapter.a engine/libengine.a $(LIBINTL)
+ BUILT_SOURCES = configmake.h
+ CLEANFILES = configmake.h configmake.h-t
+ all: $(BUILT_SOURCES) config.h
+-- 
+1.9.3
+
-- 
1.9.3

[Buildroot] [PATCH 3/3] package/gnuchess: add hash

[Romain Naour]

Signed-off-by: Romain Naour <romain.naour@openwide.fr>
---
 package/gnuchess/gnuchess.hash | 2 ++
 1 file changed, 2 insertions(+)
 create mode 100644 package/gnuchess/gnuchess.hash

diff --git a/package/gnuchess/gnuchess.hash b/package/gnuchess/gnuchess.hash
new file mode 100644
index 0000000..26342bc
--- /dev/null
+++ b/package/gnuchess/gnuchess.hash
@@ -0,0 +1,2 @@
+# sha256 locally computed
+sha256	17caab725539447bcb17a14b17905242cbf287087e53a6777524feb7bbaeed06	gnuchess-6.2.1.tar.gz
-- 
1.9.3

[Buildroot] [PATCH 1/3] package/gnuchess: add gettext dependency

[Peter Korsgaard]

>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:

 > gnuchess check for libintl library if BR2_NEEDS_GETTEXT_IF_LOCALE is set.
 > checking for GNU gettext in libintl... yes
 > checking whether to use NLS... yes
 > checking where the gettext function comes from... external libintl
 > checking how to link with libintl... -lintl

 > But the dependency on gettext package is missing to ensures
 > reproducible builds.

 > Signed-off-by: Romain Naour <romain.naour@openwide.fr>

Committed all 3, thanks.

-- 
Bye, Peter Korsgaard