All of lore.kernel.org
 help / color / mirror / Atom feed
* [meta-browser][PATCH] chromium: Use bitbake variable instead of shell variable
@ 2015-05-12 19:25 Nikolay Dimitrov
  2015-05-12 22:55 ` Khem Raj
  0 siblings, 1 reply; 3+ messages in thread
From: Nikolay Dimitrov @ 2015-05-12 19:25 UTC (permalink / raw)
  To: openembedded-devel

Change CHROMIUM_BUILD_TYPE to Bitbake variable, otherwise Chromium files are
not installed in the holding area, and Chromium fails to start on the target.

Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
---
 recipes-browser/chromium/chromium.inc |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/recipes-browser/chromium/chromium.inc b/recipes-browser/chromium/chromium.inc
index a9e9b8a..72a649d 100644
--- a/recipes-browser/chromium/chromium.inc
+++ b/recipes-browser/chromium/chromium.inc
@@ -7,7 +7,7 @@ COMPATIBLE_MACHINE_x86-64 = "(.*)"
 COMPATIBLE_MACHINE_armv6 = "(.*)"
 COMPATIBLE_MACHINE_armv7a = "(.*)"
 
-export CHROMIUM_BUILD_TYPE="Release"
+CHROMIUM_BUILD_TYPE = "Release"
 
 inherit gettext
 
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [meta-browser][PATCH] chromium: Use bitbake variable instead of shell variable
  2015-05-12 19:25 [meta-browser][PATCH] chromium: Use bitbake variable instead of shell variable Nikolay Dimitrov
@ 2015-05-12 22:55 ` Khem Raj
  2015-05-12 23:03   ` Otavio Salvador
  0 siblings, 1 reply; 3+ messages in thread
From: Khem Raj @ 2015-05-12 22:55 UTC (permalink / raw)
  To: openembedded-devel

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]


> On May 12, 2015, at 12:25 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
> 
> Change CHROMIUM_BUILD_TYPE to Bitbake variable, otherwise Chromium files are
> not installed in the holding area, and Chromium fails to start on the target.
> 
> Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>

this is ok.

> ---
> recipes-browser/chromium/chromium.inc |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/recipes-browser/chromium/chromium.inc b/recipes-browser/chromium/chromium.inc
> index a9e9b8a..72a649d 100644
> --- a/recipes-browser/chromium/chromium.inc
> +++ b/recipes-browser/chromium/chromium.inc
> @@ -7,7 +7,7 @@ COMPATIBLE_MACHINE_x86-64 = "(.*)"
> COMPATIBLE_MACHINE_armv6 = "(.*)"
> COMPATIBLE_MACHINE_armv7a = "(.*)"
> 
> -export CHROMIUM_BUILD_TYPE="Release"
> +CHROMIUM_BUILD_TYPE = "Release"
> 
> inherit gettext
> 
> --
> 1.7.10.4
> 
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [meta-browser][PATCH] chromium: Use bitbake variable instead of shell variable
  2015-05-12 22:55 ` Khem Raj
@ 2015-05-12 23:03   ` Otavio Salvador
  0 siblings, 0 replies; 3+ messages in thread
From: Otavio Salvador @ 2015-05-12 23:03 UTC (permalink / raw)
  To: OpenEmbedded Devel List

On Tue, May 12, 2015 at 7:55 PM, Khem Raj <raj.khem@gmail.com> wrote:
>> On May 12, 2015, at 12:25 PM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>>
>> Change CHROMIUM_BUILD_TYPE to Bitbake variable, otherwise Chromium files are
>> not installed in the holding area, and Chromium fails to start on the target.
>>
>> Signed-off-by: Nikolay Dimitrov <picmaster@mail.bg>
>
> this is ok.

Khem, please push it :)

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-12 23:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-12 19:25 [meta-browser][PATCH] chromium: Use bitbake variable instead of shell variable Nikolay Dimitrov
2015-05-12 22:55 ` Khem Raj
2015-05-12 23:03   ` Otavio Salvador

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.