All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: arizona: Add missing parenthesis
@ 2015-05-15 15:05 Charles Keepax
  0 siblings, 0 replies; only message in thread
From: Charles Keepax @ 2015-05-15 15:05 UTC (permalink / raw)
  To: lee.jones; +Cc: sameo, patches, linux-kernel, dan.carpenter

Some parenthesis were missing from commit 67f0b1133d55 ("mfd: arizona:
Add better support for system suspend"). This will cause the error check
to run even if the register write didn't happen (although ret will
always be zero so it is harmless). This patch adds the missing
parenthesis.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
---
 drivers/mfd/arizona-core.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
index 5caf579..bebf58a 100644
--- a/drivers/mfd/arizona-core.c
+++ b/drivers/mfd/arizona-core.c
@@ -626,7 +626,7 @@ static int arizona_runtime_suspend(struct device *dev)
 		}
 		break;
 	case WM5102:
-		if (!(val & ARIZONA_JD1_ENA))
+		if (!(val & ARIZONA_JD1_ENA)) {
 			ret = regmap_write(arizona->regmap,
 					   ARIZONA_WRITE_SEQUENCER_CTRL_3, 0x0);
 			if (ret) {
@@ -635,6 +635,7 @@ static int arizona_runtime_suspend(struct device *dev)
 					ret);
 				return ret;
 			}
+		}
 		break;
 	default:
 		break;
-- 
1.7.2.5


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-05-15 15:15 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 15:05 [PATCH] mfd: arizona: Add missing parenthesis Charles Keepax

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.