All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains
@ 2015-05-15 18:23 Thomas Petazzoni
  2015-05-15 18:23 ` [Buildroot] [PATCH 2/6] boost: do not allow boost-log on PowerPC with uClibc Thomas Petazzoni
                   ` (5 more replies)
  0 siblings, 6 replies; 16+ messages in thread
From: Thomas Petazzoni @ 2015-05-15 18:23 UTC (permalink / raw)
  To: buildroot

The current NIOS 2 toolchains are not capable of building Boost, so
let's disable it and its reverse dependencies. Even though it's not
strictly an architecture dependency, we use the <pkg>_ARCH_SUPPORTS
paradigm for this dependency, since it simplifies a lot handling all
boost reverse dependencies, and is anyway quite similar to an
architecture dependency since we don't display a comment about this
dependency.

Fixes:

  http://autobuild.buildroot.net/results/e119b1ef55c546e0d0598b85c46ceefa5c43d5a6/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/boost/Config.in            | 6 ++++++
 package/cc-tool/Config.in          | 2 ++
 package/gnuradio/Config.in         | 2 ++
 package/kodi/Config.in             | 3 ++-
 package/libftdi1/Config.in         | 2 ++
 package/mpd/Config.in              | 1 +
 package/pulseview/Config.in        | 2 ++
 package/python-libconfig/Config.in | 2 ++
 package/thrift/Config.in           | 2 ++
 package/yaml-cpp/Config.in         | 2 ++
 package/zmqpp/Config.in            | 2 ++
 11 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/package/boost/Config.in b/package/boost/Config.in
index add7069..0ed8dd2 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -1,9 +1,15 @@
 comment "boost needs a toolchain w/ C++, threads"
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
 
+config BR2_PACKAGE_BOOST_ARCH_SUPPORTS
+	bool
+	default y if !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405 && \
+		!BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305
+
 config BR2_PACKAGE_BOOST
 	bool "boost"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	# Boost could theorically be built with threading=single, but
 	# that unfortunately doesn't work. Until someone fixes that,
 	# let's depend on threads.
diff --git a/package/cc-tool/Config.in b/package/cc-tool/Config.in
index 5087f4a..be11599 100644
--- a/package/cc-tool/Config.in
+++ b/package/cc-tool/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_CC_TOOL
 	bool "cc-tool"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	select BR2_PACKAGE_LIBUSB
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS
@@ -17,4 +18,5 @@ config BR2_PACKAGE_CC_TOOL
 	  http://sourceforge.net/projects/cctool/
 
 comment "cc-tool needs a toolchain w/ C++, threads"
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/gnuradio/Config.in b/package/gnuradio/Config.in
index 752a50b..574eab4 100644
--- a/package/gnuradio/Config.in
+++ b/package/gnuradio/Config.in
@@ -1,5 +1,6 @@
 comment "gnuradio needs a toolchain w/ C++, NPTL, wchar, dynamic library"
 	depends on BR2_USE_MMU
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS_NPTL || BR2_STATIC_LIBS
 
@@ -10,6 +11,7 @@ config BR2_PACKAGE_GNURADIO
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 	depends on BR2_USE_MMU # use fork()
 	depends on BR2_USE_WCHAR # boost
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_BOOST_DATE_TIME
 	select BR2_PACKAGE_BOOST_FILESYSTEM
diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 254a1df..a4d1aab 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_KODI_ARCH_SUPPORTS
 	bool
-	default y if BR2_arm || BR2_i386 || BR2_x86_64
+	default y if (BR2_arm || BR2_i386 || BR2_x86_64) && BR2_PACKAGE_BOOST_ARCH_SUPPORTS
+
 
 comment "kodi needs a toolchain w/ C++, threads, wchar"
 	depends on BR2_PACKAGE_KODI_ARCH_SUPPORTS
diff --git a/package/libftdi1/Config.in b/package/libftdi1/Config.in
index 9fb80ae..e41dd91 100644
--- a/package/libftdi1/Config.in
+++ b/package/libftdi1/Config.in
@@ -14,11 +14,13 @@ config BR2_PACKAGE_LIBTFDI1_LIBFTDIPP1
 	select BR2_PACKAGE_BOOST
 	depends on BR2_INSTALL_LIBSTDCPP # boost
 	depends on BR2_TOOLCHAIN_HAS_THREADS # boost
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	help
 	  C++ bindings for libftdi
 
 comment "libfdtipp1 needs a toolchain w/ C++"
 	depends on !BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 
 config BR2_PACKAGE_LIBTFDI1_PYTHON_BINDINGS
 	bool "python bindings"
diff --git a/package/mpd/Config.in b/package/mpd/Config.in
index 41a4d54..483a528 100644
--- a/package/mpd/Config.in
+++ b/package/mpd/Config.in
@@ -7,6 +7,7 @@ menuconfig BR2_PACKAGE_MPD
 	# sparc & CS powerpc gcc are too old
 	depends on !BR2_sparc
 	depends on !(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 || BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009)
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBGLIB2
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
diff --git a/package/pulseview/Config.in b/package/pulseview/Config.in
index de899af..df27cde 100644
--- a/package/pulseview/Config.in
+++ b/package/pulseview/Config.in
@@ -15,6 +15,7 @@ config BR2_PACKAGE_PULSEVIEW
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_USE_MMU
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	help
 	  PulseView is a Qt based logic analyzer, oscilloscope
 	  and MSO GUI for sigrok.
@@ -24,4 +25,5 @@ config BR2_PACKAGE_PULSEVIEW
 comment "pulseview needs a toolchain w/ wchar, threads, C++"
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_QT5
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/python-libconfig/Config.in b/package/python-libconfig/Config.in
index 7cc5f8a..b49aa26 100644
--- a/package/python-libconfig/Config.in
+++ b/package/python-libconfig/Config.in
@@ -1,4 +1,5 @@
 comment "python-libconfig needs a toolchain w/ C++, threads"
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
 
 config BR2_PACKAGE_PYTHON_LIBCONFIG
@@ -8,6 +9,7 @@ config BR2_PACKAGE_PYTHON_LIBCONFIG
 	select BR2_PACKAGE_LIBCONFIG
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	help
 	  Python bindings to the C++ library libconfig
 
diff --git a/package/thrift/Config.in b/package/thrift/Config.in
index c5c7c16..b9960f8 100644
--- a/package/thrift/Config.in
+++ b/package/thrift/Config.in
@@ -4,6 +4,7 @@ config BR2_PACKAGE_THRIFT
 	depends on BR2_USE_WCHAR
 	depends on BR2_TOOLCHAIN_HAS_THREADS
 	depends on BR2_ARCH_HAS_ATOMICS
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_LIBEVENT
 	select BR2_PACKAGE_OPENSSL
@@ -20,5 +21,6 @@ config BR2_PACKAGE_THRIFT
 
 comment "thrift needs a toolchain w/ C++, wchar, threads"
 	depends on BR2_ARCH_HAS_ATOMICS
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	depends on !BR2_USE_WCHAR || \
 		!BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/yaml-cpp/Config.in b/package/yaml-cpp/Config.in
index 954a944..9e00b3d 100644
--- a/package/yaml-cpp/Config.in
+++ b/package/yaml-cpp/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_YAML_CPP
 	bool "yaml-cpp"
 	depends on BR2_INSTALL_LIBSTDCPP
 	depends on BR2_TOOLCHAIN_HAS_THREADS # boost
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	select BR2_PACKAGE_BOOST
 	help
 	  yaml-cpp is a YAML parser and emitter in C++ matching
@@ -10,4 +11,5 @@ config BR2_PACKAGE_YAML_CPP
 	  https://code.google.com/p/yaml-cpp/
 
 comment "yaml-cpp needs a toolchain w/ C++, threads"
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/zmqpp/Config.in b/package/zmqpp/Config.in
index f3d10c9..0aaeda3 100644
--- a/package/zmqpp/Config.in
+++ b/package/zmqpp/Config.in
@@ -26,6 +26,7 @@ if BR2_PACKAGE_ZMQPP
 config BR2_PACKAGE_ZMQPP_CLIENT
 	bool "zmqpp client"
 	depends on BR2_TOOLCHAIN_HAS_THREADS # boost
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	select BR2_PACKAGE_BOOST
 	select BR2_PACKAGE_BOOST_PROGRAM_OPTIONS
 	help
@@ -33,6 +34,7 @@ config BR2_PACKAGE_ZMQPP_CLIENT
 	  used to listen or send to zeromq sockets.
 
 comment "zmqpp client needs a toolchain w/ threads"
+	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 	depends on !BR2_TOOLCHAIN_HAS_THREADS
 
 endif
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 2/6] boost: do not allow boost-log on PowerPC with uClibc
  2015-05-15 18:23 [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Thomas Petazzoni
@ 2015-05-15 18:23 ` Thomas Petazzoni
  2015-05-16 13:08   ` Peter Korsgaard
  2015-05-15 18:23 ` [Buildroot] [PATCH 3/6] mosquitto: disable with broken NIOS 2 toolchains Thomas Petazzoni
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2015-05-15 18:23 UTC (permalink / raw)
  To: buildroot

The build of boost-log with a uClibc toolchain on PowerPC fails with
some weird C++ issues. Since nobody ever looked into this problem,
let's "fix" the autobuilder issue by not allowing to select boost-log
in such a situation.

Fixes:

   http://autobuild.buildroot.net/results/13b43105caf4d3952de70030b51f8d96cf6604ee/
   (and many, many similar build failures)

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/boost/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/boost/Config.in b/package/boost/Config.in
index 0ed8dd2..e1b567d 100644
--- a/package/boost/Config.in
+++ b/package/boost/Config.in
@@ -99,6 +99,9 @@ comment "boost-locale needs a toolchain w/ wchar"
 config BR2_PACKAGE_BOOST_LOG
 	bool "boost-log"
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
+	# for some reason, uClibc on PowerPC fails to build the boost
+	# log module
+	depends on !(BR2_powerpc && BR2_TOOLCHAIN_USES_UCLIBC)
 
 comment "boost-log needs a toolchain w/ NPTL"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 3/6] mosquitto: disable with broken NIOS 2 toolchains
  2015-05-15 18:23 [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Thomas Petazzoni
  2015-05-15 18:23 ` [Buildroot] [PATCH 2/6] boost: do not allow boost-log on PowerPC with uClibc Thomas Petazzoni
@ 2015-05-15 18:23 ` Thomas Petazzoni
  2015-05-16 13:09   ` Peter Korsgaard
  2015-05-15 18:23 ` [Buildroot] [PATCH 4/6] postgresql: mark as not available for static linking Thomas Petazzoni
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2015-05-15 18:23 UTC (permalink / raw)
  To: buildroot

mosquitto triggers the infamous _gp issue with the NIOS 2 toolchains,
so let's not allow mosquitto in such situations.

Fixes:

  http://autobuild.buildroot.net/results/b853369452115b0c6f32c6c960af2dbdf71a74af/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/mosquitto/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/mosquitto/Config.in b/package/mosquitto/Config.in
index 50937d0..4053c62 100644
--- a/package/mosquitto/Config.in
+++ b/package/mosquitto/Config.in
@@ -2,6 +2,9 @@ config BR2_PACKAGE_MOSQUITTO
 	bool "mosquitto"
 	depends on BR2_USE_MMU # fork()
 	depends on !BR2_STATIC_LIBS # builds .so
+	# Triggers the _gp link issue
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305
 	help
 	  Mosquitto is an open source message broker that implements
 	  the MQ Telemetry Transport protocol versions 3.1 and
@@ -16,3 +19,5 @@ config BR2_PACKAGE_MOSQUITTO
 comment "mosquitto needs a toolchain w/ dynamic library"
 	depends on BR2_USE_MMU
 	depends on BR2_STATIC_LIBS
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201405
+	depends on !BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_NIOSII201305
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 4/6] postgresql: mark as not available for static linking
  2015-05-15 18:23 [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Thomas Petazzoni
  2015-05-15 18:23 ` [Buildroot] [PATCH 2/6] boost: do not allow boost-log on PowerPC with uClibc Thomas Petazzoni
  2015-05-15 18:23 ` [Buildroot] [PATCH 3/6] mosquitto: disable with broken NIOS 2 toolchains Thomas Petazzoni
@ 2015-05-15 18:23 ` Thomas Petazzoni
  2015-05-16 13:12   ` Peter Korsgaard
  2015-05-15 18:23 ` [Buildroot] [PATCH 5/6] qt5base: rename patch to avoid conflict on 0002 Thomas Petazzoni
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2015-05-15 18:23 UTC (permalink / raw)
  To: buildroot

postgresql currently does not build in BR2_STATIC_LIBS=y
configurations, and since there is little interest in using such a big
piece of software in statically linked configuration, this commit
makes postgresql depends on !BR2_STATIC_LIBS.

Fixes:

  http://autobuild.buildroot.net/results/f9ed96d22e91cdba9ad92c4d4ea52e422bf1f1c9/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/postgresql/Config.in | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/postgresql/Config.in b/package/postgresql/Config.in
index 4c53703..e9b8f48 100644
--- a/package/postgresql/Config.in
+++ b/package/postgresql/Config.in
@@ -1,6 +1,10 @@
 config BR2_PACKAGE_POSTGRESQL
 	bool "postgresql"
 	depends on BR2_USE_MMU # fork()
+	# fails to build in a pure static linking scenario, and
+	# postgresql is unlikely to be used in a pure statically
+	# linked environment.
+	depends on !BR2_STATIC_LIBS
 	help
 	  PostgreSQL is a powerful, open source object-relational
 	  database system.
@@ -13,3 +17,6 @@ config BR2_PACKAGE_POSTGRESQL
 	  archives with pg_dump and pg_restore.
 
 	  http://www.postgresql.org
+
+comment "postgresql needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 5/6] qt5base: rename patch to avoid conflict on 0002
  2015-05-15 18:23 [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Thomas Petazzoni
                   ` (2 preceding siblings ...)
  2015-05-15 18:23 ` [Buildroot] [PATCH 4/6] postgresql: mark as not available for static linking Thomas Petazzoni
@ 2015-05-15 18:23 ` Thomas Petazzoni
  2015-05-16 13:13   ` Peter Korsgaard
  2015-05-15 18:23 ` [Buildroot] [PATCH 6/6] qt5base: add patch to fix gold linker issue Thomas Petazzoni
  2015-05-16  7:26 ` [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Peter Korsgaard
  5 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2015-05-15 18:23 UTC (permalink / raw)
  To: buildroot

There are currently two patches with the 0002 sequence number, which
isn't great. Rename one of them to use the 0003 sequence number.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 .../qt5/qt5base/{0002-mkspecs-files.patch => 0003-mkspecs-files.patch}    | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename package/qt5/qt5base/{0002-mkspecs-files.patch => 0003-mkspecs-files.patch} (100%)

diff --git a/package/qt5/qt5base/0002-mkspecs-files.patch b/package/qt5/qt5base/0003-mkspecs-files.patch
similarity index 100%
rename from package/qt5/qt5base/0002-mkspecs-files.patch
rename to package/qt5/qt5base/0003-mkspecs-files.patch
-- 
2.1.0

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 6/6] qt5base: add patch to fix gold linker issue
  2015-05-15 18:23 [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Thomas Petazzoni
                   ` (3 preceding siblings ...)
  2015-05-15 18:23 ` [Buildroot] [PATCH 5/6] qt5base: rename patch to avoid conflict on 0002 Thomas Petazzoni
@ 2015-05-15 18:23 ` Thomas Petazzoni
  2015-05-16 13:13   ` Peter Korsgaard
  2015-05-16  7:26 ` [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Peter Korsgaard
  5 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2015-05-15 18:23 UTC (permalink / raw)
  To: buildroot

The newly added patch makes sure that gold linker functionality is not
used when doing host builds, since qt5 only tests the availability of
this feature with the target compiler.

Fixes:

  http://autobuild.buildroot.net/results/f403a76ac0abbf8488373c0dffb4487f5d98c55d/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 .../0005-no-gold-linker-for-host-build.patch       | 27 ++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 package/qt5/qt5base/0005-no-gold-linker-for-host-build.patch

diff --git a/package/qt5/qt5base/0005-no-gold-linker-for-host-build.patch b/package/qt5/qt5base/0005-no-gold-linker-for-host-build.patch
new file mode 100644
index 0000000..99d5928
--- /dev/null
+++ b/package/qt5/qt5base/0005-no-gold-linker-for-host-build.patch
@@ -0,0 +1,27 @@
+Use the gold linker only for target builds
+
+Availability of the gold linker is only tested with the
+cross-compiler, not the host compiler, so Qt shouldn't assume it's
+available when doing host builds.
+
+This fixes build failures occuring when cross-compiling Qt5 with a
+gold capable cross-compiler, on a host that has a too old compiler to
+support gold.
+
+Bug reported upstream at https://bugreports.qt.io/browse/QTBUG-46125.
+
+Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
+
+Index: b/mkspecs/features/default_post.prf
+===================================================================
+--- a/mkspecs/features/default_post.prf
++++ b/mkspecs/features/default_post.prf
+@@ -62,7 +62,7 @@
+     QMAKE_LIBFLAGS += $$QMAKE_LIBFLAGS_RELEASE
+ }
+ 
+-use_gold_linker: QMAKE_LFLAGS += $$QMAKE_LFLAGS_USE_GOLD
++!host_build: use_gold_linker: QMAKE_LFLAGS += $$QMAKE_LFLAGS_USE_GOLD
+ 
+ dll:win32: QMAKE_LFLAGS += $$QMAKE_LFLAGS_DLL
+ static:mac: QMAKE_LFLAGS += $$QMAKE_LFLAGS_STATIC_LIB
-- 
2.1.0

^ permalink raw reply related	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains
  2015-05-15 18:23 [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Thomas Petazzoni
                   ` (4 preceding siblings ...)
  2015-05-15 18:23 ` [Buildroot] [PATCH 6/6] qt5base: add patch to fix gold linker issue Thomas Petazzoni
@ 2015-05-16  7:26 ` Peter Korsgaard
  5 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2015-05-16  7:26 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > The current NIOS 2 toolchains are not capable of building Boost, so
 > let's disable it and its reverse dependencies. Even though it's not
 > strictly an architecture dependency, we use the <pkg>_ARCH_SUPPORTS
 > paradigm for this dependency, since it simplifies a lot handling all
 > boost reverse dependencies, and is anyway quite similar to an
 > architecture dependency since we don't display a comment about this
 > dependency.

 > Fixes:

 >   http://autobuild.buildroot.net/results/e119b1ef55c546e0d0598b85c46ceefa5c43d5a6/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > ---
 >  package/boost/Config.in            | 6 ++++++
 >  package/cc-tool/Config.in          | 2 ++
 >  package/gnuradio/Config.in         | 2 ++
 >  package/kodi/Config.in             | 3 ++-
 >  package/libftdi1/Config.in         | 2 ++
 >  package/mpd/Config.in              | 1 +
 >  package/pulseview/Config.in        | 2 ++
 >  package/python-libconfig/Config.in | 2 ++
 >  package/thrift/Config.in           | 2 ++
 >  package/yaml-cpp/Config.in         | 2 ++
 >  package/zmqpp/Config.in            | 2 ++
 >  11 files changed, 25 insertions(+), 1 deletion(-)

[snip]

 > +++ b/package/libftdi1/Config.in
 > @@ -14,11 +14,13 @@ config BR2_PACKAGE_LIBTFDI1_LIBFTDIPP1

Not related to this patch, but there's a typo in this symbol (FTDI1 not
TFDI1). I'll fix that.

> +++ b/package/mpd/Config.in
 > @@ -7,6 +7,7 @@ menuconfig BR2_PACKAGE_MPD
 >  	# sparc & CS powerpc gcc are too old
 >  	depends on !BR2_sparc
 >  	depends on !(BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201103 || BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_POWERPC201009)
 > +	depends on BR2_PACKAGE_BOOST_ARCH_SUPPORTS
 >  	select BR2_PACKAGE_BOOST
 >  	select BR2_PACKAGE_LIBGLIB2
 >  	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE

You forgot to update the comment. I know it doesn't have any practical
impact right now as mpd needs mmu, but we should still add it in case
some other archs needs to get blacklisted.

Committed with that fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 2/6] boost: do not allow boost-log on PowerPC with uClibc
  2015-05-15 18:23 ` [Buildroot] [PATCH 2/6] boost: do not allow boost-log on PowerPC with uClibc Thomas Petazzoni
@ 2015-05-16 13:08   ` Peter Korsgaard
  0 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2015-05-16 13:08 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > The build of boost-log with a uClibc toolchain on PowerPC fails with
 > some weird C++ issues. Since nobody ever looked into this problem,
 > let's "fix" the autobuilder issue by not allowing to select boost-log
 > in such a situation.

 > Fixes:

 >    http://autobuild.buildroot.net/results/13b43105caf4d3952de70030b51f8d96cf6604ee/
 >    (and many, many similar build failures)

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
 > ---
 >  package/boost/Config.in | 3 +++
 >  1 file changed, 3 insertions(+)

 > diff --git a/package/boost/Config.in b/package/boost/Config.in
 > index 0ed8dd2..e1b567d 100644
 > --- a/package/boost/Config.in
 > +++ b/package/boost/Config.in
 > @@ -99,6 +99,9 @@ comment "boost-locale needs a toolchain w/ wchar"
 >  config BR2_PACKAGE_BOOST_LOG
 >  	bool "boost-log"
 >  	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
 > +	# for some reason, uClibc on PowerPC fails to build the boost
 > +	# log module
 > +	depends on !(BR2_powerpc && BR2_TOOLCHAIN_USES_UCLIBC)
 
 >  comment "boost-log needs a toolchain w/ NPTL"
 >  	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL

You forgot to add that dependency to the comment below. Committed with
that fixed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 3/6] mosquitto: disable with broken NIOS 2 toolchains
  2015-05-15 18:23 ` [Buildroot] [PATCH 3/6] mosquitto: disable with broken NIOS 2 toolchains Thomas Petazzoni
@ 2015-05-16 13:09   ` Peter Korsgaard
  0 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2015-05-16 13:09 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > mosquitto triggers the infamous _gp issue with the NIOS 2 toolchains,
 > so let's not allow mosquitto in such situations.

 > Fixes:

 >   http://autobuild.buildroot.net/results/b853369452115b0c6f32c6c960af2dbdf71a74af/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 4/6] postgresql: mark as not available for static linking
  2015-05-15 18:23 ` [Buildroot] [PATCH 4/6] postgresql: mark as not available for static linking Thomas Petazzoni
@ 2015-05-16 13:12   ` Peter Korsgaard
  2015-05-16 13:32     ` Thomas Petazzoni
  0 siblings, 1 reply; 16+ messages in thread
From: Peter Korsgaard @ 2015-05-16 13:12 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > postgresql currently does not build in BR2_STATIC_LIBS=y
 > configurations, and since there is little interest in using such a big
 > piece of software in statically linked configuration, this commit
 > makes postgresql depends on !BR2_STATIC_LIBS.

 > Fixes:

 >   http://autobuild.buildroot.net/results/f9ed96d22e91cdba9ad92c4d4ea52e422bf1f1c9/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

What about the reverse dependencies?

git grep 'select BR2_PACKAGE_POSTGRESQL'
package/bandwidthd/Config.in:   select BR2_PACKAGE_POSTGRESQL
package/collectd/Config.in:     select BR2_PACKAGE_POSTGRESQL
package/php/Config.ext: select BR2_PACKAGE_POSTGRESQL
package/qt/Config.sql.in:       select BR2_PACKAGE_POSTGRESQL
package/qt5/qt5base/Config.in:  select BR2_PACKAGE_POSTGRESQL

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 5/6] qt5base: rename patch to avoid conflict on 0002
  2015-05-15 18:23 ` [Buildroot] [PATCH 5/6] qt5base: rename patch to avoid conflict on 0002 Thomas Petazzoni
@ 2015-05-16 13:13   ` Peter Korsgaard
  0 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2015-05-16 13:13 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > There are currently two patches with the 0002 sequence number, which
 > isn't great. Rename one of them to use the 0003 sequence number.

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 6/6] qt5base: add patch to fix gold linker issue
  2015-05-15 18:23 ` [Buildroot] [PATCH 6/6] qt5base: add patch to fix gold linker issue Thomas Petazzoni
@ 2015-05-16 13:13   ` Peter Korsgaard
  2015-05-16 13:31     ` Thomas Petazzoni
  0 siblings, 1 reply; 16+ messages in thread
From: Peter Korsgaard @ 2015-05-16 13:13 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > The newly added patch makes sure that gold linker functionality is not
 > used when doing host builds, since qt5 only tests the availability of
 > this feature with the target compiler.

 > Fixes:

 >   http://autobuild.buildroot.net/results/f403a76ac0abbf8488373c0dffb4487f5d98c55d/

 > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Committed, thanks. Don't forget to send the patch upstream.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 6/6] qt5base: add patch to fix gold linker issue
  2015-05-16 13:13   ` Peter Korsgaard
@ 2015-05-16 13:31     ` Thomas Petazzoni
  2015-05-16 13:35       ` Peter Korsgaard
  0 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2015-05-16 13:31 UTC (permalink / raw)
  To: buildroot

Dear Peter Korsgaard,

On Sat, 16 May 2015 15:13:44 +0200, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> 
>  > The newly added patch makes sure that gold linker functionality is not
>  > used when doing host builds, since qt5 only tests the availability of
>  > this feature with the target compiler.
> 
>  > Fixes:
> 
>  >   http://autobuild.buildroot.net/results/f403a76ac0abbf8488373c0dffb4487f5d98c55d/
> 
>  > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> Committed, thanks. Don't forget to send the patch upstream.

I already submitted the patch as part of a bug report, which URL is
mentioned in my Buildroot patch. However, they ask me to follow the
entire Qt contribution process for just a one line patch, which I'm not
sure I'm willing to do :-/

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 4/6] postgresql: mark as not available for static linking
  2015-05-16 13:12   ` Peter Korsgaard
@ 2015-05-16 13:32     ` Thomas Petazzoni
  2015-05-16 13:36       ` Peter Korsgaard
  0 siblings, 1 reply; 16+ messages in thread
From: Thomas Petazzoni @ 2015-05-16 13:32 UTC (permalink / raw)
  To: buildroot

Dear Peter Korsgaard,

On Sat, 16 May 2015 15:12:22 +0200, Peter Korsgaard wrote:
> >>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
> 
>  > postgresql currently does not build in BR2_STATIC_LIBS=y
>  > configurations, and since there is little interest in using such a big
>  > piece of software in statically linked configuration, this commit
>  > makes postgresql depends on !BR2_STATIC_LIBS.
> 
>  > Fixes:
> 
>  >   http://autobuild.buildroot.net/results/f9ed96d22e91cdba9ad92c4d4ea52e422bf1f1c9/
> 
>  > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> 
> What about the reverse dependencies?
> 
> git grep 'select BR2_PACKAGE_POSTGRESQL'
> package/bandwidthd/Config.in:   select BR2_PACKAGE_POSTGRESQL
> package/collectd/Config.in:     select BR2_PACKAGE_POSTGRESQL
> package/php/Config.ext: select BR2_PACKAGE_POSTGRESQL
> package/qt/Config.sql.in:       select BR2_PACKAGE_POSTGRESQL
> package/qt5/qt5base/Config.in:  select BR2_PACKAGE_POSTGRESQL

Gah, shit indeed. For some reason I assumed postgresql is an
application, not a library, so it should not have reverse dependencies.
I'll fix that up and resend.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 6/6] qt5base: add patch to fix gold linker issue
  2015-05-16 13:31     ` Thomas Petazzoni
@ 2015-05-16 13:35       ` Peter Korsgaard
  0 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2015-05-16 13:35 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

Hi,

>> Committed, thanks. Don't forget to send the patch upstream.

 > I already submitted the patch as part of a bug report, which URL is
 > mentioned in my Buildroot patch. However, they ask me to follow the
 > entire Qt contribution process for just a one line patch, which I'm not
 > sure I'm willing to do :-/

Sorry, somehow I missed that line in the patch description.

Yeah, I understand that you don't want to go through a bunch of hoops
for that patch.

-- 
Venlig hilsen,
Peter Korsgaard 

^ permalink raw reply	[flat|nested] 16+ messages in thread

* [Buildroot] [PATCH 4/6] postgresql: mark as not available for static linking
  2015-05-16 13:32     ` Thomas Petazzoni
@ 2015-05-16 13:36       ` Peter Korsgaard
  0 siblings, 0 replies; 16+ messages in thread
From: Peter Korsgaard @ 2015-05-16 13:36 UTC (permalink / raw)
  To: buildroot

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 >> What about the reverse dependencies?
 >> 
 >> git grep 'select BR2_PACKAGE_POSTGRESQL'
 >> package/bandwidthd/Config.in:   select BR2_PACKAGE_POSTGRESQL
 >> package/collectd/Config.in:     select BR2_PACKAGE_POSTGRESQL
 >> package/php/Config.ext: select BR2_PACKAGE_POSTGRESQL
 >> package/qt/Config.sql.in:       select BR2_PACKAGE_POSTGRESQL
 >> package/qt5/qt5base/Config.in:  select BR2_PACKAGE_POSTGRESQL

 > Gah, shit indeed. For some reason I assumed postgresql is an
 > application, not a library, so it should not have reverse dependencies.
 > I'll fix that up and resend.

Thanks!

-- 
Venlig hilsen,
Peter Korsgaard 

^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2015-05-16 13:36 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-15 18:23 [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Thomas Petazzoni
2015-05-15 18:23 ` [Buildroot] [PATCH 2/6] boost: do not allow boost-log on PowerPC with uClibc Thomas Petazzoni
2015-05-16 13:08   ` Peter Korsgaard
2015-05-15 18:23 ` [Buildroot] [PATCH 3/6] mosquitto: disable with broken NIOS 2 toolchains Thomas Petazzoni
2015-05-16 13:09   ` Peter Korsgaard
2015-05-15 18:23 ` [Buildroot] [PATCH 4/6] postgresql: mark as not available for static linking Thomas Petazzoni
2015-05-16 13:12   ` Peter Korsgaard
2015-05-16 13:32     ` Thomas Petazzoni
2015-05-16 13:36       ` Peter Korsgaard
2015-05-15 18:23 ` [Buildroot] [PATCH 5/6] qt5base: rename patch to avoid conflict on 0002 Thomas Petazzoni
2015-05-16 13:13   ` Peter Korsgaard
2015-05-15 18:23 ` [Buildroot] [PATCH 6/6] qt5base: add patch to fix gold linker issue Thomas Petazzoni
2015-05-16 13:13   ` Peter Korsgaard
2015-05-16 13:31     ` Thomas Petazzoni
2015-05-16 13:35       ` Peter Korsgaard
2015-05-16  7:26 ` [Buildroot] [PATCH 1/6] boost: disable on NIOS 2 with broken toolchains Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.