* [PATCH v1 0/1] fix DEBUG_LL on Cortex-A7.
@ 2015-05-17 6:42 ` Tarek Dakhran
0 siblings, 0 replies; 8+ messages in thread
From: Tarek Dakhran @ 2015-05-17 6:42 UTC (permalink / raw)
To: kgene
Cc: linux, k.kozlowski, t.dakhran, t.figa, linux-arm-kernel,
linux-samsung-soc, linux-kernel
When system boots from Cortex-A7 addruart loads
wrong base UART address. This patch fixex problem.
Patch tested on Hardkernel Odroid-XU3 board
on linux kernel v4.0.
Tarek Dakhran (1):
ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.
arch/arm/include/debug/exynos.S | 1 +
1 file changed, 1 insertion(+)
--
1.9.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 0/1] fix DEBUG_LL on Cortex-A7.
@ 2015-05-17 6:42 ` Tarek Dakhran
0 siblings, 0 replies; 8+ messages in thread
From: Tarek Dakhran @ 2015-05-17 6:42 UTC (permalink / raw)
To: linux-arm-kernel
When system boots from Cortex-A7 addruart loads
wrong base UART address. This patch fixex problem.
Patch tested on Hardkernel Odroid-XU3 board
on linux kernel v4.0.
Tarek Dakhran (1):
ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.
arch/arm/include/debug/exynos.S | 1 +
1 file changed, 1 insertion(+)
--
1.9.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.
2015-05-17 6:42 ` Tarek Dakhran
@ 2015-05-17 6:42 ` Tarek Dakhran
-1 siblings, 0 replies; 8+ messages in thread
From: Tarek Dakhran @ 2015-05-17 6:42 UTC (permalink / raw)
To: kgene
Cc: linux, k.kozlowski, t.dakhran, t.figa, linux-arm-kernel,
linux-samsung-soc, linux-kernel
Cortex-A7 has EXYNOS5_PA_UART base address for UART.
If system boots from Cortex-A7 CPU addruart loads wrong
address. This patch fixex this.
Signed-off-by: Tarek Dakhran <t.dakhran@gmail.com>
---
arch/arm/include/debug/exynos.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
index b17fdb7..a61b3ea 100644
--- a/arch/arm/include/debug/exynos.S
+++ b/arch/arm/include/debug/exynos.S
@@ -24,6 +24,7 @@
mrc p15, 0, \tmp, c0, c0, 0
and \tmp, \tmp, #0xf0
teq \tmp, #0xf0 @@ A15
+ teqne \tmp, #0x70 @@ A7
ldreq \rp, =EXYNOS5_PA_UART
movne \rp, #EXYNOS4_PA_UART @@ EXYNOS4
ldr \rv, =S3C_VA_UART
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.
@ 2015-05-17 6:42 ` Tarek Dakhran
0 siblings, 0 replies; 8+ messages in thread
From: Tarek Dakhran @ 2015-05-17 6:42 UTC (permalink / raw)
To: linux-arm-kernel
Cortex-A7 has EXYNOS5_PA_UART base address for UART.
If system boots from Cortex-A7 CPU addruart loads wrong
address. This patch fixex this.
Signed-off-by: Tarek Dakhran <t.dakhran@gmail.com>
---
arch/arm/include/debug/exynos.S | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
index b17fdb7..a61b3ea 100644
--- a/arch/arm/include/debug/exynos.S
+++ b/arch/arm/include/debug/exynos.S
@@ -24,6 +24,7 @@
mrc p15, 0, \tmp, c0, c0, 0
and \tmp, \tmp, #0xf0
teq \tmp, #0xf0 @@ A15
+ teqne \tmp, #0x70 @@ A7
ldreq \rp, =EXYNOS5_PA_UART
movne \rp, #EXYNOS4_PA_UART @@ EXYNOS4
ldr \rv, =S3C_VA_UART
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.
2015-05-17 6:42 ` Tarek Dakhran
@ 2015-05-18 1:52 ` Chanho Park
-1 siblings, 0 replies; 8+ messages in thread
From: Chanho Park @ 2015-05-18 1:52 UTC (permalink / raw)
To: Tarek Dakhran
Cc: kgene, Russell King, k.kozlowski, t.figa, linux-arm-kernel,
linux-samsung-soc, linux-kernel, jy0922.shim
Hi Tarek,
On Sun, May 17, 2015 at 3:42 PM, Tarek Dakhran <t.dakhran@gmail.com> wrote:
> Cortex-A7 has EXYNOS5_PA_UART base address for UART.
> If system boots from Cortex-A7 CPU addruart loads wrong
> address. This patch fixex this.
>
> Signed-off-by: Tarek Dakhran <t.dakhran@gmail.com>
> ---
> arch/arm/include/debug/exynos.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
> index b17fdb7..a61b3ea 100644
> --- a/arch/arm/include/debug/exynos.S
> +++ b/arch/arm/include/debug/exynos.S
> @@ -24,6 +24,7 @@
> mrc p15, 0, \tmp, c0, c0, 0
> and \tmp, \tmp, #0xf0
> teq \tmp, #0xf0 @@ A15
> + teqne \tmp, #0x70 @@ A7
> ldreq \rp, =EXYNOS5_PA_UART
> movne \rp, #EXYNOS4_PA_UART @@ EXYNOS4
> ldr \rv, =S3C_VA_UART
> --
> 1.9.1
>
Please see previous Joonyoung's patch. Your patch could break
exynos3250 because it has not only two cortex-a7 cpus but also uses
EXYOS4_PA_UART.
http://www.spinics.net/lists/linux-samsung-soc/msg37318.html
--
Best Regards,
Chanho Park
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.
@ 2015-05-18 1:52 ` Chanho Park
0 siblings, 0 replies; 8+ messages in thread
From: Chanho Park @ 2015-05-18 1:52 UTC (permalink / raw)
To: linux-arm-kernel
Hi Tarek,
On Sun, May 17, 2015 at 3:42 PM, Tarek Dakhran <t.dakhran@gmail.com> wrote:
> Cortex-A7 has EXYNOS5_PA_UART base address for UART.
> If system boots from Cortex-A7 CPU addruart loads wrong
> address. This patch fixex this.
>
> Signed-off-by: Tarek Dakhran <t.dakhran@gmail.com>
> ---
> arch/arm/include/debug/exynos.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/include/debug/exynos.S b/arch/arm/include/debug/exynos.S
> index b17fdb7..a61b3ea 100644
> --- a/arch/arm/include/debug/exynos.S
> +++ b/arch/arm/include/debug/exynos.S
> @@ -24,6 +24,7 @@
> mrc p15, 0, \tmp, c0, c0, 0
> and \tmp, \tmp, #0xf0
> teq \tmp, #0xf0 @@ A15
> + teqne \tmp, #0x70 @@ A7
> ldreq \rp, =EXYNOS5_PA_UART
> movne \rp, #EXYNOS4_PA_UART @@ EXYNOS4
> ldr \rv, =S3C_VA_UART
> --
> 1.9.1
>
Please see previous Joonyoung's patch. Your patch could break
exynos3250 because it has not only two cortex-a7 cpus but also uses
EXYOS4_PA_UART.
http://www.spinics.net/lists/linux-samsung-soc/msg37318.html
--
Best Regards,
Chanho Park
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.
2015-05-18 1:52 ` Chanho Park
@ 2015-05-18 7:31 ` Tarek Dakhran
-1 siblings, 0 replies; 8+ messages in thread
From: Tarek Dakhran @ 2015-05-18 7:31 UTC (permalink / raw)
To: Chanho Park
Cc: kgene, Russell King, Krzysztof Kozłowski, Tomasz Figa,
linux-arm-kernel, linux-samsung-soc, linux-kernel, jy0922.shim
Hi Chanho,
On Mon, May 18, 2015 at 4:52 AM, Chanho Park <parkch98@gmail.com> wrote:
>
> Please see previous Joonyoung's patch. Your patch could break
> exynos3250 because it has not only two cortex-a7 cpus but also uses
> EXYOS4_PA_UART.
>
> http://www.spinics.net/lists/linux-samsung-soc/msg37318.html
>
Thanks, Joonyoung's patch works for me and it seems really reasonable
to check cluster id.
Best regards,
Tarek
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 1/1] ARM: EXYNOS: fix DEBUG_LL on Cortex-A7.
@ 2015-05-18 7:31 ` Tarek Dakhran
0 siblings, 0 replies; 8+ messages in thread
From: Tarek Dakhran @ 2015-05-18 7:31 UTC (permalink / raw)
To: linux-arm-kernel
Hi Chanho,
On Mon, May 18, 2015 at 4:52 AM, Chanho Park <parkch98@gmail.com> wrote:
>
> Please see previous Joonyoung's patch. Your patch could break
> exynos3250 because it has not only two cortex-a7 cpus but also uses
> EXYOS4_PA_UART.
>
> http://www.spinics.net/lists/linux-samsung-soc/msg37318.html
>
Thanks, Joonyoung's patch works for me and it seems really reasonable
to check cluster id.
Best regards,
Tarek
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2015-05-18 7:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-17 6:42 [PATCH v1 0/1] fix DEBUG_LL on Cortex-A7 Tarek Dakhran
2015-05-17 6:42 ` Tarek Dakhran
2015-05-17 6:42 ` [PATCH v1 1/1] ARM: EXYNOS: " Tarek Dakhran
2015-05-17 6:42 ` Tarek Dakhran
2015-05-18 1:52 ` Chanho Park
2015-05-18 1:52 ` Chanho Park
2015-05-18 7:31 ` Tarek Dakhran
2015-05-18 7:31 ` Tarek Dakhran
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.