* [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used
@ 2015-05-18 11:43 Prabhakar Kushwaha
2015-05-18 14:44 ` Eric Nelson
2015-05-19 13:21 ` Stefano Babic
0 siblings, 2 replies; 4+ messages in thread
From: Prabhakar Kushwaha @ 2015-05-18 11:43 UTC (permalink / raw)
To: u-boot
Fix below warning
arch/arm/imx-common/cpu.c:29:14: warning: ?get_reset_cause? defined but
not used
static char *get_reset_cause(void)
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
arch/arm/imx-common/cpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c
index 067d08f..0cd08cb 100644
--- a/arch/arm/imx-common/cpu.c
+++ b/arch/arm/imx-common/cpu.c
@@ -24,6 +24,7 @@
#include <fsl_esdhc.h>
#endif
+#if defined(CONFIG_DISPLAY_CPUINFO)
static u32 reset_cause = -1;
static char *get_reset_cause(void)
@@ -60,6 +61,7 @@ u32 get_imx_reset_cause(void)
{
return reset_cause;
}
+#endif
#if defined(CONFIG_MX53) || defined(CONFIG_MX6)
#if defined(CONFIG_MX53)
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used
2015-05-18 11:43 [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used Prabhakar Kushwaha
@ 2015-05-18 14:44 ` Eric Nelson
2015-05-19 8:57 ` Stefano Babic
2015-05-19 13:21 ` Stefano Babic
1 sibling, 1 reply; 4+ messages in thread
From: Eric Nelson @ 2015-05-18 14:44 UTC (permalink / raw)
To: u-boot
Hi Prabhakar,
On 05/18/2015 04:43 AM, Prabhakar Kushwaha wrote:
> Fix below warning
> arch/arm/imx-common/cpu.c:29:14: warning: ?get_reset_cause? defined but
> not used
> static char *get_reset_cause(void)
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> arch/arm/imx-common/cpu.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c
> index 067d08f..0cd08cb 100644
> --- a/arch/arm/imx-common/cpu.c
> +++ b/arch/arm/imx-common/cpu.c
> @@ -24,6 +24,7 @@
> #include <fsl_esdhc.h>
> #endif
>
> +#if defined(CONFIG_DISPLAY_CPUINFO)
> static u32 reset_cause = -1;
>
> static char *get_reset_cause(void)
> @@ -60,6 +61,7 @@ u32 get_imx_reset_cause(void)
> {
> return reset_cause;
> }
> +#endif
>
> #if defined(CONFIG_MX53) || defined(CONFIG_MX6)
> #if defined(CONFIG_MX53)
>
This makes the dependency clear, even if it's odd.
Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used
2015-05-18 14:44 ` Eric Nelson
@ 2015-05-19 8:57 ` Stefano Babic
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2015-05-19 8:57 UTC (permalink / raw)
To: u-boot
Hi Prabhakar, Eric,
On 18/05/2015 16:44, Eric Nelson wrote:
> Hi Prabhakar,
>
> On 05/18/2015 04:43 AM, Prabhakar Kushwaha wrote:
>> Fix below warning
>> arch/arm/imx-common/cpu.c:29:14: warning: ?get_reset_cause? defined but
>> not used
>> static char *get_reset_cause(void)
>>
>> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
>> ---
>> arch/arm/imx-common/cpu.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/imx-common/cpu.c b/arch/arm/imx-common/cpu.c
>> index 067d08f..0cd08cb 100644
>> --- a/arch/arm/imx-common/cpu.c
>> +++ b/arch/arm/imx-common/cpu.c
>> @@ -24,6 +24,7 @@
>> #include <fsl_esdhc.h>
>> #endif
>>
>> +#if defined(CONFIG_DISPLAY_CPUINFO)
>> static u32 reset_cause = -1;
>>
>> static char *get_reset_cause(void)
>> @@ -60,6 +61,7 @@ u32 get_imx_reset_cause(void)
>> {
>> return reset_cause;
>> }
>> +#endif
>>
>> #if defined(CONFIG_MX53) || defined(CONFIG_MX6)
>> #if defined(CONFIG_MX53)
>>
>
> This makes the dependency clear, even if it's odd.
>
> Reviewed-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
Yes, anyway this is what we already use for other SOCs (iMX31, iMX35,..
they have a local get_reset_cause() protected by this switch).
Acked-by: Stefano Babic <sbabic@denx.de>
Best regards,
Stefano babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used
2015-05-18 11:43 [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used Prabhakar Kushwaha
2015-05-18 14:44 ` Eric Nelson
@ 2015-05-19 13:21 ` Stefano Babic
1 sibling, 0 replies; 4+ messages in thread
From: Stefano Babic @ 2015-05-19 13:21 UTC (permalink / raw)
To: u-boot
On 18/05/2015 13:43, Prabhakar Kushwaha wrote:
> Fix below warning
> arch/arm/imx-common/cpu.c:29:14: warning: ?get_reset_cause? defined but
> not used
> static char *get_reset_cause(void)
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-19 13:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-18 11:43 [U-Boot] [PATCH] arm/imx-common: Fix warning 'get_reset_cause' defined but not used Prabhakar Kushwaha
2015-05-18 14:44 ` Eric Nelson
2015-05-19 8:57 ` Stefano Babic
2015-05-19 13:21 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.