[PATCH 0/5] Enable PulseAudio in Sato images

[PATCH 0/5] Enable PulseAudio in Sato images

[Tanu Kaskinen]

These patches fix YOCTO#7517.

ALSA configuration is set up so that the default ALSA device is the
PulseAudio plugin, so ALSA applications still work when PulseAudio is
using the audio hardware.

There's one quirk that can cause some confusion sometimes: the
PulseAudio server will auto-exit in 20 seconds after the last client
has disconnected. This shouldn't generally be a problem, because the
server will automatically start again when the next client tries to
connect. On a more "normal" system PulseAudio would not exit until the
user login session has terminated, but it seems that the graphical
session in Sato doesn't register as a session in ConsoleKit, so
PulseAudio doesn't know when the session ends.

Tanu Kaskinen (5):
  alsa-plugins: initial recipe
  pulseaudio: client-conf: Add allow-autospawn-for-root
  pulseaudio: move client.conf to a separate package
  pulseaudio-client-conf-sato: initial recipe
  packagegroup-core-x11-sato: add PulseAudio

 .../recipes-multimedia/alsa/alsa-plugins_1.0.29.bb | 81 +++++++++++++++++++
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc  | 20 +++--
 ...-client-conf-Add-allow-autospawn-for-root.patch | 92 ++++++++++++++++++++++
 .../pulseaudio/pulseaudio_6.0.bb                   |  1 +
 .../packagegroups/packagegroup-core-x11-sato.bb    |  2 +
 .../pulseaudio-client-conf-sato/client.conf        |  7 ++
 .../pulseaudio-client-conf-sato_1.bb               | 20 +++++
 7 files changed, 216 insertions(+), 7 deletions(-)
 create mode 100644 meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb
 create mode 100644 meta/recipes-multimedia/pulseaudio/pulseaudio/0001-client-conf-Add-allow-autospawn-for-root.patch
 create mode 100644 meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato/client.conf
 create mode 100644 meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato_1.bb

-- 
1.9.3

[PATCH 1/5] alsa-plugins: initial recipe

[Tanu Kaskinen]

When PulseAudio is installed, alsa-plugins is needed to provide
compatibility for ALSA applications.

The dependencies are set up so that pulseaudio-server depends on
alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
on the PulseAudio plugins. This should make the ALSA->PulseAudio
compatibility configuration work out of the box, while leaving the
PulseAudio specific configuration out on systems that don't have
pulseaudio-server installed.

Signed-off-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
---
 .../recipes-multimedia/alsa/alsa-plugins_1.0.29.bb | 81 ++++++++++++++++++++++
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |  5 ++
 2 files changed, 86 insertions(+)
 create mode 100644 meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb

diff --git a/meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb b/meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb
new file mode 100644
index 0000000..ffdaef9
--- /dev/null
+++ b/meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb
@@ -0,0 +1,81 @@
+DESCRIPTION = "ALSA Plugins"
+HOMEPAGE = "http://alsa-project.org"
+SECTION = "multimedia"
+
+# The primary license of alsa-plugins is LGPLv2.1.
+# 
+# m4/attributes.m4 is licensed under GPLv2+. m4/attributes.m4 is part of the
+# build system, and doesn't affect the licensing of the build result.
+#
+# The samplerate plugin source code is licensed under GPLv2+ to be consistent
+# with the libsamplerate license.
+LICENSE = "LGPLv2.1 & GPLv2+"
+LIC_FILES_CHKSUM = "\
+        file://COPYING;md5=7fbc338309ac38fefcd64b04bb903e34 \
+        file://COPYING.GPL;md5=94d55d512a9ba36caa9b7df079bae19f \
+        file://m4/attributes.m4;endline=33;md5=b25958da44c02231e3641f1bccef53eb \
+        file://rate/rate_samplerate.c;endline=19;md5=f3d3ce0b189846a486517d97a854b276 \
+"
+
+SRC_URI = "ftp://ftp.alsa-project.org/pub/plugins/${BP}.tar.bz2"
+SRC_URI[md5sum] = "a66797b4471e3cbe96575207bfbe252c"
+SRC_URI[sha256sum] = "325d85cac285f632b83e0191ae3f348bad03c1f007b937042f164abb81ea6532"
+
+DEPENDS += "alsa-lib"
+
+inherit autotools pkgconfig
+
+PACKAGECONFIG ??= "\
+        samplerate \
+        speex \
+        ${@bb.utils.contains('DISTRO_FEATURES', 'pulseaudio', 'pulseaudio', '', d)} \
+"
+PACKAGECONFIG[avcodec] = "--enable-avcodec,--disable-avcodec,libav"
+PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
+PACKAGECONFIG[maemo-plugin] = "--enable-maemo-plugin,--disable-maemo-plugin"
+PACKAGECONFIG[maemo-resource-manager] = "--enable-maemo-resource-manager,--disable-maemo-resource-manager,dbus"
+PACKAGECONFIG[pulseaudio] = "--enable-pulseaudio,--disable-pulseaudio,pulseaudio"
+PACKAGECONFIG[samplerate] = "--enable-samplerate,--disable-samplerate,libsamplerate0"
+PACKAGECONFIG[speex] = "--with-speex=lib,--with-speex=no,speex"
+
+PACKAGES += "alsa-plugins-pulseaudio-conf"
+
+PACKAGES_DYNAMIC = "^libasound-module-.*"
+
+python populate_packages_prepend() {
+    plugindir = bb.data.expand('${libdir}/alsa-lib/', d)
+    do_split_packages(d, plugindir, '^libasound_module_(.*)\.so$', 'libasound-module-%s', 'Alsa plugin for %s', extra_depends='')
+}
+
+do_install_append() {
+	# We use the example as is, so just drop the .example suffix.
+	mv ${D}${datadir}/alsa/alsa.conf.d/99-pulseaudio-default.conf.example ${D}${datadir}/alsa/alsa.conf.d/99-pulseaudio-default.conf
+}
+
+FILES_${PN}-dbg += "${libdir}/alsa-lib/.debug"
+FILES_${PN}-dev += "${libdir}/alsa-lib/*.la"
+
+# 50-pulseaudio.conf defines a device named "pulse" that applications can use
+# if they explicitly want to use the PulseAudio plugin.
+# 99-pulseaudio-default.conf configures the "default" device to use the
+# PulseAudio plugin.
+FILES_${PN}-pulseaudio-conf += "\
+        ${datadir}/alsa/alsa.conf.d/50-pulseaudio.conf \
+        ${datadir}/alsa/alsa.conf.d/99-pulseaudio-default.conf \
+"
+
+# The resampler plugins create some symlinks, which have to be added to FILES
+# manually, since do_split_packages() rejects symlinks. The symlinks also cause
+# QA errors, but those errors are false positives, so we disable the QA checks.
+FILES_libasound-module-rate-lavcrate += "${libdir}/alsa-lib/*rate_lavcrate_*.so"
+FILES_libasound-module-rate-samplerate += "${libdir}/alsa-lib/*rate_samplerate_*.so"
+FILES_libasound-module-rate-speexrate += "${libdir}/alsa-lib/*rate_speexrate_*.so"
+INSANE_SKIP_libasound-module-rate-lavcrate = "dev-so"
+INSANE_SKIP_libasound-module-rate-samplerate = "dev-so"
+INSANE_SKIP_libasound-module-rate-speexrate = "dev-so"
+
+RDEPENDS_${PN}-pulseaudio-conf += "\
+        libasound-module-conf-pulse \
+        libasound-module-ctl-pulse \
+        libasound-module-pcm-pulse \
+"
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index d6ddc3b..44aabea 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -149,6 +149,11 @@ RDEPENDS_pulseaudio-server = " \
     pulseaudio-module-role-cork \
     pulseaudio-module-switch-on-port-available"
 
+# If the server is installed, it's usually desirable to make alsa applications
+# use PulseAudio. alsa-plugins-pulseaudio-conf will install the configuration
+# that makes the PulseAudio plugin the default alsa device.
+RDEPENDS_pulseaudio-server += "alsa-plugins-pulseaudio-conf"
+
 RDEPENDS_pulseaudio-module-console-kit =+ "consolekit"
 RDEPENDS_pulseaudio-misc += "pulseaudio-module-cli-protocol-unix"
 
-- 
1.9.3

[PATCH 2/5] pulseaudio: client-conf: Add allow-autospawn-for-root

[Tanu Kaskinen]

This is related to enabling PulseAudio in Sato images. Sato doesn't
have regular users; the graphical session is run as root. PulseAudio
disables autospawning for root, but in Sato that's not the desired
behaviour. This patch allows autospawning to be enabled for root in
systems where that makes sense.

Signed-off-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
---
 ...-client-conf-Add-allow-autospawn-for-root.patch | 92 ++++++++++++++++++++++
 .../pulseaudio/pulseaudio_6.0.bb                   |  1 +
 2 files changed, 93 insertions(+)
 create mode 100644 meta/recipes-multimedia/pulseaudio/pulseaudio/0001-client-conf-Add-allow-autospawn-for-root.patch

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-client-conf-Add-allow-autospawn-for-root.patch b/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-client-conf-Add-allow-autospawn-for-root.patch
new file mode 100644
index 0000000..d19eb7c
--- /dev/null
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio/0001-client-conf-Add-allow-autospawn-for-root.patch
@@ -0,0 +1,92 @@
+From 1cb5647f76dc8cd7bacbce2a64fac9e6c2dc3b16 Mon Sep 17 00:00:00 2001
+From: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
+Date: Tue, 28 Apr 2015 14:32:43 +0300
+Subject: [PATCH] client-conf: Add allow-autospawn-for-root
+
+Usually autospawning for root is a bad idea, since it can easily
+interfere with other users' PulseAudio instances, but in embedded
+environments where only root exists, autospawning is fine.
+
+Upstream-Status: Submitted [http://thread.gmane.org/gmane.comp.audio.pulseaudio.general/23549]
+
+Signed-off-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
+---
+ man/pulse-client.conf.5.xml.in | 9 +++++++++
+ src/pulse/client-conf.c        | 1 +
+ src/pulse/client-conf.h        | 1 +
+ src/pulse/client.conf.in       | 1 +
+ src/pulse/context.c            | 2 +-
+ 5 files changed, 13 insertions(+), 1 deletion(-)
+
+diff --git a/man/pulse-client.conf.5.xml.in b/man/pulse-client.conf.5.xml.in
+index 1002dbe..0058490 100644
+--- a/man/pulse-client.conf.5.xml.in
++++ b/man/pulse-client.conf.5.xml.in
+@@ -71,6 +71,15 @@ License along with PulseAudio; if not, see <http://www.gnu.org/licenses/>.
+     </option>
+ 
+     <option>
++      <p><opt>allow-autospawn-for-root=</opt> Allow autospawning also for root.
++      Takes a boolean value, defaults to <opt>no</opt>. If the <opt>autospawn
++      </opt> option is disabled, this option has no effect. Autospawning for
++      root is disabled by default, because running PulseAudio as root will
++      interfere with regular users' PulseAudio instances. This option should be
++      enabled only in environments where there are no regular users at all.</p>
++    </option>
++
++    <option>
+       <p><opt>daemon-binary=</opt> Path to the PulseAudio daemon to
+       run when autospawning. Defaults to a path configured at compile
+       time.</p>
+diff --git a/src/pulse/client-conf.c b/src/pulse/client-conf.c
+index 83331f8..0474583 100644
+--- a/src/pulse/client-conf.c
++++ b/src/pulse/client-conf.c
+@@ -138,6 +138,7 @@ void pa_client_conf_load(pa_client_conf *c, bool load_from_x11, bool load_from_e
+         { "default-server",         pa_config_parse_string,   &c->default_server, NULL },
+         { "default-dbus-server",    pa_config_parse_string,   &c->default_dbus_server, NULL },
+         { "autospawn",              pa_config_parse_bool,     &c->autospawn, NULL },
++        { "allow-autospawn-for-root", pa_config_parse_bool,   &c->allow_autospawn_for_root, NULL },
+         { "cookie-file",            pa_config_parse_string,   &c->cookie_file_from_client_conf, NULL },
+         { "disable-shm",            pa_config_parse_bool,     &c->disable_shm, NULL },
+         { "enable-shm",             pa_config_parse_not_bool, &c->disable_shm, NULL },
+diff --git a/src/pulse/client-conf.h b/src/pulse/client-conf.h
+index eac705a..131393a 100644
+--- a/src/pulse/client-conf.h
++++ b/src/pulse/client-conf.h
+@@ -38,6 +38,7 @@ typedef struct pa_client_conf {
+     char *cookie_file_from_application;
+     char *cookie_file_from_client_conf;
+     bool autospawn, disable_shm, auto_connect_localhost, auto_connect_display;
++    bool allow_autospawn_for_root;
+     size_t shm_size;
+ } pa_client_conf;
+ 
+diff --git a/src/pulse/client.conf.in b/src/pulse/client.conf.in
+index 26b7790..69830ef 100644
+--- a/src/pulse/client.conf.in
++++ b/src/pulse/client.conf.in
+@@ -23,6 +23,7 @@
+ ; default-dbus-server =
+ 
+ ; autospawn = yes
++; allow-autospawn-for-root = no
+ ; daemon-binary = @PA_BINARY@
+ ; extra-arguments = --log-target=syslog
+ 
+diff --git a/src/pulse/context.c b/src/pulse/context.c
+index 4bc445f..d6c3f6d 100644
+--- a/src/pulse/context.c
++++ b/src/pulse/context.c
+@@ -976,7 +976,7 @@ int pa_context_connect(
+     if (!(flags & PA_CONTEXT_NOAUTOSPAWN) && c->conf->autospawn) {
+ 
+ #ifdef HAVE_GETUID
+-        if (getuid() == 0)
++        if (!c->conf->allow_autospawn_for_root && getuid() == 0)
+             pa_log_debug("Not doing autospawn since we are root.");
+         else {
+             c->do_autospawn = true;
+-- 
+1.9.3
+
diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_6.0.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_6.0.bb
index fb33c7c..465b224 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio_6.0.bb
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_6.0.bb
@@ -2,6 +2,7 @@ require pulseaudio.inc
 
 SRC_URI = "http://freedesktop.org/software/pulseaudio/releases/${BP}.tar.xz \
            file://0001-padsp-Make-it-compile-on-musl.patch \
+           file://0001-client-conf-Add-allow-autospawn-for-root.patch \
            file://volatiles.04_pulse \
 "
 SRC_URI[md5sum] = "b691e83b7434c678dffacfa3a027750e"
-- 
1.9.3

[PATCH 3/5] pulseaudio: move client.conf to a separate package

[Tanu Kaskinen]

Putting client.conf to a separate package allows other recipes to
provide a replacement package when a custom version of client.conf is
needed (Sato will need that to make autospawning work for root).

Signed-off-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
---
 meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
index 44aabea..d99dbd2 100644
--- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
+++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
@@ -72,7 +72,8 @@ USERADD_PARAM_pulseaudio-server = "--system --home /var/run/pulse \
 # adding the console-kit module to an image, we also get the necessary
 # consolekit package produced.
 PACKAGES =+ "libpulsecore libpulsecommon libpulse libpulse-simple libpulse-mainloop-glib \
-             pulseaudio-server pulseaudio-misc ${@bb.utils.contains('PACKAGECONFIG', 'x11', 'pulseaudio-module-console-kit', '', d)}"
+             pulseaudio-client-conf pulseaudio-server pulseaudio-misc \
+             ${@bb.utils.contains('PACKAGECONFIG', 'x11', 'pulseaudio-module-console-kit', '', d)}"
 
 #upgrade path:
 RREPLACES_pulseaudio-server = "libpulse-bin libpulse-conf"
@@ -81,11 +82,7 @@ PACKAGES_DYNAMIC += "^pulseaudio-lib-.* ^pulseaudio-module-.*"
 
 FILES_libpulsecore = "${libdir}/libpulsecore*.so"
 FILES_libpulsecommon = "${libdir}/pulseaudio/libpulsecommon*.so"
-
-# client.conf configures the behaviour of libpulse, so it belongs in the same
-# package.
-FILES_libpulse = "${libdir}/libpulse.so.* ${sysconfdir}/pulse/client.conf"
-
+FILES_libpulse = "${libdir}/libpulse.so.*"
 FILES_libpulse-simple = "${libdir}/libpulse-simple.so.*"
 FILES_libpulse-mainloop-glib = "${libdir}/libpulse-mainloop-glib.so.*"
 
@@ -94,6 +91,7 @@ FILES_${PN}-dbg += "${libexecdir}/pulse/.debug \
 FILES_${PN}-dev += "${libdir}/pulse-${PV}/modules/*.la ${datadir}/vala ${libdir}/cmake"   
 FILES_${PN}-conf = "${sysconfdir}"
 FILES_${PN}-bin += "${sysconfdir}/default/volatiles/volatiles.04_pulse"
+FILES_${PN}-client-conf = "${sysconfdir}/pulse/client.conf"
 FILES_${PN}-server = "${bindir}/pulseaudio ${bindir}/start-* ${sysconfdir} ${bindir}/pactl */udev/rules.d/*.rules"
 
 #SYSTEMD_PACKAGES = "${PN}-server"
@@ -104,7 +102,7 @@ FILES_${PN}-misc = "${bindir}/* ${libdir}/pulseaudio/libpulsedsp.so"
 # Allow the pulseaudio package to be created empty as a placeholder (-dbg and -dev depend on it)
 ALLOW_EMPTY_${PN} = "1"
 
-CONFFILES_libpulse = "${sysconfdir}/pulse/client.conf"
+CONFFILES_${PN}-client-conf = "${sysconfdir}/pulse/client.conf"
 
 CONFFILES_pulseaudio-server = "\ 
   ${sysconfdir}/pulse/default.pa \
@@ -126,6 +124,9 @@ python populate_packages_prepend() {
     do_split_packages(d, plugindir, '^lib(.*)\.so$', 'pulseaudio-lib-%s', 'PulseAudio library for %s', extra_depends='', prepend=True)
 }
 
+# client.conf controls libpulse behaviour, hence the dependency.
+REDPENDS_libpulse += "pulseaudio-client-conf"
+
 RDEPENDS_pulseaudio-server = " \
     pulseaudio-module-filter-apply \
     pulseaudio-module-filter-heuristics \
-- 
1.9.3

[PATCH 4/5] pulseaudio-client-conf-sato: initial recipe

[Tanu Kaskinen]

This recipe is related to enabling PulseAudio in Sato images. We will
rely on PulseAudio's autospawn feature to automatically start the
daemon. The graphical session in Sato runs under root, however, and
PulseAudio disables autospawning for root by default. We provide a
custom client.conf in Sato to change that default setting.

Signed-off-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
---
 .../pulseaudio-client-conf-sato/client.conf          |  7 +++++++
 .../pulseaudio-sato/pulseaudio-client-conf-sato_1.bb | 20 ++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato/client.conf
 create mode 100644 meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato_1.bb

diff --git a/meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato/client.conf b/meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato/client.conf
new file mode 100644
index 0000000..97492e7
--- /dev/null
+++ b/meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato/client.conf
@@ -0,0 +1,7 @@
+# We rely on PulseAudio's autospawn feature to automatically start the daemon
+# in Sato. The graphical session in Sato runs under root, however, and
+# PulseAudio disables autospawning for root by default. In a normal setup it's
+# not desirable to autospawn for root, because it can easily interfere with
+# other users' PulseAudio instances, but in Sato there are no other users, so
+# it's OK to enable this in Sato.
+allow-autospawn-for-root = yes
diff --git a/meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato_1.bb b/meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato_1.bb
new file mode 100644
index 0000000..c0858f6
--- /dev/null
+++ b/meta/recipes-sato/pulseaudio-sato/pulseaudio-client-conf-sato_1.bb
@@ -0,0 +1,20 @@
+SUMMARY = "/etc/pulse/client.conf tailored for Sato"
+SECTION = "multimedia"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690 \
+                    file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+SRC_URI = "file://client.conf"
+S = "${WORKDIR}"
+
+do_install() {
+	install -d ${D}${sysconfdir}/pulse
+	install -m 0644 ${S}/client.conf ${D}${sysconfdir}/pulse
+}
+
+RCONFLICTS_${PN} = "pulseaudio-client-conf"
+RPROVIDES_${PN} = "pulseaudio-client-conf"
+RREPLACES_${PN} = "pulseaudio-client-conf"
+
+FILES_${PN} = "${sysconfdir}/pulse/client.conf"
+CONFFILES_${PN} = "${sysconfdir}/pulse/client.conf"
-- 
1.9.3

[PATCH 5/5] packagegroup-core-x11-sato: add PulseAudio

[Tanu Kaskinen]

This enables PulseAudio in the Sato images.

[YOCTO #7517]

Signed-off-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
---
 meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb b/meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb
index 2d046c4..04d1e99 100644
--- a/meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb
+++ b/meta/recipes-sato/packagegroups/packagegroup-core-x11-sato.bb
@@ -39,6 +39,8 @@ RDEPENDS_${PN}-base = "\
     libsdl \
     ${NETWORK_MANAGER} \
     udev-extraconf \
+    pulseaudio-server \
+    pulseaudio-client-conf-sato \
     "
 
 # pcmanfm doesn't work on mips
-- 
1.9.3

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On 18 May 2015 at 13:40, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
wrote:

> When PulseAudio is installed, alsa-plugins is needed to provide
> compatibility for ALSA applications.
>
> The dependencies are set up so that pulseaudio-server depends on
> alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
> on the PulseAudio plugins. This should make the ALSA->PulseAudio
> compatibility configuration work out of the box, while leaving the
> PulseAudio specific configuration out on systems that don't have
> pulseaudio-server installed.
>

What layer did this recipe originally come from?

Ross

[-- Attachment #2: Type: text/html, Size: 1070 bytes --]

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On 18 May 2015 at 13:40, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
wrote:

> +# The resampler plugins create some symlinks, which have to be added to
> FILES
> +# manually, since do_split_packages() rejects symlinks. The symlinks also
> cause
> +# QA errors, but those errors are false positives, so we disable the QA
> checks.
>

Not true, there's an allow_symlink (default False) option to
do_split_packages, so this can be cleaned up.

Assuming that those symlinks are versioning (and so pointless for loadable
modules), a neater fix might be to patch in libtool -avoid-version.

Ross

[-- Attachment #2: Type: text/html, Size: 1084 bytes --]

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 832 bytes --]

On 19 May 2015 at 15:31, Burton, Ross <ross.burton@intel.com> wrote:

> On 18 May 2015 at 13:40, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
> wrote:
>
>> +# The resampler plugins create some symlinks, which have to be added to
>> FILES
>> +# manually, since do_split_packages() rejects symlinks. The symlinks
>> also cause
>> +# QA errors, but those errors are false positives, so we disable the QA
>> checks.
>>
>
> Not true, there's an allow_symlink (default False) option to
> do_split_packages, so this can be cleaned up.
>
> Assuming that those symlinks are versioning (and so pointless for loadable
> modules), a neater fix might be to patch in libtool -avoid-version.
>

Investigate *before* sending, Ross.

Just pass allow_links=True to do_split_packages() and all of this can be
deleted.

Ross

[-- Attachment #2: Type: text/html, Size: 1629 bytes --]

Re: [PATCH 3/5] pulseaudio: move client.conf to a separate package

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 162 bytes --]

On 18 May 2015 at 13:40, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
wrote:

> +REDPENDS_libpulse += "pulseaudio-client-conf"
>

Typo, RDEPENDS.

Ross

[-- Attachment #2: Type: text/html, Size: 587 bytes --]

Re: [PATCH 4/5] pulseaudio-client-conf-sato: initial recipe

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

On 18 May 2015 at 13:40, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
wrote:

> +LIC_FILES_CHKSUM =
> "file://${COREBASE}/LICENSE;md5=4d92cd373abda3937c2bc47fbc49d690 \
> +
> file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
>

I understand that you just copied existing recipes, but I never understood
why COREBASE/LICENSE is used here - it just points to other licenses.

As this file is MIT, just use COPYING.MIT.

Also, there's an allarch class you can inherit in this as the file is
architecture-agnostic.

Ross

[-- Attachment #2: Type: text/html, Size: 1139 bytes --]

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Tanu Kaskinen]

On Tue, 2015-05-19 at 15:27 +0100, Burton, Ross wrote:
> 
> On 18 May 2015 at 13:40, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
> wrote:
>         When PulseAudio is installed, alsa-plugins is needed to
>         provide
>         compatibility for ALSA applications.
>         
>         The dependencies are set up so that pulseaudio-server depends
>         on
>         alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf
>         depends
>         on the PulseAudio plugins. This should make the
>         ALSA->PulseAudio
>         compatibility configuration work out of the box, while leaving
>         the
>         PulseAudio specific configuration out on systems that don't
>         have
>         pulseaudio-server installed.
> 
> What layer did this recipe originally come from?

meta-guacamayo and meta-webos were used as references when writing the
recipe. It's not a straight copy of either.

-- 
Tanu

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 286 bytes --]

On 19 May 2015 at 16:01, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
wrote:

> meta-guacamayo and meta-webos were used as references when writing the
> recipe. It's not a straight copy of either.
>

I was hoping you'd say that.  :)  Please mention that in the commit.

Ross

[-- Attachment #2: Type: text/html, Size: 709 bytes --]

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Tanu Kaskinen]

On Tue, 2015-05-19 at 15:42 +0100, Burton, Ross wrote:
> 
> On 19 May 2015 at 15:31, Burton, Ross <ross.burton@intel.com> wrote:
>         On 18 May 2015 at 13:40, Tanu Kaskinen
>         <tanu.kaskinen@linux.intel.com> wrote:
>                 +# The resampler plugins create some symlinks, which
>                 have to be added to FILES
>                 +# manually, since do_split_packages() rejects
>                 symlinks. The symlinks also cause
>                 +# QA errors, but those errors are false positives, so
>                 we disable the QA checks.
>                 
>         
>         Not true, there's an allow_symlink (default False) option to
>         do_split_packages, so this can be cleaned up.
>         
>         
>         Assuming that those symlinks are versioning (and so pointless
>         for loadable modules), a neater fix might be to patch in
>         libtool -avoid-version.
> 
> Investigate *before* sending, Ross.
> 
> 
> Just pass allow_links=True to do_split_packages() and all of this can
> be deleted.

Thanks, I'll do that.

-- 
Tanu

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1185 bytes --]

On 18 May 2015 at 13:40, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
wrote:

> When PulseAudio is installed, alsa-plugins is needed to provide
> compatibility for ALSA applications.
>
> The dependencies are set up so that pulseaudio-server depends on
> alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
> on the PulseAudio plugins. This should make the ALSA->PulseAudio
> compatibility configuration work out of the box, while leaving the
> PulseAudio specific configuration out on systems that don't have
> pulseaudio-server installed.
>

 * satisfy_dependencies_for: Cannot satisfy the following dependencies for
alsa-plugins-dev:
 * alsa-plugins (= 1.0.29-r0) *
 * opkg_install_cmd: Cannot install package alsa-plugins-dev.

There's a default RDEPENDS_${PN}-dev = ${PN}, but as alsa-plugins doesn't
exist that isn't very useful.  Then again shipping the .la files for the
loadable modules isn't very useful either (Linux doesn't need them to load
modules, and nothing will link against them).

So, instead of:

+FILES_${PN}-dev += "${libdir}/alsa-lib/*.la"

we should just delete the .la files in the do_install_append().

Ross

[-- Attachment #2: Type: text/html, Size: 2529 bytes --]

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Tanu Kaskinen]

On Wed, 2015-05-20 at 10:00 +0100, Burton, Ross wrote:
> 
> On 18 May 2015 at 13:40, Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
> wrote:
>         When PulseAudio is installed, alsa-plugins is needed to
>         provide
>         compatibility for ALSA applications.
>         
>         The dependencies are set up so that pulseaudio-server depends
>         on
>         alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf
>         depends
>         on the PulseAudio plugins. This should make the
>         ALSA->PulseAudio
>         compatibility configuration work out of the box, while leaving
>         the
>         PulseAudio specific configuration out on systems that don't
>         have
>         pulseaudio-server installed.
> 
>  * satisfy_dependencies_for: Cannot satisfy the following dependencies
> for alsa-plugins-dev:
>  * alsa-plugins (= 1.0.29-r0) * 
>  * opkg_install_cmd: Cannot install package alsa-plugins-dev.

Oops! In the future, when adding any new packages, I probably should try
building images with those packages installed.

> There's a default RDEPENDS_${PN}-dev = ${PN}, but as alsa-plugins
> doesn't exist that isn't very useful.  Then again shipping the .la
> files for the loadable modules isn't very useful either (Linux doesn't
> need them to load modules, and nothing will link against them).  
> 
> 
> So, instead of:
> 
> 
> +FILES_${PN}-dev += "${libdir}/alsa-lib/*.la"
> 
> 
> 
> we should just delete the .la files in the do_install_append().

Right, the -dev package is obviously pointless in this case. I could
have realized that just by thinking a bit more while writing the
recipe...

-- 
Tanu

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Tanu Kaskinen]

On Tue, 2015-05-19 at 18:06 +0300, Tanu Kaskinen wrote:
> On Tue, 2015-05-19 at 15:42 +0100, Burton, Ross wrote:
> > 
> > On 19 May 2015 at 15:31, Burton, Ross <ross.burton@intel.com> wrote:
> >         On 18 May 2015 at 13:40, Tanu Kaskinen
> >         <tanu.kaskinen@linux.intel.com> wrote:
> >                 +# The resampler plugins create some symlinks, which
> >                 have to be added to FILES
> >                 +# manually, since do_split_packages() rejects
> >                 symlinks. The symlinks also cause
> >                 +# QA errors, but those errors are false positives, so
> >                 we disable the QA checks.
> >                 
> >         
> >         Not true, there's an allow_symlink (default False) option to
> >         do_split_packages, so this can be cleaned up.
> >         
> >         
> >         Assuming that those symlinks are versioning (and so pointless
> >         for loadable modules), a neater fix might be to patch in
> >         libtool -avoid-version.
> > 
> > Investigate *before* sending, Ross.
> > 
> > 
> > Just pass allow_links=True to do_split_packages() and all of this can
> > be deleted.
> 
> Thanks, I'll do that.

Actually, no, I won't do that. I don't want the symlinks to go to
separate packages, they should be shipped in the same package that
contains the real plugin file.

-- 
Tanu

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Richard Purdie]

On Mon, 2015-05-18 at 15:40 +0300, Tanu Kaskinen wrote:
> When PulseAudio is installed, alsa-plugins is needed to provide
> compatibility for ALSA applications.
> 
> The dependencies are set up so that pulseaudio-server depends on
> alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
> on the PulseAudio plugins. This should make the ALSA->PulseAudio
> compatibility configuration work out of the box, while leaving the
> PulseAudio specific configuration out on systems that don't have
> pulseaudio-server installed.
> 
> Signed-off-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
> ---
>  .../recipes-multimedia/alsa/alsa-plugins_1.0.29.bb | 81 ++++++++++++++++++++++
>  meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |  5 ++
>  2 files changed, 86 insertions(+)
>  create mode 100644 meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb

Running this through the autobuilder revealed:
https://autobuilder.yoctoproject.org/main/builders/nightly-ipk/builds/303/steps/BuildImages/logs/stdio
which I'm guessing comes from this patch but I haven't bisected.

Cheers,

Richard

Re: [PATCH 1/5] alsa-plugins: initial recipe

[Tanu Kaskinen]

On Wed, 2015-05-20 at 13:07 +0100, Richard Purdie wrote:
> On Mon, 2015-05-18 at 15:40 +0300, Tanu Kaskinen wrote:
> > When PulseAudio is installed, alsa-plugins is needed to provide
> > compatibility for ALSA applications.
> > 
> > The dependencies are set up so that pulseaudio-server depends on
> > alsa-plugins-pulseaudio-conf, and alsa-plugins-pulseaudio-conf depends
> > on the PulseAudio plugins. This should make the ALSA->PulseAudio
> > compatibility configuration work out of the box, while leaving the
> > PulseAudio specific configuration out on systems that don't have
> > pulseaudio-server installed.
> > 
> > Signed-off-by: Tanu Kaskinen <tanu.kaskinen@linux.intel.com>
> > ---
> >  .../recipes-multimedia/alsa/alsa-plugins_1.0.29.bb | 81 ++++++++++++++++++++++
> >  meta/recipes-multimedia/pulseaudio/pulseaudio.inc  |  5 ++
> >  2 files changed, 86 insertions(+)
> >  create mode 100644 meta/recipes-multimedia/alsa/alsa-plugins_1.0.29.bb
> 
> Running this through the autobuilder revealed:
> https://autobuilder.yoctoproject.org/main/builders/nightly-ipk/builds/303/steps/BuildImages/logs/stdio
> which I'm guessing comes from this patch but I haven't bisected.

Yep, Ross already complained about the same thing. A fix is forthcoming.

-- 
Tanu