[Qemu-devel] [PATCH] qemu-iotests: Fix 128 if sudo required

[Qemu-devel] [PATCH] qemu-iotests: Fix 128 if sudo required

[Fam Zheng]

If passwordless "sudo" works, use it in the qemu-io cmd.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/qemu-iotests/128 | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/qemu-iotests/128 b/tests/qemu-iotests/128
index 249a865..e2a0f2f 100755
--- a/tests/qemu-iotests/128
+++ b/tests/qemu-iotests/128
@@ -29,6 +29,7 @@ tmp=/tmp/$$
 status=1	# failure is the default!
 
 devname="eiodev$$"
+sudo=""
 
 _setup_eiodev()
 {
@@ -37,6 +38,7 @@ _setup_eiodev()
 		echo "0 $((1024 * 1024 * 1024 / 512)) error" | \
 			$cmd dmsetup create "$devname" 2>/dev/null
 		if [ "$?" -eq 0 ]; then
+			sudo="$cmd"
 			return
 		fi
 	done
@@ -74,7 +76,7 @@ TEST_IMG="/dev/mapper/$devname"
 echo
 echo "== reading from error device =="
 # Opening image should succeed but the read operation should fail
-$QEMU_IO --format "$IMGFMT" --nocache -c "read 0 65536" "$TEST_IMG" | _filter_qemu_io
+$sudo $QEMU_IO --format "$IMGFMT" --nocache -c "read 0 65536" "$TEST_IMG" | _filter_qemu_io
 
 # success, all done
 echo "*** done"
-- 
2.4.1

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix 128 if sudo required

[Stefan Hajnoczi]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

On Tue, May 19, 2015 at 10:46:13AM +0000, Fam Zheng wrote:
> If passwordless "sudo" works, use it in the qemu-io cmd.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
>  tests/qemu-iotests/128 | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Oops, I'm in the group 'disk' on my workstation so I never noticed that
the user running the test may not have permission to access the block
device.

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]

Re: [Qemu-devel] [PATCH] qemu-iotests: Fix 128 if sudo required

[Kevin Wolf]

Am 19.05.2015 um 12:46 hat Fam Zheng geschrieben:
> If passwordless "sudo" works, use it in the qemu-io cmd.
> 
> Signed-off-by: Fam Zheng <famz@redhat.com>

Thanks, applied to the block branch.

Kevin