* [PATCH] clk: fix output format of debugfs/clk_dump
@ 2015-05-19 15:42 Vladimir Zapolskiy
2015-05-19 20:26 ` Stephen Boyd
0 siblings, 1 reply; 3+ messages in thread
From: Vladimir Zapolskiy @ 2015-05-19 15:42 UTC (permalink / raw)
To: Mike Turquette, Stephen Boyd; +Cc: linux-clk
The output format of $(cat /sys/kernel/debug/clk/clk_dump) was
compliant to JSON and Python dictionary type some time ago, but at the
moment a couple of commas are missing, fix it.
Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
---
drivers/clk/clk.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 459ce9d..30be5fb 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -233,8 +233,8 @@ static void clk_dump_one(struct seq_file *s, struct clk_core *c, int level)
seq_printf(s, "\"%s\": { ", c->name);
seq_printf(s, "\"enable_count\": %d,", c->enable_count);
seq_printf(s, "\"prepare_count\": %d,", c->prepare_count);
- seq_printf(s, "\"rate\": %lu", clk_core_get_rate(c));
- seq_printf(s, "\"accuracy\": %lu", clk_core_get_accuracy(c));
+ seq_printf(s, "\"rate\": %lu,", clk_core_get_rate(c));
+ seq_printf(s, "\"accuracy\": %lu,", clk_core_get_accuracy(c));
seq_printf(s, "\"phase\": %d", clk_core_get_phase(c));
}
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: fix output format of debugfs/clk_dump
2015-05-19 15:42 [PATCH] clk: fix output format of debugfs/clk_dump Vladimir Zapolskiy
@ 2015-05-19 20:26 ` Stephen Boyd
2015-05-19 20:30 ` Vladimir Zapolskiy
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Boyd @ 2015-05-19 20:26 UTC (permalink / raw)
To: Vladimir Zapolskiy, Mike Turquette; +Cc: linux-clk
On 05/19/15 08:42, Vladimir Zapolskiy wrote:
> The output format of $(cat /sys/kernel/debug/clk/clk_dump) was
> compliant to JSON and Python dictionary type some time ago, but at the
> moment a couple of commas are missing, fix it.
>
> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Isn't this already fixed in clk-next with 7cb81136d2ef (clk: Fix JSON
output in debugfs, 2015-04-29)?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] clk: fix output format of debugfs/clk_dump
2015-05-19 20:26 ` Stephen Boyd
@ 2015-05-19 20:30 ` Vladimir Zapolskiy
0 siblings, 0 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2015-05-19 20:30 UTC (permalink / raw)
To: Stephen Boyd, Mike Turquette; +Cc: linux-clk
On 19.05.2015 23:26, Stephen Boyd wrote:
> On 05/19/15 08:42, Vladimir Zapolskiy wrote:
>> The output format of $(cat /sys/kernel/debug/clk/clk_dump) was
>> compliant to JSON and Python dictionary type some time ago, but at the
>> moment a couple of commas are missing, fix it.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
>
> Isn't this already fixed in clk-next with 7cb81136d2ef (clk: Fix JSON
> output in debugfs, 2015-04-29)?
>
Ah, great, I overlooked it, thank you for pointing it out, please ignore
my change.
--
With best wishes,
Vladimir
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-05-19 20:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-19 15:42 [PATCH] clk: fix output format of debugfs/clk_dump Vladimir Zapolskiy
2015-05-19 20:26 ` Stephen Boyd
2015-05-19 20:30 ` Vladimir Zapolskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.