* [patch -next] target: double locking typo in core_clear_lun_from_tpg()
@ 2015-05-19 12:04 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-05-19 12:04 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: linux-scsi, target-devel, linux-kernel, kernel-janitors
We accidentally deadlock instead of unlocking.
Fixes: 08d20ff62cde ('target: Acquire lun_entry_mutex during core_disable_device_list_for_node')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 2f4c8fa..20618df 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -433,7 +433,7 @@ void core_clear_lun_from_tpg(struct se_lun *lun, struct se_portal_group *tpg)
core_disable_device_list_for_node(lun, deve, nacl, tpg);
}
- mutex_lock(&nacl->lun_entry_mutex);
+ mutex_unlock(&nacl->lun_entry_mutex);
}
mutex_unlock(&tpg->acl_node_mutex);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [patch -next] target: double locking typo in core_clear_lun_from_tpg()
@ 2015-05-19 12:04 ` Dan Carpenter
0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2015-05-19 12:04 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: linux-scsi, target-devel, linux-kernel, kernel-janitors
We accidentally deadlock instead of unlocking.
Fixes: 08d20ff62cde ('target: Acquire lun_entry_mutex during core_disable_device_list_for_node')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
index 2f4c8fa..20618df 100644
--- a/drivers/target/target_core_device.c
+++ b/drivers/target/target_core_device.c
@@ -433,7 +433,7 @@ void core_clear_lun_from_tpg(struct se_lun *lun, struct se_portal_group *tpg)
core_disable_device_list_for_node(lun, deve, nacl, tpg);
}
- mutex_lock(&nacl->lun_entry_mutex);
+ mutex_unlock(&nacl->lun_entry_mutex);
}
mutex_unlock(&tpg->acl_node_mutex);
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [patch -next] target: double locking typo in core_clear_lun_from_tpg()
2015-05-19 12:04 ` Dan Carpenter
@ 2015-05-19 18:44 ` Nicholas A. Bellinger
-1 siblings, 0 replies; 4+ messages in thread
From: Nicholas A. Bellinger @ 2015-05-19 18:44 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-scsi, target-devel, linux-kernel, kernel-janitors
On Tue, 2015-05-19 at 15:04 +0300, Dan Carpenter wrote:
> We accidentally deadlock instead of unlocking.
>
> Fixes: 08d20ff62cde ('target: Acquire lun_entry_mutex during core_disable_device_list_for_node')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2f4c8fa..20618df 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -433,7 +433,7 @@ void core_clear_lun_from_tpg(struct se_lun *lun, struct se_portal_group *tpg)
>
> core_disable_device_list_for_node(lun, deve, nacl, tpg);
> }
> - mutex_lock(&nacl->lun_entry_mutex);
> + mutex_unlock(&nacl->lun_entry_mutex);
> }
> mutex_unlock(&tpg->acl_node_mutex);
> }
Applied to for-next, and will squash into the original soon.
Thanks Dan!
--nab
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch -next] target: double locking typo in core_clear_lun_from_tpg()
@ 2015-05-19 18:44 ` Nicholas A. Bellinger
0 siblings, 0 replies; 4+ messages in thread
From: Nicholas A. Bellinger @ 2015-05-19 18:44 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-scsi, target-devel, linux-kernel, kernel-janitors
On Tue, 2015-05-19 at 15:04 +0300, Dan Carpenter wrote:
> We accidentally deadlock instead of unlocking.
>
> Fixes: 08d20ff62cde ('target: Acquire lun_entry_mutex during core_disable_device_list_for_node')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2f4c8fa..20618df 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -433,7 +433,7 @@ void core_clear_lun_from_tpg(struct se_lun *lun, struct se_portal_group *tpg)
>
> core_disable_device_list_for_node(lun, deve, nacl, tpg);
> }
> - mutex_lock(&nacl->lun_entry_mutex);
> + mutex_unlock(&nacl->lun_entry_mutex);
> }
> mutex_unlock(&tpg->acl_node_mutex);
> }
Applied to for-next, and will squash into the original soon.
Thanks Dan!
--nab
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-19 18:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-19 12:04 [patch -next] target: double locking typo in core_clear_lun_from_tpg() Dan Carpenter
2015-05-19 12:04 ` Dan Carpenter
2015-05-19 18:44 ` Nicholas A. Bellinger
2015-05-19 18:44 ` Nicholas A. Bellinger
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.