* [PATCH 4/8] serial: sh-sci: Use SCIF_DR instead of hardcoded 1
@ 2015-05-20 18:06 Geert Uytterhoeven
2015-05-23 19:09 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-05-20 18:06 UTC (permalink / raw)
To: linux-sh
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/tty/serial/sh-sci.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
index 21c07c6cb0cd2220..73f4115159a7fbbc 100644
--- a/drivers/tty/serial/sh-sci.c
+++ b/drivers/tty/serial/sh-sci.c
@@ -960,7 +960,8 @@ static irqreturn_t sci_rx_interrupt(int irq, void *ptr)
}
serial_port_out(port, SCSCR, scr);
/* Clear current interrupt */
- serial_port_out(port, SCxSR, ssr & ~(1 | SCxSR_RDxF(port)));
+ serial_port_out(port, SCxSR,
+ ssr & ~(SCIF_DR | SCxSR_RDxF(port)));
dev_dbg(port->dev, "Rx IRQ %lu: setup t-out in %u jiffies\n",
jiffies, s->rx_timeout);
mod_timer(&s->rx_timer, jiffies + s->rx_timeout);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/8] serial: sh-sci: Use SCIF_DR instead of hardcoded 1
2015-05-20 18:06 [PATCH 4/8] serial: sh-sci: Use SCIF_DR instead of hardcoded 1 Geert Uytterhoeven
@ 2015-05-23 19:09 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2015-05-23 19:09 UTC (permalink / raw)
To: linux-sh
Hi Geert,
Thank you for the patch.
On Wednesday 20 May 2015 20:06:10 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/tty/serial/sh-sci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c
> index 21c07c6cb0cd2220..73f4115159a7fbbc 100644
> --- a/drivers/tty/serial/sh-sci.c
> +++ b/drivers/tty/serial/sh-sci.c
> @@ -960,7 +960,8 @@ static irqreturn_t sci_rx_interrupt(int irq, void *ptr)
> }
> serial_port_out(port, SCSCR, scr);
> /* Clear current interrupt */
> - serial_port_out(port, SCxSR, ssr & ~(1 | SCxSR_RDxF(port)));
> + serial_port_out(port, SCxSR,
> + ssr & ~(SCIF_DR | SCxSR_RDxF(port)));
> dev_dbg(port->dev, "Rx IRQ %lu: setup t-out in %u jiffies\n",
> jiffies, s->rx_timeout);
> mod_timer(&s->rx_timer, jiffies + s->rx_timeout);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-23 19:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-20 18:06 [PATCH 4/8] serial: sh-sci: Use SCIF_DR instead of hardcoded 1 Geert Uytterhoeven
2015-05-23 19:09 ` Laurent Pinchart
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.