All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
@ 2015-05-25 23:59 Chong Li
  2015-05-26  8:59 ` Ian Campbell
  0 siblings, 1 reply; 12+ messages in thread
From: Chong Li @ 2015-05-25 23:59 UTC (permalink / raw)
  To: xen-devel
  Cc: Wei Liu, George Dunlap, dario.faggioli, Ian Jackson,
	Ian Campbell, Meng Xu, Jan Beulich, Chong Li, Dagaen Golomb

[Goal]
The current xl sched-rtds tool can only set the VCPUs of a domain to
the same parameter
although the scheduler supports VCPUs with different parameters. This
patchset is to
enable xl sched-rtds tool to configure the VCPUs of a domain with
different parameters.

This per-VCPU settings can be used in many scenarios. For example,
based on Dario's statement in our pervious
discussion(http://lists.xen.org/archives/html/xen-devel/2014-09/msg00423.html),
if there are two real-time applications, which have different timing
requirements, running in a multi-VCPU guest domain, it is beneficial
to pin these two applications to two seperate VCPUs with different
scheduling parameters.

What this patchset includes is a wanted and planned feature for RTDS
scheudler(http://wiki.xenproject.org/wiki/RTDS-Based-Scheduler) in Xen
4.6. The interface design of the xl sched-rtds tool is based on Meng's
previous discussion with Dario, George and
Wei(http://lists.xen.org/archives/html/xen-devel/2015-02/msg02606.html).
Basically, there are two main changes:

1) in xl, we create an array that records all VCPUs whose parameters
are about to change.

2) in libxl, we receive the array and call different xc functions to handle it.

3) in xen and libxc, we use
XEN_DOMCTL_SCHEDOP_getvcpuinfo/putvcpuinfo(introduced by this
patchset) as the hypercall for per-VCPU operations(get/set method).


[Usage]
With this patchset in use, xl sched-rtds tool can:

1) show the budget and period of each VCPU of each domain, by using
"xl sched-rtds" command. An example would be like:

# xl sched-rtds
Cpupool Pool-0: sched=RTDS
Name                                ID VCPU    Period    Budget
Domain-0                             0    0     10000      4000
vm1                                  1    0      1000       500
vm1                                  1    1      2000      1000
vm2                                  2    0      4000      4000
vm2                                  2    1     10000      4000

For compatibility reason, our toolstack still supports showing the
domain-wise budget and period, by using "xl sched-rtds -o" command.
The output would be like:

# xl sched-rtds -o
Cpupool Pool-0: sched=RTDS
Name                                ID    Period    Budget
Domain-0                             0     10000      4000
vm1                                  1      1000       500
vm2                                  2      4000      4000

This command should only be used when all vcpus of a domain have the
same parameters, otherwise the output
is pointless. The period and budget shown in the output are equal to
the parameters of the first
VCPU of each domain.


2) show the budget and period of each VCPU of a specific domain, by using,
e.g., "xl sched-rtds -d vm1" command. The output would be like:

# xl sched-rtds -d vm1
Name                                ID VCPU    Period    Budget
vm1                                  1    0      1000       500
vm1                                  1    1      2000      1000

To show the domain-wise budget and period, please use, e.g.,"xl
sched-rtds -d vm1 -o" command. The output
would be:

# xl sched-rtds -d vm1 -o
Name                                ID    Period    Budget
vm1                                  1      1000       500

Again, please use this command when all VCPUs of a domain have the
same parameters.

3) set the budget and period of each VCPU of a specific domain, by using,
e.g., "xl sched-rtds -d vm1 -v 0 -p 100 -b 50" command (where "-v 0" specifies
the VCPU with ID=0). The parameters would be like:

# xl sched-rtds -d vm1
Name                                ID VCPU    Period    Budget
vm1                                  1    0       100        50
vm1                                  1    1      2000      1000


Users can also set the budget and period of multiple VCPUs of a specific domain
with only one command, e.g., "xl sched-rtds -d vm1 -v 0 -p 100 -b 50
-v 1 -p 300 -b 150".
The parameters would be like:

# xl sched-rtds -d vm1
Name                                ID VCPU    Period    Budget
vm1                                  1    0       200       100
vm1                                  1    1       300       150

4) Users can still set the per-domain parameters (previous xl rtds
tool already supported this).
e.g., "xl sched-rtds -d vm1 -p 500 -b 250". The parameters would be like:

# xl sched-rtds -d vm1
Name                                ID VCPU    Period    Budget
vm1                                  1    0       500       250
vm1                                  1    1       500       250


Chong Li (4):
  xen: enabling XL to set per-VCPU parameters of a domain for RTDS
    scheduler
  libxc: enabling XL to set per-VCPU parameters of a domain for RTDS
    scheduler
  libxl: enabling XL to set per-VCPU parameters of a domain for RTDS
    scheduler
  xl: enabling XL to set per-VCPU parameters of a domain for RTDS
    scheduler

 tools/libxc/include/xenctrl.h |   9 ++
 tools/libxc/xc_rt.c           |  53 +++++++++
 tools/libxl/libxl.c           | 189 ++++++++++++++++++++++++++----
 tools/libxl/libxl.h           |  19 +++
 tools/libxl/libxl_types.idl   |  11 ++
 tools/libxl/xl_cmdimpl.c      | 261 +++++++++++++++++++++++++++++++++++++-----
 xen/common/domctl.c           |   5 +
 xen/common/sched_rt.c         |  71 +++++++++++-
 xen/common/schedule.c         |  24 ++++
 xen/include/public/domctl.h   |  29 +++++
 xen/include/xen/sched-if.h    |   2 +
 xen/include/xen/sched.h       |   1 +
 12 files changed, 619 insertions(+), 55 deletions(-)

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-05-25 23:59 [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler Chong Li
@ 2015-05-26  8:59 ` Ian Campbell
  2015-05-29 11:15   ` Dario Faggioli
  0 siblings, 1 reply; 12+ messages in thread
From: Ian Campbell @ 2015-05-26  8:59 UTC (permalink / raw)
  To: Chong Li
  Cc: Wei Liu, George Dunlap, dario.faggioli, Ian Jackson, xen-devel,
	Meng Xu, Jan Beulich, Dagaen Golomb

On Mon, 2015-05-25 at 18:59 -0500, Chong Li wrote:

This series arrived in my mailbox as 5 distinct mails.

Please use git send-email such that the mails arrive as a single email
thread (i.e. each mail as a reply to the previous or to the 0th mail) or
arrange for the same thing by hand (I highly recommend using git
send-email though)

Ian.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-05-26  8:59 ` Ian Campbell
@ 2015-05-29 11:15   ` Dario Faggioli
  2015-05-29 14:40     ` Meng Xu
  0 siblings, 1 reply; 12+ messages in thread
From: Dario Faggioli @ 2015-05-29 11:15 UTC (permalink / raw)
  To: Ian Campbell
  Cc: Wei Liu, George Dunlap, Ian Jackson, xen-devel, Meng Xu,
	Jan Beulich, Chong Li, Dagaen Golomb


[-- Attachment #1.1: Type: text/plain, Size: 841 bytes --]

On Tue, 2015-05-26 at 09:59 +0100, Ian Campbell wrote:
> On Mon, 2015-05-25 at 18:59 -0500, Chong Li wrote:
> 
> This series arrived in my mailbox as 5 distinct mails.
> 
> Please use git send-email such that the mails arrive as a single email
> thread (i.e. each mail as a reply to the previous or to the 0th mail) or
> arrange for the same thing by hand (I highly recommend using git
> send-email though)
> 
Indeed.

BTW, Chong, v1 was threaded ok, so maybe did something different this
time when sending the patches. If yes, just don't! :-)

Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-05-29 11:15   ` Dario Faggioli
@ 2015-05-29 14:40     ` Meng Xu
  2015-06-01  8:36       ` George Dunlap
  0 siblings, 1 reply; 12+ messages in thread
From: Meng Xu @ 2015-05-29 14:40 UTC (permalink / raw)
  To: Dario Faggioli
  Cc: Wei Liu, Ian Campbell, George Dunlap, Ian Jackson, xen-devel,
	Meng Xu, Jan Beulich, Chong Li, Dagaen Golomb


[-- Attachment #1.1: Type: text/plain, Size: 1151 bytes --]

2015-05-29 4:15 GMT-07:00 Dario Faggioli <dario.faggioli@citrix.com>:

> On Tue, 2015-05-26 at 09:59 +0100, Ian Campbell wrote:
> > On Mon, 2015-05-25 at 18:59 -0500, Chong Li wrote:
> >
> > This series arrived in my mailbox as 5 distinct mails.
> >
> > Please use git send-email such that the mails arrive as a single email
> > thread (i.e. each mail as a reply to the previous or to the 0th mail) or
> > arrange for the same thing by hand (I highly recommend using git
> > send-email though)
> >
> Indeed.
>
> BTW, Chong, v1 was threaded ok, so maybe did something different this
> time when sending the patches. If yes, just don't! :-)
>


​I think that's because Chong wanted to send different patches in this
patch set to different maintainers. (For example, we don't want to spam
Jan's folder with xl, libxl patch. :-) )

Is it ok to use "git send-email --reply-to" to attach all four patches to
the cover letter (that is this email thread) of the patch set?


Thanks,

Meng


-----------
Meng Xu
PhD Student in Computer and Information Science
University of Pennsylvania
http://www.cis.upenn.edu/~mengxu/

[-- Attachment #1.2: Type: text/html, Size: 2247 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-05-29 14:40     ` Meng Xu
@ 2015-06-01  8:36       ` George Dunlap
  2015-06-01  8:48         ` Ian Campbell
  0 siblings, 1 reply; 12+ messages in thread
From: George Dunlap @ 2015-06-01  8:36 UTC (permalink / raw)
  To: Meng Xu, Dario Faggioli
  Cc: Wei Liu, Ian Campbell, Ian Jackson, xen-devel, Meng Xu,
	Jan Beulich, Chong Li, Dagaen Golomb

On 05/29/2015 03:40 PM, Meng Xu wrote:
> 2015-05-29 4:15 GMT-07:00 Dario Faggioli <dario.faggioli@citrix.com>:
> 
>> On Tue, 2015-05-26 at 09:59 +0100, Ian Campbell wrote:
>>> On Mon, 2015-05-25 at 18:59 -0500, Chong Li wrote:
>>>
>>> This series arrived in my mailbox as 5 distinct mails.
>>>
>>> Please use git send-email such that the mails arrive as a single email
>>> thread (i.e. each mail as a reply to the previous or to the 0th mail) or
>>> arrange for the same thing by hand (I highly recommend using git
>>> send-email though)
>>>
>> Indeed.
>>
>> BTW, Chong, v1 was threaded ok, so maybe did something different this
>> time when sending the patches. If yes, just don't! :-)
>>
> 
> 
> ​I think that's because Chong wanted to send different patches in this
> patch set to different maintainers. (For example, we don't want to spam
> Jan's folder with xl, libxl patch. :-) )
> 
> Is it ok to use "git send-email --reply-to" to attach all four patches to
> the cover letter (that is this email thread) of the patch set?

So two git features:
* If you write "CC: Name <address@blah.blah>" in your commit message,
git send-email will CC that person *just for that commit*
* Anything in the description under a line starting with "---" will be
discarded

So you can write your message like this:
8<--------------------------------------
libxl: A one-line example.

This is just an example commit.

Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
---
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Wei Liu <wei.liu@citrix.com>
8<--------------------------------------

And when you do git-send-email, it will automatically CC Ian and Wei
(and only them) for this patch.

 -George

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-06-01  8:36       ` George Dunlap
@ 2015-06-01  8:48         ` Ian Campbell
  2015-06-01  8:50           ` George Dunlap
  0 siblings, 1 reply; 12+ messages in thread
From: Ian Campbell @ 2015-06-01  8:48 UTC (permalink / raw)
  To: George Dunlap
  Cc: Wei Liu, Dario Faggioli, Ian Jackson, xen-devel, Meng Xu,
	Meng Xu, Jan Beulich, Chong Li, Dagaen Golomb

On Mon, 2015-06-01 at 09:36 +0100, George Dunlap wrote:
> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> ---
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Wei Liu <wei.liu@citrix.com>

Most people put the Cc about the cut (---) which is fine too. It means
the history ends up recording who was copied on the patch, which isn't
necessarily a bad thing.

> 8<--------------------------------------
> 
> And when you do git-send-email, it will automatically CC Ian and Wei
> (and only them) for this patch.
> 
>  -George

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-06-01  8:48         ` Ian Campbell
@ 2015-06-01  8:50           ` George Dunlap
  2015-06-01  8:57             ` Ian Campbell
  2015-06-01  8:58             ` Jan Beulich
  0 siblings, 2 replies; 12+ messages in thread
From: George Dunlap @ 2015-06-01  8:50 UTC (permalink / raw)
  To: Ian Campbell
  Cc: Wei Liu, Dario Faggioli, Ian Jackson, xen-devel, Meng Xu,
	Meng Xu, Jan Beulich, Chong Li, Dagaen Golomb

On 06/01/2015 09:48 AM, Ian Campbell wrote:
> On Mon, 2015-06-01 at 09:36 +0100, George Dunlap wrote:
>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>> ---
>> CC: Ian Campbell <ian.campbell@citrix.com>
>> CC: Wei Liu <wei.liu@citrix.com>
> 
> Most people put the Cc about the cut (---) which is fine too. It means
> the history ends up recording who was copied on the patch, which isn't
> necessarily a bad thing.

Right -- I would have thought that was useless information cluttering up
the history, but I can see how it might actually be useful.  Should I
start putting my CC's above the ---? :-)

 -George

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-06-01  8:50           ` George Dunlap
@ 2015-06-01  8:57             ` Ian Campbell
  2015-06-01  8:58             ` Jan Beulich
  1 sibling, 0 replies; 12+ messages in thread
From: Ian Campbell @ 2015-06-01  8:57 UTC (permalink / raw)
  To: George Dunlap
  Cc: Wei Liu, Dario Faggioli, Ian Jackson, xen-devel, Meng Xu,
	Meng Xu, Jan Beulich, Chong Li, Dagaen Golomb

On Mon, 2015-06-01 at 09:50 +0100, George Dunlap wrote:
> On 06/01/2015 09:48 AM, Ian Campbell wrote:
> > On Mon, 2015-06-01 at 09:36 +0100, George Dunlap wrote:
> >> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> >> ---
> >> CC: Ian Campbell <ian.campbell@citrix.com>
> >> CC: Wei Liu <wei.liu@citrix.com>
> > 
> > Most people put the Cc about the cut (---) which is fine too. It means
> > the history ends up recording who was copied on the patch, which isn't
> > necessarily a bad thing.
> 
> Right -- I would have thought that was useless information cluttering up
> the history, but I can see how it might actually be useful.  Should I
> start putting my CC's above the ---? :-)

FWIW, pretty much everyone else does.

Ian.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-06-01  8:50           ` George Dunlap
  2015-06-01  8:57             ` Ian Campbell
@ 2015-06-01  8:58             ` Jan Beulich
  2015-06-01  9:06               ` Andrew Cooper
  1 sibling, 1 reply; 12+ messages in thread
From: Jan Beulich @ 2015-06-01  8:58 UTC (permalink / raw)
  To: Ian Campbell, George Dunlap
  Cc: Wei Liu, Dario Faggioli, Ian Jackson, xen-devel, Meng Xu,
	Meng Xu, Chong Li, Dagaen Golomb

>>> On 01.06.15 at 10:50, <george.dunlap@eu.citrix.com> wrote:
> On 06/01/2015 09:48 AM, Ian Campbell wrote:
>> On Mon, 2015-06-01 at 09:36 +0100, George Dunlap wrote:
>>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>>> ---
>>> CC: Ian Campbell <ian.campbell@citrix.com>
>>> CC: Wei Liu <wei.liu@citrix.com>
>> 
>> Most people put the Cc about the cut (---) which is fine too. It means
>> the history ends up recording who was copied on the patch, which isn't
>> necessarily a bad thing.
> 
> Right -- I would have thought that was useless information cluttering up
> the history, but I can see how it might actually be useful.  Should I
> start putting my CC's above the ---? :-)

And should I stop dropping them even when above the --- for
commit, which so far I've been doing as I don't consider this
particularly useful information (other then e.g. who might have
commented on a change without it being recorded in an Acked-by
or Reviewed-by tag)?

Jan

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-06-01  8:58             ` Jan Beulich
@ 2015-06-01  9:06               ` Andrew Cooper
  2015-06-01  9:20                 ` George Dunlap
  0 siblings, 1 reply; 12+ messages in thread
From: Andrew Cooper @ 2015-06-01  9:06 UTC (permalink / raw)
  To: Jan Beulich, Ian Campbell, George Dunlap
  Cc: Wei Liu, Dario Faggioli, Ian Jackson, xen-devel, Meng Xu,
	Meng Xu, Chong Li, Dagaen Golomb

On 01/06/15 09:58, Jan Beulich wrote:
>>>> On 01.06.15 at 10:50, <george.dunlap@eu.citrix.com> wrote:
>> On 06/01/2015 09:48 AM, Ian Campbell wrote:
>>> On Mon, 2015-06-01 at 09:36 +0100, George Dunlap wrote:
>>>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>>>> ---
>>>> CC: Ian Campbell <ian.campbell@citrix.com>
>>>> CC: Wei Liu <wei.liu@citrix.com>
>>> Most people put the Cc about the cut (---) which is fine too. It means
>>> the history ends up recording who was copied on the patch, which isn't
>>> necessarily a bad thing.
>> Right -- I would have thought that was useless information cluttering up
>> the history, but I can see how it might actually be useful.  Should I
>> start putting my CC's above the ---? :-)
> And should I stop dropping them even when above the --- for
> commit, which so far I've been doing as I don't consider this
> particularly useful information (other then e.g. who might have
> commented on a change without it being recorded in an Acked-by
> or Reviewed-by tag)?

Is the CC list useful to keep in history? It ends up being the list of
people who didn't respond to it before it got committed (or
ignored/missed the email entirely).

It is the $FOO'd-by tags which are important when it comes to judging
the acceptability of a patch.

~Andrew

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-06-01  9:06               ` Andrew Cooper
@ 2015-06-01  9:20                 ` George Dunlap
  2015-06-01  9:44                   ` Ian Campbell
  0 siblings, 1 reply; 12+ messages in thread
From: George Dunlap @ 2015-06-01  9:20 UTC (permalink / raw)
  To: Andrew Cooper, Jan Beulich, Ian Campbell
  Cc: Wei Liu, Dario Faggioli, Ian Jackson, xen-devel, Meng Xu,
	Meng Xu, Chong Li, Dagaen Golomb

On 06/01/2015 10:06 AM, Andrew Cooper wrote:
> On 01/06/15 09:58, Jan Beulich wrote:
>>>>> On 01.06.15 at 10:50, <george.dunlap@eu.citrix.com> wrote:
>>> On 06/01/2015 09:48 AM, Ian Campbell wrote:
>>>> On Mon, 2015-06-01 at 09:36 +0100, George Dunlap wrote:
>>>>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>>>>> ---
>>>>> CC: Ian Campbell <ian.campbell@citrix.com>
>>>>> CC: Wei Liu <wei.liu@citrix.com>
>>>> Most people put the Cc about the cut (---) which is fine too. It means
>>>> the history ends up recording who was copied on the patch, which isn't
>>>> necessarily a bad thing.
>>> Right -- I would have thought that was useless information cluttering up
>>> the history, but I can see how it might actually be useful.  Should I
>>> start putting my CC's above the ---? :-)
>> And should I stop dropping them even when above the --- for
>> commit, which so far I've been doing as I don't consider this
>> particularly useful information (other then e.g. who might have
>> commented on a change without it being recorded in an Acked-by
>> or Reviewed-by tag)?
> 
> Is the CC list useful to keep in history? It ends up being the list of
> people who didn't respond to it before it got committed (or
> ignored/missed the email entirely).
> 
> It is the $FOO'd-by tags which are important when it comes to judging
> the acceptability of a patch.

OK, well that's 3 of us so far who think it's sort of useless, including
someone who things it's useless enough to spend the effort deleting
them.  Maybe we can leave the bike shed the color it is at the moment. ;-)

 -George

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler
  2015-06-01  9:20                 ` George Dunlap
@ 2015-06-01  9:44                   ` Ian Campbell
  0 siblings, 0 replies; 12+ messages in thread
From: Ian Campbell @ 2015-06-01  9:44 UTC (permalink / raw)
  To: George Dunlap
  Cc: Wei Liu, Andrew Cooper, Dario Faggioli, Ian Jackson, xen-devel,
	Meng Xu, Meng Xu, Jan Beulich, Chong Li, Dagaen Golomb

On Mon, 2015-06-01 at 10:20 +0100, George Dunlap wrote:
> On 06/01/2015 10:06 AM, Andrew Cooper wrote:
> > On 01/06/15 09:58, Jan Beulich wrote:
> >>>>> On 01.06.15 at 10:50, <george.dunlap@eu.citrix.com> wrote:
> >>> On 06/01/2015 09:48 AM, Ian Campbell wrote:
> >>>> On Mon, 2015-06-01 at 09:36 +0100, George Dunlap wrote:
> >>>>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> >>>>> ---
> >>>>> CC: Ian Campbell <ian.campbell@citrix.com>
> >>>>> CC: Wei Liu <wei.liu@citrix.com>
> >>>> Most people put the Cc about the cut (---) which is fine too. It means
> >>>> the history ends up recording who was copied on the patch, which isn't
> >>>> necessarily a bad thing.
> >>> Right -- I would have thought that was useless information cluttering up
> >>> the history, but I can see how it might actually be useful.  Should I
> >>> start putting my CC's above the ---? :-)
> >> And should I stop dropping them even when above the --- for
> >> commit, which so far I've been doing as I don't consider this
> >> particularly useful information (other then e.g. who might have
> >> commented on a change without it being recorded in an Acked-by
> >> or Reviewed-by tag)?
> > 
> > Is the CC list useful to keep in history? It ends up being the list of
> > people who didn't respond to it before it got committed (or
> > ignored/missed the email entirely).
> > 
> > It is the $FOO'd-by tags which are important when it comes to judging
> > the acceptability of a patch.
> 
> OK, well that's 3 of us so far who think it's sort of useless, including
> someone who things it's useless enough to spend the effort deleting
> them.  Maybe we can leave the bike shed the color it is at the moment. ;-)

I used to delete them, but it was tiresome and seemed like a waste of
effort since, whatever the magnitude, the information content isn't 0
and they are harmless.

Ian.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2015-06-01  9:44 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-25 23:59 [PATCH v2 for Xen 4.6 0/4] Enabling XL to set per-VCPU parameters of a domain for RTDS scheduler Chong Li
2015-05-26  8:59 ` Ian Campbell
2015-05-29 11:15   ` Dario Faggioli
2015-05-29 14:40     ` Meng Xu
2015-06-01  8:36       ` George Dunlap
2015-06-01  8:48         ` Ian Campbell
2015-06-01  8:50           ` George Dunlap
2015-06-01  8:57             ` Ian Campbell
2015-06-01  8:58             ` Jan Beulich
2015-06-01  9:06               ` Andrew Cooper
2015-06-01  9:20                 ` George Dunlap
2015-06-01  9:44                   ` Ian Campbell

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.