* [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map()
@ 2015-05-28 12:52 Masahiro Yamada
2015-05-28 18:30 ` Joe Perches
2015-06-02 11:33 ` Linus Walleij
0 siblings, 2 replies; 5+ messages in thread
From: Masahiro Yamada @ 2015-05-28 12:52 UTC (permalink / raw)
To: linux-gpio; +Cc: Masahiro Yamada, Linus Walleij, linux-kernel
There are two types for pinctrl maps: pinmux and pinconfig
This debug message shows the number of maps of both types.
The string "pinmux map" is not precise. Let's say "pinctrl map"
instead.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
drivers/pinctrl/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 18ee208..36c5592 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -1115,7 +1115,7 @@ int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps,
int i, ret;
struct pinctrl_maps *maps_node;
- pr_debug("add %d pinmux maps\n", num_maps);
+ pr_debug("add %d pinctrl maps\n", num_maps);
/* First sanity check the new mapping */
for (i = 0; i < num_maps; i++) {
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map()
2015-05-28 12:52 [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map() Masahiro Yamada
@ 2015-05-28 18:30 ` Joe Perches
2015-06-02 11:33 ` Linus Walleij
1 sibling, 0 replies; 5+ messages in thread
From: Joe Perches @ 2015-05-28 18:30 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-gpio, Linus Walleij, linux-kernel
On Thu, 2015-05-28 at 21:52 +0900, Masahiro Yamada wrote:
> There are two types for pinctrl maps: pinmux and pinconfig
> This debug message shows the number of maps of both types.
> The string "pinmux map" is not precise. Let's say "pinctrl map"
> instead.
[]
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
[]
> @@ -1115,7 +1115,7 @@ int pinctrl_register_map(struct pinctrl_map const *maps, unsigned num_maps,
> int i, ret;
> struct pinctrl_maps *maps_node;
>
> - pr_debug("add %d pinmux maps\n", num_maps);
> + pr_debug("add %d pinctrl maps\n", num_maps);
You might want to fix the %d/%u mismatch too
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map()
2015-05-28 12:52 [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map() Masahiro Yamada
2015-05-28 18:30 ` Joe Perches
@ 2015-06-02 11:33 ` Linus Walleij
2015-06-02 12:16 ` Masahiro Yamada
1 sibling, 1 reply; 5+ messages in thread
From: Linus Walleij @ 2015-06-02 11:33 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-gpio, linux-kernel
On Thu, May 28, 2015 at 2:52 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> There are two types for pinctrl maps: pinmux and pinconfig
> This debug message shows the number of maps of both types.
> The string "pinmux map" is not precise. Let's say "pinctrl map"
> instead.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Patch applied, also changed %d->%u as suggested by Joe.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map()
2015-06-02 11:33 ` Linus Walleij
@ 2015-06-02 12:16 ` Masahiro Yamada
2015-06-08 13:33 ` Linus Walleij
0 siblings, 1 reply; 5+ messages in thread
From: Masahiro Yamada @ 2015-06-02 12:16 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-gpio, linux-kernel
2015-06-02 20:33 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>:
> On Thu, May 28, 2015 at 2:52 PM, Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>
>> There are two types for pinctrl maps: pinmux and pinconfig
>> This debug message shows the number of maps of both types.
>> The string "pinmux map" is not precise. Let's say "pinctrl map"
>> instead.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> Patch applied, also changed %d->%u as suggested by Joe.
>
When you apply a patch, please check if it is the latest version.
I had already posted v2, so that you do not need to tweak the patch locally.
http://patchwork.ozlabs.org/patch/477666/
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map()
2015-06-02 12:16 ` Masahiro Yamada
@ 2015-06-08 13:33 ` Linus Walleij
0 siblings, 0 replies; 5+ messages in thread
From: Linus Walleij @ 2015-06-08 13:33 UTC (permalink / raw)
To: Masahiro Yamada; +Cc: linux-gpio, linux-kernel
On Tue, Jun 2, 2015 at 2:16 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> 2015-06-02 20:33 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>:
>> On Thu, May 28, 2015 at 2:52 PM, Masahiro Yamada
>> <yamada.masahiro@socionext.com> wrote:
>>
>>> There are two types for pinctrl maps: pinmux and pinconfig
>>> This debug message shows the number of maps of both types.
>>> The string "pinmux map" is not precise. Let's say "pinctrl map"
>>> instead.
>>>
>>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>>
>> Patch applied, also changed %d->%u as suggested by Joe.
>>
>
>
> When you apply a patch, please check if it is the latest version.
If you had seen my mailbox you would know why that is not always
so easy to just add another routine to be applied to every patch that
comes in.
I tend to do it a bit, in an add hoc manner, sometimes I miss stuff,
mea culpa.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-08 13:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-05-28 12:52 [PATCH] pinctrl: fix confusing debug message in pinctrl_register_map() Masahiro Yamada
2015-05-28 18:30 ` Joe Perches
2015-06-02 11:33 ` Linus Walleij
2015-06-02 12:16 ` Masahiro Yamada
2015-06-08 13:33 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.