Re: [RFC 07/24] x86/thinkpad_acpi: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()

From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Finn Thain <fthain@telegraphics.com.au>
Cc: linux-kernel@vger.kernel.org, linux-m68k@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org, Darren Hart <dvhart@infradead.org>,
	ibm-acpi-devel@lists.sourceforge.net,
	platform-driver-x86@vger.kernel.org
Subject: Re: [RFC 07/24] x86/thinkpad_acpi: Use arch_nvram_ops methods instead of nvram_read_byte() and nvram_write_byte()
Date: Tue, 02 Jun 2015 07:09:28 -0300	[thread overview]
Message-ID: <1433239768.902135.284523153.1200C3E3@webmail.messagingengine.com> (raw)
In-Reply-To: <20150531143422.GA12337@khazad-dum.debian.net>

Test results were sent to me privately, and they are correct, so...

Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>

On Sun, May 31, 2015, at 11:34, Henrique de Moraes Holschuh wrote:
> On Sun, 31 May 2015, Finn Thain wrote:
> > On Sun, 31 May 2015, Henrique de Moraes Holschuh wrote:
> > > On Sun, 31 May 2015, Finn Thain wrote:
> > > > Make use of arch_nvram_ops in the thinkpad_acpi driver so that the 
> > > > nvram_* function exports can be removed.
> > > > 
> > > > This patch series was tested on a ThinkPad T43.
> > > 
> > > Can you describe how you did the testing?  A specific procedure is 
> > > required to test the hotkey NVRAM polling codepaths (which will read 
> > > several NVRAM bytes @10Hz by default) in a T43...
> > > 
> > > > Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
> > > 
> > > The patch looks correct, so I don't expect any problems.
> > > 
> > > Provided that your test procedure did enable hotkey NVRAM polling in the 
> > > T43 and your hotkeys all still worked fine, you have my Acked-by.
> > 
> > The procedure I used was this,
> > 
> > 1. $ xev
> > 2. # rmmod thinkpad_acpi
> > 3. Press <Access IBM> key and confirm that xev does not report any
> >    events.
> > 4. # modprobe thinkpad_acpi
> > 5. Press <Access IBM> key and confirm that xev now reports the key press 
> >    events.
> > 
> > Is this sufficient?
> 
> No.  Please try:
> 
> modprobe thinkpad_acpi
> echo 0xfb88c0 > /sys/devices/platform/thinkpad_acpi/hotkey_source_mask
> 
> test the hotkeys.  Please test several of them, as not all of them are
> available through NVRAM polling... at least Fn+SPACE, Fn+F1..FN+F12
> 
> Please test the brightness keys. In the T43 we use "direct EC mode",
> which
> depends on the NVRAM to sync with the SMBIOS firmware.
> 
> to reset the driver to normal mode, it is enough to do this:
> echo 0 > /sys/devices/platform/thinkpad_acpi/hotkey_source_mask

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh