* [Intel-wired-lan] [PATCH] e1000e: Cleanup qos request in error handling of e1000_open
@ 2015-06-04 13:07 Jia-Ju Bai
2015-06-20 2:43 ` Brown, Aaron F
0 siblings, 1 reply; 4+ messages in thread
From: Jia-Ju Bai @ 2015-06-04 13:07 UTC (permalink / raw)
To: intel-wired-lan
The driver lacks pm_qos_remove_request in error handling (err_req_irq) of
e1000_open, and qos request inserted by pm_qos_add_request is not removed.
This patch add pm_qos_remove_request in error handling to fix it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index c509a5c..f8c0dc4 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -4451,6 +4451,7 @@ static int e1000_open(struct net_device *netdev)
return 0;
err_req_irq:
+ pm_qos_remove_request(&adapter->pm_qos_req);
e1000e_release_hw_control(adapter);
e1000_power_down_phy(adapter);
e1000e_free_rx_resources(adapter->rx_ring);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] e1000e: Cleanup qos request in error handling of e1000_open
2015-06-04 13:07 [Intel-wired-lan] [PATCH] e1000e: Cleanup qos request in error handling of e1000_open Jia-Ju Bai
@ 2015-06-20 2:43 ` Brown, Aaron F
0 siblings, 0 replies; 4+ messages in thread
From: Brown, Aaron F @ 2015-06-20 2:43 UTC (permalink / raw)
To: intel-wired-lan
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On
> Behalf Of Jia-Ju Bai
> Sent: Thursday, June 04, 2015 6:07 AM
> To: intel-wired-lan at lists.osuosl.org
> Cc: Jia-Ju Bai
> Subject: [Intel-wired-lan] [PATCH] e1000e: Cleanup qos request in error
> handling of e1000_open
>
> The driver lacks pm_qos_remove_request in error handling (err_req_irq) of
> e1000_open, and qos request inserted by pm_qos_add_request is not removed.
> This patch add pm_qos_remove_request in error handling to fix it.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
> ---
> drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
> 1 file changed, 1 insertion(+)
Tested-by: Aaron Brown <aaron.f.brown@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] e1000e: Cleanup qos request in error handling of e1000_open
@ 2015-06-04 8:56 Jia-Ju Bai
0 siblings, 0 replies; 4+ messages in thread
From: Jia-Ju Bai @ 2015-06-04 8:56 UTC (permalink / raw)
To: intel-wired-lan
The driver lacks pm_qos_remove_request in error handling (err_req_irq)
of e1000_open, and qos request inserted by pm_qos_add_request is not removed.
This patch add pm_qos_remove_request in error handling to fix it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index c509a5c..f8c0dc4 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -4451,6 +4451,7 @@ static int e1000_open(struct net_device *netdev)
return 0;
err_req_irq:
+ pm_qos_remove_request(&adapter->pm_qos_req);
e1000e_release_hw_control(adapter);
e1000_power_down_phy(adapter);
e1000e_free_rx_resources(adapter->rx_ring);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Intel-wired-lan] [PATCH] e1000e: Cleanup qos request in error handling of e1000_open
@ 2015-06-03 9:43 Jia-Ju Bai
0 siblings, 0 replies; 4+ messages in thread
From: Jia-Ju Bai @ 2015-06-03 9:43 UTC (permalink / raw)
To: intel-wired-lan
The driver lacks pm_qos_remove_request in error handling (err_req_irq)
of e1000_open, and qos request inserted by pm_qos_add_request is not removed.
This patch add pm_qos_remove_request in error handling to fix it.
Signed-off-by: Jia-Ju Bai <baijiaju1990@163.com>
---
drivers/net/ethernet/intel/e1000e/netdev.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c
index c509a5c..f8c0dc4 100644
--- a/drivers/net/ethernet/intel/e1000e/netdev.c
+++ b/drivers/net/ethernet/intel/e1000e/netdev.c
@@ -4451,6 +4451,7 @@ static int e1000_open(struct net_device *netdev)
return 0;
err_req_irq:
+ pm_qos_remove_request(&adapter->pm_qos_req);
e1000e_release_hw_control(adapter);
e1000_power_down_phy(adapter);
e1000e_free_rx_resources(adapter->rx_ring);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-20 2:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-04 13:07 [Intel-wired-lan] [PATCH] e1000e: Cleanup qos request in error handling of e1000_open Jia-Ju Bai
2015-06-20 2:43 ` Brown, Aaron F
-- strict thread matches above, loose matches on Subject: below --
2015-06-04 8:56 Jia-Ju Bai
2015-06-03 9:43 Jia-Ju Bai
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.