[PATCH V2 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile

[PATCH V2 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile

[Taehee Yoo]

in the _rtl92c_phy_rf6052_config_parafile(), cases
RF90_PATH_A and RF90_PATH_B call the same routine.
so i remove one of these routine. also the return
routine is duplicated. so i remove it.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
 drivers/net/wireless/rtlwifi/rtl8192cu/rf.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
index b878d56..8ce055c 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/rf.c
@@ -452,9 +452,6 @@ static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
 		udelay(1);
 		switch (rfpath) {
 		case RF90_PATH_A:
-			rtstatus = rtl92cu_phy_config_rf_with_headerfile(hw,
-					(enum radio_path) rfpath);
-			break;
 		case RF90_PATH_B:
 			rtstatus = rtl92cu_phy_config_rf_with_headerfile(hw,
 					(enum radio_path) rfpath);
@@ -483,7 +480,6 @@ static bool _rtl92c_phy_rf6052_config_parafile(struct ieee80211_hw *hw)
 		}
 	}
 	RT_TRACE(rtlpriv, COMP_INIT, DBG_TRACE, "<---\n");
-	return rtstatus;
 phy_rf_cfg_fail:
 	return rtstatus;
 }
-- 
2.1.4

Re: [PATCH V2 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile

[Kalle Valo]

Taehee Yoo <ap420073@gmail.com> writes:

> in the _rtl92c_phy_rf6052_config_parafile(), cases
> RF90_PATH_A and RF90_PATH_B call the same routine.
> so i remove one of these routine. also the return
> routine is duplicated. so i remove it.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>

Please resend the whole series (ie. all three patches), not just the
patch which has changed.

-- 
Kalle Valo

Re: [PATCH V2 1/3] rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile

[Taehee Yoo]

2015-06-06 21:42 GMT+09:00 Kalle Valo <kvalo@codeaurora.org>:
> Taehee Yoo <ap420073@gmail.com> writes:
>
>> in the _rtl92c_phy_rf6052_config_parafile(), cases
>> RF90_PATH_A and RF90_PATH_B call the same routine.
>> so i remove one of these routine. also the return
>> routine is duplicated. so i remove it.
>>
>> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
>
> Please resend the whole series (ie. all three patches), not just the
> patch which has changed.
>
> --
> Kalle Valo

Thank you for your feedback!
I will resend the two patches.

Re: [V2, 1/3] rtlwifi: rtl8192cu: remove duplicated routine in_rtl92c_phy_rf6052_config_parafile

[Kalle Valo]

> in the _rtl92c_phy_rf6052_config_parafile(), cases
> RF90_PATH_A and RF90_PATH_B call the same routine.
> so i remove one of these routine. also the return
> routine is duplicated. so i remove it.
> 
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>

Thanks, 3 patches applied to wireless-drivers-next.git:

138055e23b66 rtlwifi: rtl8192cu: remove duplicated routine in _rtl92c_phy_rf6052_config_parafile
8657f9c4d52f rtlwifi: rtl8192cu: debug message change "RTL8192CE" to "RTL8192CU"
d92460097c00 rtlwifi: rtl8192cu: Fix variable isfirst_ampdu

Kalle Valo