From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
qemu-stable@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
pbonzini@redhat.com, jsnow@redhat.com, wangxiaolong@ucloud.cn
Subject: [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors
Date: Mon, 8 Jun 2015 13:56:06 +0800 [thread overview]
Message-ID: <1433742974-20128-1-git-send-email-famz@redhat.com> (raw)
v7: Fix the lost assignment of s->unmap.
v6: Fix pnum in bdrv_get_block_status_above. [Paolo]
v5: Rewrite patch 1.
Address Eric's comments on patch 3.
Add Eric's rev-by to patches 2 & 4.
Check BDRV_BLOCK_DATA in patch 3. [Paolo]
This fixes the mirror assert failure reported by wangxiaolong:
https://lists.gnu.org/archive/html/qemu-devel/2015-04/msg04458.html
The direct cause is that hbitmap code couldn't handle unset of bits *after*
iterator's current position. We could fix that, but the bdrv_reset_dirty() call
is more questionable:
Before, if guest discarded some sectors during migration, it could see
different data after moving to dest side, depending on block backends of the
src and the dest. This is IMO worse than mirroring the actual reading as done
in this series, because we don't know what the guest is doing.
For example if a guest first issues WRITE SAME to wipe out the area then issues
UNMAP to discard it, just to get rid of some sensitive data completely, we may
miss both operations and leave stale data on dest image.
Fam Zheng (8):
block: Add bdrv_get_block_status_above
qmp: Add optional bool "unmap" to drive-mirror
mirror: Do zero write on target if sectors not allocated
block: Fix dirty bitmap in bdrv_co_discard
block: Remove bdrv_reset_dirty
qemu-iotests: Make block job methods common
qemu-iotests: Add test case for mirror with unmap
iotests: Use event_wait in wait_ready
block.c | 12 --------
block/io.c | 60 ++++++++++++++++++++++++++++++---------
block/mirror.c | 28 +++++++++++++++---
blockdev.c | 5 ++++
hmp.c | 2 +-
include/block/block.h | 4 +++
include/block/block_int.h | 4 +--
qapi/block-core.json | 8 +++++-
qmp-commands.hx | 3 ++
tests/qemu-iotests/041 | 66 ++++++++++---------------------------------
tests/qemu-iotests/132 | 59 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/132.out | 5 ++++
tests/qemu-iotests/group | 1 +
tests/qemu-iotests/iotests.py | 23 +++++++++++++++
14 files changed, 196 insertions(+), 84 deletions(-)
create mode 100644 tests/qemu-iotests/132
create mode 100644 tests/qemu-iotests/132.out
--
2.4.2
next reply other threads:[~2015-06-08 5:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 5:56 Fam Zheng [this message]
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 1/8] block: Add bdrv_get_block_status_above Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror Fam Zheng
2015-06-08 14:51 ` Eric Blake
2015-06-08 14:54 ` Paolo Bonzini
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 3/8] mirror: Do zero write on target if sectors not allocated Fam Zheng
2015-11-04 18:35 ` Kevin Wolf
2015-11-05 5:42 ` Fam Zheng
2015-11-05 9:55 ` Kevin Wolf
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 4/8] block: Fix dirty bitmap in bdrv_co_discard Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 5/8] block: Remove bdrv_reset_dirty Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 6/8] qemu-iotests: Make block job methods common Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 7/8] qemu-iotests: Add test case for mirror with unmap Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 8/8] iotests: Use event_wait in wait_ready Fam Zheng
2015-06-08 13:02 ` [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors Stefan Hajnoczi
2015-06-11 8:29 ` Fam Zheng
2015-06-24 9:08 ` [Qemu-devel] [Qemu-stable] " Fam Zheng
2015-06-24 17:01 ` Paolo Bonzini
2015-06-25 1:02 ` Fam Zheng
2015-06-25 10:45 ` Fam Zheng
2015-06-26 13:36 ` Alexandre DERUMIER
2015-06-26 13:58 ` Alexandre DERUMIER
2015-06-29 1:03 ` Fam Zheng
2015-06-26 13:19 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433742974-20128-1-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangxiaolong@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.