From: Fam Zheng <famz@redhat.com>
To: Alexandre DERUMIER <aderumier@odiso.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
qemu-stable <qemu-stable@nongnu.org>,
stefanha <stefanha@redhat.com>, pbonzini <pbonzini@redhat.com>,
jsnow@redhat.com, wangxiaolong@ucloud.cn
Subject: Re: [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors
Date: Mon, 29 Jun 2015 09:03:29 +0800 [thread overview]
Message-ID: <20150629010329.GA16110@ad.nay.redhat.com> (raw)
In-Reply-To: <903405424.2645000.1435325770714.JavaMail.zimbra@oxygem.tv>
On Fri, 06/26 15:36, Alexandre DERUMIER wrote:
> Hi,
>
> >>There is no problem, the observasion by Andrey was just that qmp command takes
> >>a few minutes before returning, because he didn't apply
> >>
> >>https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg02511.html
>
> Is this patch already apply on the block tree ?
>
> With nfs as source storage, it's really slow currently (lseek slow + a lot of nfs ops).
The patch is waiting for the next PULL in Jeff Cody's tree I think.
Fam
>
>
>
> ----- Mail original -----
> De: "Fam Zheng" <famz@redhat.com>
> À: "pbonzini" <pbonzini@redhat.com>
> Cc: "Kevin Wolf" <kwolf@redhat.com>, qemu-block@nongnu.org, "Jeff Cody" <jcody@redhat.com>, "qemu-devel" <qemu-devel@nongnu.org>, "qemu-stable" <qemu-stable@nongnu.org>, "stefanha" <stefanha@redhat.com>, jsnow@redhat.com, wangxiaolong@ucloud.cn
> Envoyé: Jeudi 25 Juin 2015 12:45:38
> Objet: Re: [Qemu-devel] [Qemu-stable] [PATCH v7 0/8] block: Mirror discarded sectors
>
> On Thu, 06/25 09:02, Fam Zheng wrote:
> > On Wed, 06/24 19:01, Paolo Bonzini wrote:
> > >
> > >
> > > On 24/06/2015 11:08, Fam Zheng wrote:
> > > >> Stefan,
> > > >>
> > > >> The only controversial patches are the qmp/drive-mirror ones (1-3), while
> > > >> patches 4-8 are still useful on their own: they fix the mentioned crash and
> > > >> improve iotests.
> > > >>
> > > >> Shall we merge the second half (of course none of them depend on 1-3) now that
> > > >> softfreeze is approaching?
> > > >
> > > > Stefan, would you consider applying patches 4-8?
> > >
> > > Actually why not apply all of them? Even if blockdev-mirror is a
> > > superior interface in the long run, the current behavior of drive-mirror
> > > can cause images to balloon up to the full size, which is bad.
> > > Extending drive-mirror is okay IMHO for 2.4.
> > >
> >
> > Before we do that, Andrey Korolyov has reported a hang issue with unmap=true,
> > I'll take a look at it today.
>
> There is no problem, the observasion by Andrey was just that qmp command takes
> a few minutes before returning, because he didn't apply
>
> https://lists.gnu.org/archive/html/qemu-devel/2015-05/msg02511.html
>
> Fam
>
next prev parent reply other threads:[~2015-06-29 1:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 5:56 [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 1/8] block: Add bdrv_get_block_status_above Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 2/8] qmp: Add optional bool "unmap" to drive-mirror Fam Zheng
2015-06-08 14:51 ` Eric Blake
2015-06-08 14:54 ` Paolo Bonzini
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 3/8] mirror: Do zero write on target if sectors not allocated Fam Zheng
2015-11-04 18:35 ` Kevin Wolf
2015-11-05 5:42 ` Fam Zheng
2015-11-05 9:55 ` Kevin Wolf
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 4/8] block: Fix dirty bitmap in bdrv_co_discard Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 5/8] block: Remove bdrv_reset_dirty Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 6/8] qemu-iotests: Make block job methods common Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 7/8] qemu-iotests: Add test case for mirror with unmap Fam Zheng
2015-06-08 5:56 ` [Qemu-devel] [PATCH v7 8/8] iotests: Use event_wait in wait_ready Fam Zheng
2015-06-08 13:02 ` [Qemu-devel] [PATCH v7 0/8] block: Mirror discarded sectors Stefan Hajnoczi
2015-06-11 8:29 ` Fam Zheng
2015-06-24 9:08 ` [Qemu-devel] [Qemu-stable] " Fam Zheng
2015-06-24 17:01 ` Paolo Bonzini
2015-06-25 1:02 ` Fam Zheng
2015-06-25 10:45 ` Fam Zheng
2015-06-26 13:36 ` Alexandre DERUMIER
2015-06-26 13:58 ` Alexandre DERUMIER
2015-06-29 1:03 ` Fam Zheng [this message]
2015-06-26 13:19 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150629010329.GA16110@ad.nay.redhat.com \
--to=famz@redhat.com \
--cc=aderumier@odiso.com \
--cc=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
--cc=wangxiaolong@ucloud.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.