[Qemu-devel] [PATCH] s390x/migration: add comment about floating point migration

[Qemu-devel] [PATCH] s390x/migration: add comment about floating point migration

[Christian Borntraeger]

commit 46c804def4bd ("s390x: move fpu regs into a subsection
of the vmstate") moved the fprs into a subsection and bumped
the version number. This will allow to not transfer fprs in
the future if necessary. Add a comment to mark the return true
as intentional.

CC: Juan Quintela <quintela@redhat.com>
CC: David Hildenbrand <dahi@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 target-s390x/machine.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/target-s390x/machine.c b/target-s390x/machine.c
index e52d760..0044749 100644
--- a/target-s390x/machine.c
+++ b/target-s390x/machine.c
@@ -70,6 +70,7 @@ const VMStateDescription vmstate_fpu = {
 
 static inline bool fpu_needed(void *opaque)
 {
+    /* This looks odd, but we might want to NOT transfer fprs in the future */
     return true;
 }
 
-- 
2.3.0

Re: [Qemu-devel] [PATCH] s390x/migration: add comment about floating point migration

[Juan Quintela]

Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> commit 46c804def4bd ("s390x: move fpu regs into a subsection
> of the vmstate") moved the fprs into a subsection and bumped
> the version number. This will allow to not transfer fprs in
> the future if necessary. Add a comment to mark the return true
> as intentional.
>
> CC: Juan Quintela <quintela@redhat.com>
> CC: David Hildenbrand <dahi@linux.vnet.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

Reviewed-by: Juan Quintela <quintela@redhat.com>

Thanks for handling this.