* [PATCH 1/1 linux-next] hwmon: (w83627ehf) use swap() in w82627ehf_swap_tempreg()
@ 2015-06-10 16:33 ` Fabian Frederick
0 siblings, 0 replies; 4+ messages in thread
From: Fabian Frederick @ 2015-06-10 16:33 UTC (permalink / raw)
To: linux-kernel
Cc: Julia Lawall, Fabian Frederick, Jean Delvare, Guenter Roeck, lm-sensors
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/hwmon/w83627ehf.c | 26 +++++---------------------
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index b10353b..697007a 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -1937,27 +1937,11 @@ static inline void w83627ehf_init_device(struct w83627ehf_data *data,
static void w82627ehf_swap_tempreg(struct w83627ehf_data *data,
int r1, int r2)
{
- u16 tmp;
-
- tmp = data->temp_src[r1];
- data->temp_src[r1] = data->temp_src[r2];
- data->temp_src[r2] = tmp;
-
- tmp = data->reg_temp[r1];
- data->reg_temp[r1] = data->reg_temp[r2];
- data->reg_temp[r2] = tmp;
-
- tmp = data->reg_temp_over[r1];
- data->reg_temp_over[r1] = data->reg_temp_over[r2];
- data->reg_temp_over[r2] = tmp;
-
- tmp = data->reg_temp_hyst[r1];
- data->reg_temp_hyst[r1] = data->reg_temp_hyst[r2];
- data->reg_temp_hyst[r2] = tmp;
-
- tmp = data->reg_temp_config[r1];
- data->reg_temp_config[r1] = data->reg_temp_config[r2];
- data->reg_temp_config[r2] = tmp;
+ swap(data->temp_src[r1], data->temp_src[r2]);
+ swap(data->reg_temp[r1], data->reg_temp[r2]);
+ swap(data->reg_temp_over[r1], data->reg_temp_over[r2]);
+ swap(data->reg_temp_hyst[r1], data->reg_temp_hyst[r2]);
+ swap(data->reg_temp_config[r1], data->reg_temp_config[r2]);
}
static void
--
2.4.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [lm-sensors] [PATCH 1/1 linux-next] hwmon: (w83627ehf) use swap() in w82627ehf_swap_tempreg()
@ 2015-06-10 16:33 ` Fabian Frederick
0 siblings, 0 replies; 4+ messages in thread
From: Fabian Frederick @ 2015-06-10 16:33 UTC (permalink / raw)
To: linux-kernel
Cc: Julia Lawall, Fabian Frederick, Jean Delvare, Guenter Roeck, lm-sensors
Use kernel.h macro definition.
Thanks to Julia Lawall for Coccinelle scripting support.
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/hwmon/w83627ehf.c | 26 +++++---------------------
1 file changed, 5 insertions(+), 21 deletions(-)
diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
index b10353b..697007a 100644
--- a/drivers/hwmon/w83627ehf.c
+++ b/drivers/hwmon/w83627ehf.c
@@ -1937,27 +1937,11 @@ static inline void w83627ehf_init_device(struct w83627ehf_data *data,
static void w82627ehf_swap_tempreg(struct w83627ehf_data *data,
int r1, int r2)
{
- u16 tmp;
-
- tmp = data->temp_src[r1];
- data->temp_src[r1] = data->temp_src[r2];
- data->temp_src[r2] = tmp;
-
- tmp = data->reg_temp[r1];
- data->reg_temp[r1] = data->reg_temp[r2];
- data->reg_temp[r2] = tmp;
-
- tmp = data->reg_temp_over[r1];
- data->reg_temp_over[r1] = data->reg_temp_over[r2];
- data->reg_temp_over[r2] = tmp;
-
- tmp = data->reg_temp_hyst[r1];
- data->reg_temp_hyst[r1] = data->reg_temp_hyst[r2];
- data->reg_temp_hyst[r2] = tmp;
-
- tmp = data->reg_temp_config[r1];
- data->reg_temp_config[r1] = data->reg_temp_config[r2];
- data->reg_temp_config[r2] = tmp;
+ swap(data->temp_src[r1], data->temp_src[r2]);
+ swap(data->reg_temp[r1], data->reg_temp[r2]);
+ swap(data->reg_temp_over[r1], data->reg_temp_over[r2]);
+ swap(data->reg_temp_hyst[r1], data->reg_temp_hyst[r2]);
+ swap(data->reg_temp_config[r1], data->reg_temp_config[r2]);
}
static void
--
2.4.2
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/1 linux-next] hwmon: (w83627ehf) use swap() in w82627ehf_swap_tempreg()
2015-06-10 16:33 ` [lm-sensors] " Fabian Frederick
@ 2015-06-11 8:11 ` Jean Delvare
-1 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2015-06-11 8:11 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Julia Lawall, Guenter Roeck, lm-sensors
On Wed, 10 Jun 2015 18:33:01 +0200, Fabian Frederick wrote:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/hwmon/w83627ehf.c | 26 +++++---------------------
> 1 file changed, 5 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index b10353b..697007a 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1937,27 +1937,11 @@ static inline void w83627ehf_init_device(struct w83627ehf_data *data,
> static void w82627ehf_swap_tempreg(struct w83627ehf_data *data,
> int r1, int r2)
> {
> - u16 tmp;
> -
> - tmp = data->temp_src[r1];
> - data->temp_src[r1] = data->temp_src[r2];
> - data->temp_src[r2] = tmp;
> -
> - tmp = data->reg_temp[r1];
> - data->reg_temp[r1] = data->reg_temp[r2];
> - data->reg_temp[r2] = tmp;
> -
> - tmp = data->reg_temp_over[r1];
> - data->reg_temp_over[r1] = data->reg_temp_over[r2];
> - data->reg_temp_over[r2] = tmp;
> -
> - tmp = data->reg_temp_hyst[r1];
> - data->reg_temp_hyst[r1] = data->reg_temp_hyst[r2];
> - data->reg_temp_hyst[r2] = tmp;
> -
> - tmp = data->reg_temp_config[r1];
> - data->reg_temp_config[r1] = data->reg_temp_config[r2];
> - data->reg_temp_config[r2] = tmp;
> + swap(data->temp_src[r1], data->temp_src[r2]);
> + swap(data->reg_temp[r1], data->reg_temp[r2]);
> + swap(data->reg_temp_over[r1], data->reg_temp_over[r2]);
> + swap(data->reg_temp_hyst[r1], data->reg_temp_hyst[r2]);
> + swap(data->reg_temp_config[r1], data->reg_temp_config[r2]);
> }
>
> static void
Looks good. Applied, thanks.
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [lm-sensors] [PATCH 1/1 linux-next] hwmon: (w83627ehf) use swap() in w82627ehf_swap_tempreg()
@ 2015-06-11 8:11 ` Jean Delvare
0 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2015-06-11 8:11 UTC (permalink / raw)
To: Fabian Frederick; +Cc: linux-kernel, Julia Lawall, Guenter Roeck, lm-sensors
On Wed, 10 Jun 2015 18:33:01 +0200, Fabian Frederick wrote:
> Use kernel.h macro definition.
>
> Thanks to Julia Lawall for Coccinelle scripting support.
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/hwmon/w83627ehf.c | 26 +++++---------------------
> 1 file changed, 5 insertions(+), 21 deletions(-)
>
> diff --git a/drivers/hwmon/w83627ehf.c b/drivers/hwmon/w83627ehf.c
> index b10353b..697007a 100644
> --- a/drivers/hwmon/w83627ehf.c
> +++ b/drivers/hwmon/w83627ehf.c
> @@ -1937,27 +1937,11 @@ static inline void w83627ehf_init_device(struct w83627ehf_data *data,
> static void w82627ehf_swap_tempreg(struct w83627ehf_data *data,
> int r1, int r2)
> {
> - u16 tmp;
> -
> - tmp = data->temp_src[r1];
> - data->temp_src[r1] = data->temp_src[r2];
> - data->temp_src[r2] = tmp;
> -
> - tmp = data->reg_temp[r1];
> - data->reg_temp[r1] = data->reg_temp[r2];
> - data->reg_temp[r2] = tmp;
> -
> - tmp = data->reg_temp_over[r1];
> - data->reg_temp_over[r1] = data->reg_temp_over[r2];
> - data->reg_temp_over[r2] = tmp;
> -
> - tmp = data->reg_temp_hyst[r1];
> - data->reg_temp_hyst[r1] = data->reg_temp_hyst[r2];
> - data->reg_temp_hyst[r2] = tmp;
> -
> - tmp = data->reg_temp_config[r1];
> - data->reg_temp_config[r1] = data->reg_temp_config[r2];
> - data->reg_temp_config[r2] = tmp;
> + swap(data->temp_src[r1], data->temp_src[r2]);
> + swap(data->reg_temp[r1], data->reg_temp[r2]);
> + swap(data->reg_temp_over[r1], data->reg_temp_over[r2]);
> + swap(data->reg_temp_hyst[r1], data->reg_temp_hyst[r2]);
> + swap(data->reg_temp_config[r1], data->reg_temp_config[r2]);
> }
>
> static void
Looks good. Applied, thanks.
--
Jean Delvare
SUSE L3 Support
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-06-11 8:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-10 16:33 [PATCH 1/1 linux-next] hwmon: (w83627ehf) use swap() in w82627ehf_swap_tempreg() Fabian Frederick
2015-06-10 16:33 ` [lm-sensors] " Fabian Frederick
2015-06-11 8:11 ` Jean Delvare
2015-06-11 8:11 ` [lm-sensors] " Jean Delvare
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.