* [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers
@ 2015-06-11 16:57 Ian Jackson
2015-06-12 3:48 ` Juergen Gross
2015-06-12 8:37 ` Ian Campbell
0 siblings, 2 replies; 5+ messages in thread
From: Ian Jackson @ 2015-06-11 16:57 UTC (permalink / raw)
To: xen-devel; +Cc: Juergen Gross, Wei Liu, Ian Jackson, Ian Campbell
Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Ian Campbell <ian.campbell@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Juergen Gross <jgross@suse.com>
---
tools/libxl/libxl_internal.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
index 465aaaa..bfc0729 100644
--- a/tools/libxl/libxl_internal.h
+++ b/tools/libxl/libxl_internal.h
@@ -1911,8 +1911,9 @@ _hidden void libxl__egc_cleanup(libxl__egc *egc);
* All "slow" functions (see below for the exact definition) need to
* use the asynchronous operation ("ao") machinery. The function
* should take a parameter const libxl_asyncop_how *ao_how and must
- * start with a call to AO_INITIATOR_ENTRY. These functions MAY NOT
- * be called from inside libxl, because they can cause reentrancy
+ * start with a call to AO_CREATE or equivalent. These functions MAY
+ * NOT be called from inside libxl (regardless of what is passed for
+ * ao_how), because they can cause reentrancy hazards due to
* callbacks.
*
* For the same reason functions taking an ao_how may make themselves
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers
2015-06-11 16:57 [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers Ian Jackson
@ 2015-06-12 3:48 ` Juergen Gross
2015-06-12 11:16 ` Ian Jackson
2015-06-12 8:37 ` Ian Campbell
1 sibling, 1 reply; 5+ messages in thread
From: Juergen Gross @ 2015-06-12 3:48 UTC (permalink / raw)
To: Ian Jackson, xen-devel; +Cc: Wei Liu, Ian Campbell
On 06/11/2015 06:57 PM, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
> ---
> tools/libxl/libxl_internal.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 465aaaa..bfc0729 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1911,8 +1911,9 @@ _hidden void libxl__egc_cleanup(libxl__egc *egc);
> * All "slow" functions (see below for the exact definition) need to
> * use the asynchronous operation ("ao") machinery. The function
> * should take a parameter const libxl_asyncop_how *ao_how and must
> - * start with a call to AO_INITIATOR_ENTRY. These functions MAY NOT
> - * be called from inside libxl, because they can cause reentrancy
> + * start with a call to AO_CREATE or equivalent. These functions MAY
> + * NOT be called from inside libxl (regardless of what is passed for
> + * ao_how), because they can cause reentrancy hazards due to
> * callbacks.
> *
> * For the same reason functions taking an ao_how may make themselves
>
Now it's 100% clear what to avoid.
Acked-by: Juergen Gross <jgross@suse.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers
2015-06-11 16:57 [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers Ian Jackson
2015-06-12 3:48 ` Juergen Gross
@ 2015-06-12 8:37 ` Ian Campbell
2015-06-12 11:07 ` Ian Jackson
1 sibling, 1 reply; 5+ messages in thread
From: Ian Campbell @ 2015-06-12 8:37 UTC (permalink / raw)
To: Ian Jackson; +Cc: Juergen Gross, xen-devel, Wei Liu
On Thu, 2015-06-11 at 17:57 +0100, Ian Jackson wrote:
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Juergen Gross <jgross@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
AO_INITIATOR_ENTRY was just a stray remainder of some wip name?
> ---
> tools/libxl/libxl_internal.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/libxl/libxl_internal.h b/tools/libxl/libxl_internal.h
> index 465aaaa..bfc0729 100644
> --- a/tools/libxl/libxl_internal.h
> +++ b/tools/libxl/libxl_internal.h
> @@ -1911,8 +1911,9 @@ _hidden void libxl__egc_cleanup(libxl__egc *egc);
> * All "slow" functions (see below for the exact definition) need to
> * use the asynchronous operation ("ao") machinery. The function
> * should take a parameter const libxl_asyncop_how *ao_how and must
> - * start with a call to AO_INITIATOR_ENTRY. These functions MAY NOT
> - * be called from inside libxl, because they can cause reentrancy
> + * start with a call to AO_CREATE or equivalent. These functions MAY
> + * NOT be called from inside libxl (regardless of what is passed for
> + * ao_how), because they can cause reentrancy hazards due to
> * callbacks.
> *
> * For the same reason functions taking an ao_how may make themselves
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers
2015-06-12 8:37 ` Ian Campbell
@ 2015-06-12 11:07 ` Ian Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Ian Jackson @ 2015-06-12 11:07 UTC (permalink / raw)
To: Ian Campbell; +Cc: Juergen Gross, xen-devel, Wei Liu
Ian Campbell writes ("Re: [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers"):
> On Thu, 2015-06-11 at 17:57 +0100, Ian Jackson wrote:
> > Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > CC: Ian Campbell <ian.campbell@citrix.com>
> > CC: Wei Liu <wei.liu2@citrix.com>
> > CC: Juergen Gross <jgross@suse.com>
>
> Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> AO_INITIATOR_ENTRY was just a stray remainder of some wip name?
Yes.
Thanks,
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers
2015-06-12 3:48 ` Juergen Gross
@ 2015-06-12 11:16 ` Ian Jackson
0 siblings, 0 replies; 5+ messages in thread
From: Ian Jackson @ 2015-06-12 11:16 UTC (permalink / raw)
To: Juergen Gross; +Cc: Wei Liu, xen-devel, Ian Jackson, Ian Campbell
Juergen Gross writes ("Re: [Xen-devel] [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers"):
> Now it's 100% clear what to avoid.
>
> Acked-by: Juergen Gross <jgross@suse.com>
Thanks, pushed.
Ian.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-06-12 11:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-11 16:57 [PATCH] libxl: libxl_internal.h: Clarify ao rule against internal callers Ian Jackson
2015-06-12 3:48 ` Juergen Gross
2015-06-12 11:16 ` Ian Jackson
2015-06-12 8:37 ` Ian Campbell
2015-06-12 11:07 ` Ian Jackson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.