All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Duc Dang <dhdang@apm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Marcin Juszkiewicz <mjuszkiewicz@redhat.com>,
	Tanmay Inamdar <tinamdar@apm.com>, <patches@apm.com>
Subject: Re: [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe
Date: Fri, 12 Jun 2015 11:51:54 +0100	[thread overview]
Message-ID: <1434106314.30003.199.camel@citrix.com> (raw)
In-Reply-To: <1434053294-10962-1-git-send-email-dhdang@apm.com>

On Thu, 2015-06-11 at 13:08 -0700, Duc Dang wrote:
> X-Gene v1 PCIe controller has a bug in Configuration Request Retry
> Status (CRS) logic:
>   When CPU tries to read Vendor ID and Device ID of not-existed
>   remote device, the controller returns 0xFFFF0001 instead of
>   0xFFFFFFFF; this will add significant delay in boot time as
>   pci_bus_read_dev_vendor_id will wait for 60 seconds before
>   giving up.
> 
> So for X-Gene v1 PCIe controllers, disable CRS capability
> advertisement by clearing CRS Software Visibility bit before
> returning the Root Capability value to the callers. This is done
> by implementing X-Gene PCIe specific xgene_pcie_config_read32 for
> CFG read accesses to replace the generic default pci_generic_config_read32
> function.
> 
> Signed-off-by: Duc Dang <dhdang@apm.com>

Applied onto v4.1-rc7 and:
Tested-by: Ian Campbell <ian.campbell@citrix.com>

Thanks!



WARNING: multiple messages have this Message-ID (diff)
From: ian.campbell@citrix.com (Ian Campbell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe
Date: Fri, 12 Jun 2015 11:51:54 +0100	[thread overview]
Message-ID: <1434106314.30003.199.camel@citrix.com> (raw)
In-Reply-To: <1434053294-10962-1-git-send-email-dhdang@apm.com>

On Thu, 2015-06-11 at 13:08 -0700, Duc Dang wrote:
> X-Gene v1 PCIe controller has a bug in Configuration Request Retry
> Status (CRS) logic:
>   When CPU tries to read Vendor ID and Device ID of not-existed
>   remote device, the controller returns 0xFFFF0001 instead of
>   0xFFFFFFFF; this will add significant delay in boot time as
>   pci_bus_read_dev_vendor_id will wait for 60 seconds before
>   giving up.
> 
> So for X-Gene v1 PCIe controllers, disable CRS capability
> advertisement by clearing CRS Software Visibility bit before
> returning the Root Capability value to the callers. This is done
> by implementing X-Gene PCIe specific xgene_pcie_config_read32 for
> CFG read accesses to replace the generic default pci_generic_config_read32
> function.
> 
> Signed-off-by: Duc Dang <dhdang@apm.com>

Applied onto v4.1-rc7 and:
Tested-by: Ian Campbell <ian.campbell@citrix.com>

Thanks!

  parent reply	other threads:[~2015-06-12 10:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-11 20:08 [PATCH 1/1] PCI: X-Gene: Disable Configuration Request Retry Status for X-Gene v1 PCIe Duc Dang
2015-06-11 20:08 ` Duc Dang
2015-06-12  9:04 ` Marcin Juszkiewicz
2015-06-12  9:04   ` Marcin Juszkiewicz
2015-06-12 10:51 ` Ian Campbell [this message]
2015-06-12 10:51   ` Ian Campbell
2015-06-12 21:59 ` Bjorn Helgaas
2015-06-12 21:59   ` Bjorn Helgaas
2015-06-12 22:10   ` Duc Dang
2015-06-12 22:10     ` Duc Dang
2015-06-12 23:08     ` Bjorn Helgaas
2015-06-12 23:08       ` Bjorn Helgaas
2015-06-13  0:35       ` [PATCH v2 " Duc Dang
2015-06-13  0:35         ` Duc Dang
2015-06-18 17:55         ` Bjorn Helgaas
2015-06-18 17:55           ` Bjorn Helgaas
2015-06-18 18:11           ` Duc Dang
2015-06-18 18:11             ` Duc Dang
2015-06-18 20:02           ` Bjorn Helgaas
2015-06-18 20:02             ` Bjorn Helgaas
2015-06-18 18:00         ` Tanmay Inamdar
2015-06-18 18:00           ` Tanmay Inamdar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434106314.30003.199.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=bhelgaas@google.com \
    --cc=dhdang@apm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mjuszkiewicz@redhat.com \
    --cc=patches@apm.com \
    --cc=tinamdar@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.