From: Ingo Molnar <mingo@kernel.org> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andy Lutomirski <luto@amacapital.net>, Andrew Morton <akpm@linux-foundation.org>, Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>, Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, Linus Torvalds <torvalds@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Waiman Long <Waiman.Long@hp.com> Subject: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code Date: Sat, 13 Jun 2015 11:49:10 +0200 [thread overview] Message-ID: <1434188955-31397-8-git-send-email-mingo@kernel.org> (raw) In-Reply-To: <1434188955-31397-1-git-send-email-mingo@kernel.org> xen_mm_pin_all()/unpin_all() are used to implement full guest instance suspend/restore. It's a stop-all method that needs to iterate through all allocated pgds in the system to fix them up for Xen's use. This code uses pgd_list, probably because it was an easy interface. But we want to remove the pgd_list, so convert the code over to walk all tasks in the system. This is an equivalent method. (As I don't use Xen this is was only build tested.) Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Waiman Long <Waiman.Long@hp.com> Cc: linux-mm@kvack.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/xen/mmu.c | 51 ++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c index dd151b2045b0..70a3df5b0b54 100644 --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -853,15 +853,27 @@ static void xen_pgd_pin(struct mm_struct *mm) */ void xen_mm_pin_all(void) { - struct page *page; + struct task_struct *g, *p; - spin_lock(&pgd_lock); + spin_lock(&pgd_lock); /* Implies rcu_read_lock() for the task list iteration: */ - list_for_each_entry(page, &pgd_list, lru) { - if (!PagePinned(page)) { - __xen_pgd_pin(&init_mm, (pgd_t *)page_address(page)); - SetPageSavePinned(page); + for_each_process_thread(g, p) { + struct mm_struct *mm; + struct page *page; + pgd_t *pgd; + + task_lock(p); + mm = p->mm; + if (mm) { + pgd = mm->pgd; + page = virt_to_page(pgd); + + if (!PagePinned(page)) { + __xen_pgd_pin(&init_mm, pgd); + SetPageSavePinned(page); + } } + task_unlock(p); } spin_unlock(&pgd_lock); @@ -967,19 +979,32 @@ static void xen_pgd_unpin(struct mm_struct *mm) */ void xen_mm_unpin_all(void) { - struct page *page; + struct task_struct *g, *p; - spin_lock(&pgd_lock); + spin_lock(&pgd_lock); /* Implies rcu_read_lock() for the task list iteration: */ - list_for_each_entry(page, &pgd_list, lru) { - if (PageSavePinned(page)) { - BUG_ON(!PagePinned(page)); - __xen_pgd_unpin(&init_mm, (pgd_t *)page_address(page)); - ClearPageSavePinned(page); + for_each_process_thread(g, p) { + struct mm_struct *mm; + struct page *page; + pgd_t *pgd; + + task_lock(p); + mm = p->mm; + if (mm) { + pgd = mm->pgd; + page = virt_to_page(pgd); + + if (PageSavePinned(page)) { + BUG_ON(!PagePinned(page)); + __xen_pgd_unpin(&init_mm, pgd); + ClearPageSavePinned(page); + } } + task_unlock(p); } spin_unlock(&pgd_lock); + rcu_read_unlock(); } static void xen_activate_mm(struct mm_struct *prev, struct mm_struct *next) -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org> To: linux-kernel@vger.kernel.org Cc: linux-mm@kvack.org, Andy Lutomirski <luto@amacapital.net>, Andrew Morton <akpm@linux-foundation.org>, Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>, Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>, "H. Peter Anvin" <hpa@zytor.com>, Linus Torvalds <torvalds@linux-foundation.org>, Oleg Nesterov <oleg@redhat.com>, Thomas Gleixner <tglx@linutronix.de>, Waiman Long <Waiman.Long@hp.com> Subject: [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code Date: Sat, 13 Jun 2015 11:49:10 +0200 [thread overview] Message-ID: <1434188955-31397-8-git-send-email-mingo@kernel.org> (raw) In-Reply-To: <1434188955-31397-1-git-send-email-mingo@kernel.org> xen_mm_pin_all()/unpin_all() are used to implement full guest instance suspend/restore. It's a stop-all method that needs to iterate through all allocated pgds in the system to fix them up for Xen's use. This code uses pgd_list, probably because it was an easy interface. But we want to remove the pgd_list, so convert the code over to walk all tasks in the system. This is an equivalent method. (As I don't use Xen this is was only build tested.) Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Lutomirski <luto@amacapital.net> Cc: Borislav Petkov <bp@alien8.de> Cc: Brian Gerst <brgerst@gmail.com> Cc: Denys Vlasenko <dvlasenk@redhat.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Oleg Nesterov <oleg@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Waiman Long <Waiman.Long@hp.com> Cc: linux-mm@kvack.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- arch/x86/xen/mmu.c | 51 ++++++++++++++++++++++++++++++++++++++------------- 1 file changed, 38 insertions(+), 13 deletions(-) diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c index dd151b2045b0..70a3df5b0b54 100644 --- a/arch/x86/xen/mmu.c +++ b/arch/x86/xen/mmu.c @@ -853,15 +853,27 @@ static void xen_pgd_pin(struct mm_struct *mm) */ void xen_mm_pin_all(void) { - struct page *page; + struct task_struct *g, *p; - spin_lock(&pgd_lock); + spin_lock(&pgd_lock); /* Implies rcu_read_lock() for the task list iteration: */ - list_for_each_entry(page, &pgd_list, lru) { - if (!PagePinned(page)) { - __xen_pgd_pin(&init_mm, (pgd_t *)page_address(page)); - SetPageSavePinned(page); + for_each_process_thread(g, p) { + struct mm_struct *mm; + struct page *page; + pgd_t *pgd; + + task_lock(p); + mm = p->mm; + if (mm) { + pgd = mm->pgd; + page = virt_to_page(pgd); + + if (!PagePinned(page)) { + __xen_pgd_pin(&init_mm, pgd); + SetPageSavePinned(page); + } } + task_unlock(p); } spin_unlock(&pgd_lock); @@ -967,19 +979,32 @@ static void xen_pgd_unpin(struct mm_struct *mm) */ void xen_mm_unpin_all(void) { - struct page *page; + struct task_struct *g, *p; - spin_lock(&pgd_lock); + spin_lock(&pgd_lock); /* Implies rcu_read_lock() for the task list iteration: */ - list_for_each_entry(page, &pgd_list, lru) { - if (PageSavePinned(page)) { - BUG_ON(!PagePinned(page)); - __xen_pgd_unpin(&init_mm, (pgd_t *)page_address(page)); - ClearPageSavePinned(page); + for_each_process_thread(g, p) { + struct mm_struct *mm; + struct page *page; + pgd_t *pgd; + + task_lock(p); + mm = p->mm; + if (mm) { + pgd = mm->pgd; + page = virt_to_page(pgd); + + if (PageSavePinned(page)) { + BUG_ON(!PagePinned(page)); + __xen_pgd_unpin(&init_mm, pgd); + ClearPageSavePinned(page); + } } + task_unlock(p); } spin_unlock(&pgd_lock); + rcu_read_unlock(); } static void xen_activate_mm(struct mm_struct *prev, struct mm_struct *next) -- 2.1.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-13 9:50 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-13 9:49 [PATCH 00/12, v2] x86/mm: Implement lockless pgd_alloc()/pgd_free() Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 01/12] x86/mm/pat: Don't free PGD entries on memory unmap Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 02/12] x86/mm/hotplug: Remove pgd_list use from the memory hotplug code Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 19:24 ` Oleg Nesterov 2015-06-13 19:24 ` Oleg Nesterov 2015-06-14 7:36 ` Ingo Molnar 2015-06-14 7:36 ` Ingo Molnar 2015-06-14 19:24 ` Oleg Nesterov 2015-06-14 19:24 ` Oleg Nesterov 2015-06-14 19:38 ` Oleg Nesterov 2015-06-14 19:38 ` Oleg Nesterov 2015-06-15 0:40 ` Paul E. McKenney 2015-06-15 0:40 ` Paul E. McKenney 2015-06-15 20:33 ` Ingo Molnar 2015-06-15 20:33 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 03/12] x86/mm/hotplug: Don't remove PGD entries in remove_pagetable() Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 04/12] x86/mm/hotplug: Simplify sync_global_pgds() Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 05/12] mm: Introduce arch_pgd_init_late() Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 06/12] x86/mm: Enable and use the arch_pgd_init_late() method Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar [this message] 2015-06-13 9:49 ` [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code Ingo Molnar 2015-06-14 8:26 ` Ingo Molnar 2015-06-14 8:26 ` Ingo Molnar 2015-06-15 9:05 ` Ian Campbell 2015-06-15 9:05 ` Ian Campbell 2015-06-15 9:05 ` Ian Campbell 2015-06-15 10:30 ` David Vrabel 2015-06-15 10:30 ` David Vrabel 2015-06-15 20:35 ` Ingo Molnar 2015-06-15 20:35 ` Ingo Molnar 2015-06-15 20:35 ` Ingo Molnar 2015-06-16 14:15 ` David Vrabel 2015-06-16 14:15 ` David Vrabel 2015-06-16 14:15 ` David Vrabel 2015-06-16 14:19 ` Boris Ostrovsky 2015-06-16 14:19 ` Boris Ostrovsky 2015-06-16 14:19 ` Boris Ostrovsky 2015-06-16 14:27 ` David Vrabel 2015-06-16 14:27 ` David Vrabel 2015-06-16 14:27 ` David Vrabel 2015-06-15 10:30 ` David Vrabel 2015-06-13 9:49 ` [PATCH 08/12] x86/mm: Remove pgd_list use from vmalloc_sync_all() Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 09/12] x86/mm/pat/32: Remove pgd_list use from the PAT code Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 10/12] x86/mm: Make pgd_alloc()/pgd_free() lockless Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 11/12] x86/mm: Remove pgd_list leftovers Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 9:49 ` [PATCH 12/12] x86/mm: Simplify pgd_alloc() Ingo Molnar 2015-06-13 9:49 ` Ingo Molnar 2015-06-13 18:58 ` why do we need vmalloc_sync_all? Oleg Nesterov 2015-06-13 18:58 ` Oleg Nesterov 2015-06-14 7:59 ` Ingo Molnar 2015-06-14 7:59 ` Ingo Molnar 2015-06-14 20:06 ` Oleg Nesterov 2015-06-14 20:06 ` Oleg Nesterov 2015-06-15 2:47 ` Andi Kleen 2015-06-15 2:47 ` Andi Kleen 2015-06-15 2:57 ` Andy Lutomirski 2015-06-15 2:57 ` Andy Lutomirski 2015-06-15 20:28 ` Ingo Molnar 2015-06-15 20:28 ` Ingo Molnar 2015-06-15 20:48 ` Andy Lutomirski 2015-06-15 20:48 ` Andy Lutomirski -- strict thread matches above, loose matches on Subject: below -- 2015-06-11 14:07 [RFC PATCH 00/12] x86/mm: Implement lockless pgd_alloc()/pgd_free() Ingo Molnar 2015-06-11 14:07 ` [PATCH 07/12] x86/virt/guest/xen: Remove use of pgd_list from the Xen guest code Ingo Molnar 2015-06-11 20:37 ` Linus Torvalds 2015-06-11 20:41 ` Linus Torvalds 2015-06-12 7:23 ` Ingo Molnar [not found] ` <CA+55aFxXM=DN32JqNmJ=JoMum5OPnsRohCry-=2T=LabX2hzVQ@mail.gmail.com> 2015-06-12 8:04 ` Ingo Molnar 2015-06-12 20:38 ` Oleg Nesterov 2015-06-12 20:53 ` Oleg Nesterov 2015-06-12 22:30 ` Boris Ostrovsky 2015-06-12 23:36 ` Oleg Nesterov 2015-06-13 7:26 ` Ingo Molnar 2015-06-13 18:00 ` Oleg Nesterov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1434188955-31397-8-git-send-email-mingo@kernel.org \ --to=mingo@kernel.org \ --cc=Waiman.Long@hp.com \ --cc=akpm@linux-foundation.org \ --cc=bp@alien8.de \ --cc=brgerst@gmail.com \ --cc=dvlasenk@redhat.com \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=luto@amacapital.net \ --cc=oleg@redhat.com \ --cc=peterz@infradead.org \ --cc=tglx@linutronix.de \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.