All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alan Cox <alan@linux.intel.com>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: linux-kernel@vger.kernel.org, linux-pcmica@lists.infradead.org
Subject: Re: [PATCH 4/5] pcmcia: handle anonymous cards by generating a fake CIS
Date: Mon, 15 Jun 2015 13:10:55 +0100	[thread overview]
Message-ID: <1434370255.25843.8.camel@linux.intel.com> (raw)
In-Reply-To: <20150614195246.GA13314@light.dominikbrodowski.net>

> Unfortunately, this patch does not work well with all of the callers of
> pccard_validate_cis(). While it helps for ds.c:pcmcia_card_add() and does
> not matter for cistpl.c:pccard_show_cis(), it breaks the callback in
> rsrc_nonstatic.c:readable():

I'm not sure it's the right way to do readable() but we seem to be stuck
with that anyway.

The change looks good to me, and I will try and test it soon but it may
take some time due to various other things going on in life. Can you
submit it for 4.2 anyway and give it a bit of time for any screaming
then push to stable ? The number of people using anonymous cards is
pretty small these days so I think it's better to fix the regression you
have and worry about anonymous cards as a secondary thing.

Alan




  reply	other threads:[~2015-06-15 12:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 21:28 [PATCH 0/5] pcmcia: 64bit fixes, anonymous cards, other bugs Alan Cox
2014-12-04 21:28 ` [PATCH 1/5] pcmcia: correct types Alan Cox
2014-12-04 21:29 ` [PATCH 2/5] pcmcia cis: on an out of range CIS read return 0xff, don't just warn Alan Cox
2014-12-04 21:30 ` [PATCH 3/5] pcmcia: Fix requery Alan Cox
2014-12-04 21:30 ` [PATCH 4/5] pcmcia: handle anonymous cards by generating a fake CIS Alan Cox
2015-06-14 19:52   ` Dominik Brodowski
2015-06-15 12:10     ` Alan Cox [this message]
2015-06-16  6:19       ` Dominik Brodowski
2014-12-04 21:31 ` [PATCH 5/5] pcmcia: add a new resource manager for non ISA systems Alan Cox
2015-05-30 14:40   ` Dominik Brodowski
2015-06-01 13:59     ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434370255.25843.8.camel@linux.intel.com \
    --to=alan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pcmica@lists.infradead.org \
    --cc=linux@dominikbrodowski.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.