All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fuse: initialize fc->release before calling it
@ 2015-06-17  0:28 Ashish Samant
  2015-06-17  2:10 ` Greg KH
  0 siblings, 1 reply; 3+ messages in thread
From: Ashish Samant @ 2015-06-17  0:28 UTC (permalink / raw)
  To: ashish.samant; +Cc: stable

fc->release is called from fuse_conn_put() which was used in the error
cleanup before fc->release was initialized.

Signed-off-by: Ashish Samant <ashish.samant@oracle.com>
Fixes: a325f9b92273 ("fuse: update fuse_conn_init() and separate out fuse_conn_kill()")
Cc: <stable@vger.kernel.org> #v2.6.31+
---
 fs/fuse/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 082ac1c..cec8abb 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1026,6 +1026,7 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent)
 		goto err_fput;
 
 	fuse_conn_init(fc);
+	fc->release = fuse_free_conn;
 
 	fc->dev = sb->s_dev;
 	fc->sb = sb;
@@ -1040,7 +1041,6 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent)
 		fc->dont_mask = 1;
 	sb->s_flags |= MS_POSIXACL;
 
-	fc->release = fuse_free_conn;
 	fc->flags = d.flags;
 	fc->user_id = d.user_id;
 	fc->group_id = d.group_id;
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] fuse: initialize fc->release before calling it
  2015-06-17  0:28 [PATCH] fuse: initialize fc->release before calling it Ashish Samant
@ 2015-06-17  2:10 ` Greg KH
  0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2015-06-17  2:10 UTC (permalink / raw)
  To: Ashish Samant; +Cc: stable

On Tue, Jun 16, 2015 at 05:28:29PM -0700, Ashish Samant wrote:
> fc->release is called from fuse_conn_put() which was used in the error
> cleanup before fc->release was initialized.
> 
> Signed-off-by: Ashish Samant <ashish.samant@oracle.com>
> Fixes: a325f9b92273 ("fuse: update fuse_conn_init() and separate out fuse_conn_kill()")
> Cc: <stable@vger.kernel.org> #v2.6.31+
> ---
>  fs/fuse/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Please use scripts/get_maintainers.pl to determine the proper people and
mailing lists to send patches to.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] fuse: initialize fc->release before calling it
@ 2015-06-17  0:30 Ashish Samant
  0 siblings, 0 replies; 3+ messages in thread
From: Ashish Samant @ 2015-06-17  0:30 UTC (permalink / raw)
  To: miklos; +Cc: srinivas.eeda, ashish.samant, stable

fc->release is called from fuse_conn_put() which was used in the error
cleanup before fc->release was initialized.

Signed-off-by: Ashish Samant <ashish.samant@oracle.com>
Fixes: a325f9b92273 ("fuse: update fuse_conn_init() and separate out fuse_conn_kill()")
Cc: <stable@vger.kernel.org> #v2.6.31+
---
 fs/fuse/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c
index 082ac1c..cec8abb 100644
--- a/fs/fuse/inode.c
+++ b/fs/fuse/inode.c
@@ -1026,6 +1026,7 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent)
 		goto err_fput;
 
 	fuse_conn_init(fc);
+	fc->release = fuse_free_conn;
 
 	fc->dev = sb->s_dev;
 	fc->sb = sb;
@@ -1040,7 +1041,6 @@ static int fuse_fill_super(struct super_block *sb, void *data, int silent)
 		fc->dont_mask = 1;
 	sb->s_flags |= MS_POSIXACL;
 
-	fc->release = fuse_free_conn;
 	fc->flags = d.flags;
 	fc->user_id = d.user_id;
 	fc->group_id = d.group_id;
-- 
1.8.3.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-06-17  2:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-17  0:28 [PATCH] fuse: initialize fc->release before calling it Ashish Samant
2015-06-17  2:10 ` Greg KH
2015-06-17  0:30 Ashish Samant

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.