* [prelink-cross][PATCH 1/1] rtld: remove if check before free
@ 2015-06-23 12:28 Maninder Singh
2015-09-11 14:10 ` Mark Hatle
0 siblings, 1 reply; 2+ messages in thread
From: Maninder Singh @ 2015-06-23 12:28 UTC (permalink / raw)
To: mark.hatle, yocto; +Cc: Maninder Singh, pankaj.m
No need of explicit NULL check before free
Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
---
trunk/src/rtld/rtld.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/trunk/src/rtld/rtld.c b/trunk/src/rtld/rtld.c
index 35dfde7..3ed1db3 100644
--- a/trunk/src/rtld/rtld.c
+++ b/trunk/src/rtld/rtld.c
@@ -1270,7 +1270,6 @@ process_one_dso (DSO *dso, int host_paths)
(uint32_t) l->l_map_start);
}
- if (filename)
free (filename);
cur_dso_ent = cur_dso_ent->next;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [prelink-cross][PATCH 1/1] rtld: remove if check before free
2015-06-23 12:28 [prelink-cross][PATCH 1/1] rtld: remove if check before free Maninder Singh
@ 2015-09-11 14:10 ` Mark Hatle
0 siblings, 0 replies; 2+ messages in thread
From: Mark Hatle @ 2015-09-11 14:10 UTC (permalink / raw)
To: Maninder Singh, yocto; +Cc: pankaj.m
I did not merge this patch. While it's not strictly necessary to get for
allocation before free. It's also not a bad practice to do so.
--Mark
On 6/23/15 7:28 AM, Maninder Singh wrote:
> No need of explicit NULL check before free
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> ---
> trunk/src/rtld/rtld.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/trunk/src/rtld/rtld.c b/trunk/src/rtld/rtld.c
> index 35dfde7..3ed1db3 100644
> --- a/trunk/src/rtld/rtld.c
> +++ b/trunk/src/rtld/rtld.c
> @@ -1270,7 +1270,6 @@ process_one_dso (DSO *dso, int host_paths)
> (uint32_t) l->l_map_start);
> }
>
> - if (filename)
> free (filename);
>
> cur_dso_ent = cur_dso_ent->next;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-11 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-23 12:28 [prelink-cross][PATCH 1/1] rtld: remove if check before free Maninder Singh
2015-09-11 14:10 ` Mark Hatle
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.