All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Staging:rtl8192u: fixed coding style issues
@ 2015-06-24 18:05 Aldo Iljazi
  2015-07-15  2:49 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Aldo Iljazi @ 2015-06-24 18:05 UTC (permalink / raw)
  To: gregkh; +Cc: devel, linux-kernel

Fixed the following coding style issues:
r819xU_firmware.c:72: ERROR: space required after that ',' (ctx:VxO)
r819xU_firmware.c:72: ERROR: space required before that '&' (ctx:OxV)
r819xU_firmware.c:72: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:97: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:248: ERROR: space required after that ',' (ctx:VxO)
r819xU_firmware.c:248: ERROR: space required before that '&' (ctx:OxV)
r819xU_firmware.c:260: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:260: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:265: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:265: ERROR: space required after that ',' (ctx:VxV)
r819xU_firmware.c:325: ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Aldo Iljazi <aldoiljazi@openmailbox.org>
---
 drivers/staging/rtl8192u/r819xU_firmware.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8192u/r819xU_firmware.c b/drivers/staging/rtl8192u/r819xU_firmware.c
index d27b1e2..a7d3033 100644
--- a/drivers/staging/rtl8192u/r819xU_firmware.c
+++ b/drivers/staging/rtl8192u/r819xU_firmware.c
@@ -66,7 +66,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 		skb  = dev_alloc_skb(USB_HWDESC_HEADER_LEN + frag_length + 4);
 		if (!skb)
 			return false;
-		memcpy((unsigned char *)(skb->cb),&dev,sizeof(dev));
+		memcpy((unsigned char *)(skb->cb), &dev, sizeof(dev));
 		tcb_desc = (cb_desc *)(skb->cb + MAX_DEV_ADDR_SIZE);
 		tcb_desc->queue_index = TXCMD_QUEUE;
 		tcb_desc->bCmdOrInit = DESC_PACKET_TYPE_INIT;
@@ -91,7 +91,7 @@ static bool fw_download_code(struct net_device *dev, u8 *code_virtual_address,
 		if (!priv->ieee80211->check_nic_enough_desc(dev, index) ||
 		       (!skb_queue_empty(&priv->ieee80211->skb_waitQ[index])) ||
 		       (priv->ieee80211->queue_stop)) {
-			RT_TRACE(COMP_FIRMWARE,"=====================================================> tx full!\n");
+			RT_TRACE(COMP_FIRMWARE, "=====================================================> tx full!\n");
 			skb_queue_tail(&priv->ieee80211->skb_waitQ[tcb_desc->queue_index], skb);
 		} else {
 			priv->ieee80211->softmac_hard_start_xmit(skb, dev);
@@ -242,7 +242,7 @@ bool init_firmware(struct net_device *dev)
 		 * or read image file from array. Default load from IMG file
 		 */
 		if (rst_opt == OPT_SYSTEM_RESET) {
-			rc = request_firmware(&fw_entry, fw_name[init_step],&priv->udev->dev);
+			rc = request_firmware(&fw_entry, fw_name[init_step], &priv->udev->dev);
 			if (rc < 0) {
 				RT_TRACE(COMP_ERR, "request firmware fail!\n");
 				goto download_firmware_fail;
@@ -254,12 +254,12 @@ bool init_firmware(struct net_device *dev)
 			}
 
 			if (init_step != FW_INIT_STEP1_MAIN) {
-				memcpy(pfirmware->firmware_buf,fw_entry->data,fw_entry->size);
+				memcpy(pfirmware->firmware_buf, fw_entry->data, fw_entry->size);
 				mapped_file = pfirmware->firmware_buf;
 				file_length = fw_entry->size;
 			} else {
 				memset(pfirmware->firmware_buf, 0, 128);
-				memcpy(&pfirmware->firmware_buf[128],fw_entry->data,fw_entry->size);
+				memcpy(&pfirmware->firmware_buf[128], fw_entry->data, fw_entry->size);
 				mapped_file = pfirmware->firmware_buf;
 				file_length = fw_entry->size + 128;
 			}
@@ -319,7 +319,7 @@ bool init_firmware(struct net_device *dev)
 
 			rt_status = CPUcheck_firmware_ready(dev);
 			if (!rt_status) {
-				RT_TRACE(COMP_ERR, "CPUcheck_firmware_ready fail(%d)!\n",rt_status);
+				RT_TRACE(COMP_ERR, "CPUcheck_firmware_ready fail(%d)!\n", rt_status);
 				goto download_firmware_fail;
 			}
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Staging:rtl8192u: fixed coding style issues
  2015-06-24 18:05 [PATCH] Staging:rtl8192u: fixed coding style issues Aldo Iljazi
@ 2015-07-15  2:49 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2015-07-15  2:49 UTC (permalink / raw)
  To: Aldo Iljazi; +Cc: devel, linux-kernel

On Wed, Jun 24, 2015 at 09:05:04PM +0300, Aldo Iljazi wrote:
> Fixed the following coding style issues:
> r819xU_firmware.c:72: ERROR: space required after that ',' (ctx:VxO)
> r819xU_firmware.c:72: ERROR: space required before that '&' (ctx:OxV)
> r819xU_firmware.c:72: ERROR: space required after that ',' (ctx:VxV)
> r819xU_firmware.c:97: ERROR: space required after that ',' (ctx:VxV)
> r819xU_firmware.c:248: ERROR: space required after that ',' (ctx:VxO)
> r819xU_firmware.c:248: ERROR: space required before that '&' (ctx:OxV)
> r819xU_firmware.c:260: ERROR: space required after that ',' (ctx:VxV)
> r819xU_firmware.c:260: ERROR: space required after that ',' (ctx:VxV)
> r819xU_firmware.c:265: ERROR: space required after that ',' (ctx:VxV)
> r819xU_firmware.c:265: ERROR: space required after that ',' (ctx:VxV)
> r819xU_firmware.c:325: ERROR: space required after that ',' (ctx:VxV)
> 
> Signed-off-by: Aldo Iljazi <aldoiljazi@openmailbox.org>
> ---
>  drivers/staging/rtl8192u/r819xU_firmware.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)

Someone send this patch just before you did, sorry :(

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-15  2:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-24 18:05 [PATCH] Staging:rtl8192u: fixed coding style issues Aldo Iljazi
2015-07-15  2:49 ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.