[PATCH] OSSTest: some more info when capturing logs

[PATCH] OSSTest: some more info when capturing logs

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 987 bytes --]

more specifically:

 * '-n' switch to xl info, to show the topology
   of the host,
 * 'xl vcpu-list', to show what the various vcpus
   are up to.

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
 ts-logs-capture |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ts-logs-capture b/ts-logs-capture
index 2078459..2498416 100755
--- a/ts-logs-capture
+++ b/ts-logs-capture
@@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
 
     foreach my $cmd
         (
-         'xl info',
+         'xl info -n',
          'cat /proc/cpuinfo',
          'xl list',
+         'xl vcpu-list',
          'xm list',
          'xm list --long',
          'xenstore-ls -fp',

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] OSSTest: some more info when capturing logs

[Ian Campbell]

On Wed, 2015-06-24 at 18:11 +0200, Dario Faggioli wrote:
> more specifically:
> 
>  * '-n' switch to xl info, to show the topology
>    of the host,

Is the information from "xl info -n" a superset of that from "xl info"?
IOW could we just collect xl info -n and be done with it?

>  * 'xl vcpu-list', to show what the various vcpus
>    are up to.
> 
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> ---
>  ts-logs-capture |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/ts-logs-capture b/ts-logs-capture
> index 2078459..2498416 100755
> --- a/ts-logs-capture
> +++ b/ts-logs-capture
> @@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
>  
>      foreach my $cmd
>          (
> -         'xl info',
> +         'xl info -n',
>           'cat /proc/cpuinfo',
>           'xl list',
> +         'xl vcpu-list',
>           'xm list',
>           'xm list --long',
>           'xenstore-ls -fp',
> 

Re: [PATCH] OSSTest: some more info when capturing logs

[Dario Faggioli]

[-- Attachment #1.1: Type: text/plain, Size: 1054 bytes --]

On Thu, 2015-06-25 at 09:48 +0100, Ian Campbell wrote:
> On Wed, 2015-06-24 at 18:11 +0200, Dario Faggioli wrote:
> > more specifically:
> > 
> >  * '-n' switch to xl info, to show the topology
> >    of the host,
> 
> Is the information from "xl info -n" a superset of that from "xl info"?
>
Yes.

> IOW could we just collect xl info -n and be done with it?
> 
That's what the patch is doing:

> > @@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
> >  
> >      foreach my $cmd
> >          (
> > -         'xl info',
> > +         'xl info -n',
>
Perhaps the changelog was not so clear... in this case, "more info"
applies right because adding '-n' adds information, wrt not using it, or
at least that was what I meant.

Should I clarify and resend?

Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel

Re: [PATCH] OSSTest: some more info when capturing logs

[Ian Campbell]

On Thu, 2015-06-25 at 11:11 +0200, Dario Faggioli wrote:
> On Thu, 2015-06-25 at 09:48 +0100, Ian Campbell wrote:
> > On Wed, 2015-06-24 at 18:11 +0200, Dario Faggioli wrote:
> > > more specifically:
> > > 
> > >  * '-n' switch to xl info, to show the topology
> > >    of the host,
> > 
> > Is the information from "xl info -n" a superset of that from "xl info"?
> >
> Yes.
> 
> > IOW could we just collect xl info -n and be done with it?
> > 
> That's what the patch is doing:
> 
> > > @@ -153,9 +153,10 @@ sub fetch_logs_host_guests () {
> > >  
> > >      foreach my $cmd
> > >          (
> > > -         'xl info',
> > > +         'xl info -n',
> >
> Perhaps the changelog was not so clear... in this case, "more info"
> applies right because adding '-n' adds information, wrt not using it, or
> at least that was what I meant.
> 
> Should I clarify and resend?

No need, I should just learn to read a diff properly, sorry.

Acked-by: Ian Campbell <ian.campbell@citrix.com>