Re: [v4][PATCH 12/19] tools/libxl: passes rdm reservation policy

[Ian Campbell <ian.campbell@citrix.com>]

On Fri, 2015-06-26 at 16:53 +0800, Chen, Tiejun wrote:
> >>   B<BDF> is the PCI Bus/Device/Function of the physical device to pass-through.
> >> +B<rdm policy> is about how to handle conflict between reserving reserved device
> >
> > s/is about/specifies/
> 
> Okay.
> 
> and I think s/between/while/
> >
> >> +memory and guest address space. "strict" means an unsolved conflict leads to
> >
> > I think you mean "in" rather than "and"?
> 
> Actually, as you see I was originally trying to say " conflict between A 
> and B".
> 
> What about this?
> 
> B<rdm policy> specifies how to handle conflict between reserved device 
> memory space and guest address space...

I'd say either "handle conflicts between" or "handle any conflict
between".

> 
> >
> >
> >> +immediate VM crash, while "relaxed" allows VM moving forward with a warning
> >> +message thrown out. Here "strict" is default.
> >
> > "The default is "strict"".
> 
> Okay.
> 
> >
> > You've repeated the list of allowed values for this two or three times
> > now in the various docs, perhaps try and centralise on one definition
> > and cross reference instead?
> >
> 
> I will delete this last sentence and add this,
> 
> Please refer "reserve" option to the rdm option in xl.cfg.5.txt.

Say "xl.cfg(5)" which is a neutral reference to the manpage in any form.