[PATCH] w1: replace strict_strtol() with kstrtol()

[PATCH] w1: replace strict_strtol() with kstrtol()

[Jingoo Han]

The usage of strict_strtol() is not preferred, because
strict_strtol() is obsolete. Thus, kstrtol() should be
used.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/w1/w1.c |   12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 0459df8..46a8fd7 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -235,9 +235,11 @@ static ssize_t w1_master_attribute_store_search(struct device * dev,
 {
 	long tmp;
 	struct w1_master *md = dev_to_w1_master(dev);
+	int ret;
 
-	if (strict_strtol(buf, 0, &tmp) == -EINVAL)
-		return -EINVAL;
+	ret = kstrtol(buf, 0, &tmp);
+	if (ret)
+		return ret;
 
 	mutex_lock(&md->mutex);
 	md->search_count = tmp;
@@ -267,9 +269,11 @@ static ssize_t w1_master_attribute_store_pullup(struct device *dev,
 {
 	long tmp;
 	struct w1_master *md = dev_to_w1_master(dev);
+	int ret;
 
-	if (strict_strtol(buf, 0, &tmp) == -EINVAL)
-		return -EINVAL;
+	ret = kstrtol(buf, 0, &tmp);
+	if (ret)
+		return ret;
 
 	mutex_lock(&md->mutex);
 	md->enable_pullup = tmp;
-- 
1.7.10.4

Re: [PATCH] w1: replace strict_strtol() with kstrtol()

[Evgeniy Polyakov]

Hi everyone

19.07.2013, 11:16, "Jingoo Han" <jg1.han@samsung.com>:
> The usage of strict_strtol() is not preferred, because
> strict_strtol() is obsolete. Thus, kstrtol() should be
> used.

Looks good to me, although I do not really see the difference
Greg, please pull into your tree or suggest appropriate.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

Re: [PATCH] w1: replace strict_strtol() with kstrtol()

[GregKH]

On Tue, Jul 23, 2013 at 12:00:44AM +0400, Evgeniy Polyakov wrote:
> Hi everyone
> 
> 19.07.2013, 11:16, "Jingoo Han" <jg1.han@samsung.com>:
> > The usage of strict_strtol() is not preferred, because
> > strict_strtol() is obsolete. Thus, kstrtol() should be
> > used.
> 
> Looks good to me, although I do not really see the difference
> Greg, please pull into your tree or suggest appropriate.
> 
> Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

Can someone resend this, I don't seem to be able to find it...

thanks,

greg k-h

Re: [PATCH] w1: replace strict_strtol() with kstrtol()

[Рустафа Джамурахметов]

27.07.2013, 03:16, "GregKH" <greg@kroah.com>:
> On Tue, Jul 23, 2013 at 12:00:44AM +0400, Evgeniy Polyakov wrote:
>
>>  Hi everyone
>>
>>  19.07.2013, 11:16, "Jingoo Han" <jg1.han@samsung.com>:
>>>  The usage of strict_strtol() is not preferred, because
>>>  strict_strtol() is obsolete. Thus, kstrtol() should be
>>>  used.
>>  Looks good to me, although I do not really see the difference
>>  Greg, please pull into your tree or suggest appropriate.
>>
>>  Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
>
> Can someone resend this, I don't seem to be able to find it...

Looks like Andrew Morton picked it up today