[PATCH 1/1] SCSI/bfa: Use port pointer after NULL check

[PATCH 1/1] SCSI/bfa: Use port pointer after NULL check

[Maninder Singh]

Currently port pointer is derefrenced before NULL check.
So NULL check is misleading, Thus it is better to use port
pointer after NULL Check.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 drivers/scsi/bfa/bfa_fcs_lport.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index ff75ef8..542d5c6 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -5826,12 +5826,13 @@ bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port)
 	bfa_port_speed_t max_speed = 0;
 	struct bfa_port_attr_s port_attr;
 	bfa_port_speed_t port_speed, rport_speed;
-	bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+	bfa_boolean_t trl_enabled;
 
 
 	if (port == NULL)
 		return 0;
 
+	trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
 	fcs = port->fcs;
 
 	/* Get Physical port's current speed */
-- 
1.7.9.5

RE: [PATCH 1/1] SCSI/bfa: Use port pointer after NULL check

[Anil Gurumurthy]

[-- Attachment #1: Type: text/plain, Size: 1383 bytes --]

Acked-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>

-----Original Message-----
From: Maninder Singh [mailto:maninder1.s@samsung.com] 
Sent: 29 June 2015 10:51
To: Anil Gurumurthy; Sudarsana Kalluru; JBottomley@odin.com; linux-scsi
Cc: pankaj.m@samsung.com; Maninder Singh
Subject: [PATCH 1/1] SCSI/bfa: Use port pointer after NULL check

Currently port pointer is derefrenced before NULL check.
So NULL check is misleading, Thus it is better to use port pointer after NULL Check.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Reviewed-by: Akhilesh Kumar <akhilesh.k@samsung.com>
---
 drivers/scsi/bfa/bfa_fcs_lport.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/bfa/bfa_fcs_lport.c b/drivers/scsi/bfa/bfa_fcs_lport.c
index ff75ef8..542d5c6 100644
--- a/drivers/scsi/bfa/bfa_fcs_lport.c
+++ b/drivers/scsi/bfa/bfa_fcs_lport.c
@@ -5826,12 +5826,13 @@ bfa_fcs_lport_get_rport_max_speed(bfa_fcs_lport_t *port)
 	bfa_port_speed_t max_speed = 0;
 	struct bfa_port_attr_s port_attr;
 	bfa_port_speed_t port_speed, rport_speed;
-	bfa_boolean_t trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+	bfa_boolean_t trl_enabled;
 
 
 	if (port == NULL)
 		return 0;
 
+	trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
 	fcs = port->fcs;
 
 	/* Get Physical port's current speed */
--
1.7.9.5


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 4284 bytes --]