From: Lee Jones <lee.jones@linaro.org> To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: kernel@stlinux.com, broonie@kernel.org, lgirdwood@gmail.com, Lee Jones <lee.jones@linaro.org> Subject: [PATCH v2 9/9] regulator: pwm-regulator: Don't assign structure attributes right away Date: Tue, 7 Jul 2015 16:06:53 +0100 [thread overview] Message-ID: <1436281613-899-10-git-send-email-lee.jones@linaro.org> (raw) In-Reply-To: <1436281613-899-1-git-send-email-lee.jones@linaro.org> Perhaps this is just personal preference, but ... This patch introduces a new local variable to receive and test regulator initialisation data. It simplifies and cleans up the code making it that little bit easier to read and maintain. The local value is assigned to the structure attribute when all the others are. This is the way we usually do things. Prevents this kind of nonsense: this->is->just.silly = fetch_silly_value(&pointer); if (!this->is->just.silly) { printk("Silly value failed: %d\n", this->is->just.silly); return this->is->just.silly; } Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/regulator/pwm-regulator.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c index d5cb267..cb48208 100644 --- a/drivers/regulator/pwm-regulator.c +++ b/drivers/regulator/pwm-regulator.c @@ -218,6 +218,7 @@ static int pwm_regulator_init_continuous(struct platform_device *pdev, static int pwm_regulator_probe(struct platform_device *pdev) { + const struct regulator_init_data *init_data; struct pwm_regulator_data *drvdata; struct regulator_dev *regulator; struct regulator_config config = { }; @@ -240,14 +241,15 @@ static int pwm_regulator_probe(struct platform_device *pdev) if (ret) return ret; - config.init_data = of_get_regulator_init_data(&pdev->dev, np, - &pwm_regulator_desc); - if (!config.init_data) + init_data = of_get_regulator_init_data(&pdev->dev, np, + &pwm_regulator_desc); + if (!init_data) return -ENOMEM; config.of_node = np; config.dev = &pdev->dev; config.driver_data = drvdata; + config.init_data = init_data; drvdata->pwm = devm_pwm_get(&pdev->dev, NULL); if (IS_ERR(drvdata->pwm)) { -- 1.9.1
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 9/9] regulator: pwm-regulator: Don't assign structure attributes right away Date: Tue, 7 Jul 2015 16:06:53 +0100 [thread overview] Message-ID: <1436281613-899-10-git-send-email-lee.jones@linaro.org> (raw) In-Reply-To: <1436281613-899-1-git-send-email-lee.jones@linaro.org> Perhaps this is just personal preference, but ... This patch introduces a new local variable to receive and test regulator initialisation data. It simplifies and cleans up the code making it that little bit easier to read and maintain. The local value is assigned to the structure attribute when all the others are. This is the way we usually do things. Prevents this kind of nonsense: this->is->just.silly = fetch_silly_value(&pointer); if (!this->is->just.silly) { printk("Silly value failed: %d\n", this->is->just.silly); return this->is->just.silly; } Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/regulator/pwm-regulator.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c index d5cb267..cb48208 100644 --- a/drivers/regulator/pwm-regulator.c +++ b/drivers/regulator/pwm-regulator.c @@ -218,6 +218,7 @@ static int pwm_regulator_init_continuous(struct platform_device *pdev, static int pwm_regulator_probe(struct platform_device *pdev) { + const struct regulator_init_data *init_data; struct pwm_regulator_data *drvdata; struct regulator_dev *regulator; struct regulator_config config = { }; @@ -240,14 +241,15 @@ static int pwm_regulator_probe(struct platform_device *pdev) if (ret) return ret; - config.init_data = of_get_regulator_init_data(&pdev->dev, np, - &pwm_regulator_desc); - if (!config.init_data) + init_data = of_get_regulator_init_data(&pdev->dev, np, + &pwm_regulator_desc); + if (!init_data) return -ENOMEM; config.of_node = np; config.dev = &pdev->dev; config.driver_data = drvdata; + config.init_data = init_data; drvdata->pwm = devm_pwm_get(&pdev->dev, NULL); if (IS_ERR(drvdata->pwm)) { -- 1.9.1
next prev parent reply other threads:[~2015-07-07 15:08 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-07 15:06 [PATCH v2 0/9] regulator: pwm-regulator: Introduce continuous-mode Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 15:06 ` [PATCH v2 1/9] ARM: multi_v7_defconfig: Enable ST's PWM driver Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 15:06 ` [PATCH v2 2/9] ARM: multi_v7_defconfig: Enable ST's Power Reset driver Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 15:06 ` [PATCH v2 3/9] ARM: multi_v7_defconfig: Enable support for PWM Regulators Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 15:06 ` [PATCH v2 4/9] ARM: STi: STiH407: Move PWM nodes STiH407 => STiH407-family Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 15:06 ` [PATCH v2 5/9] ARM: STi: STiH407: Add PWM Regulator node Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 15:06 ` [PATCH v2 6/9] regulator: pwm-regulator: Re-write bindings Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 18:31 ` Applied "regulator: pwm-regulator: Re-write bindings" to the regulator tree Mark Brown 2015-07-09 8:01 ` [PATCH v2 6/9] regulator: pwm-regulator: Re-write bindings Boris Brezillon 2015-07-09 8:01 ` Boris Brezillon 2015-07-07 15:06 ` [PATCH v2 7/9] regulator: pwm-regulator: Add support for continuous-voltage Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 18:31 ` Applied "regulator: pwm-regulator: Add support for continuous-voltage" to the regulator tree Mark Brown 2015-07-07 15:06 ` [PATCH v2 8/9] regulator: pwm-regulator: Simplify voltage to duty-cycle call Lee Jones 2015-07-07 15:06 ` Lee Jones 2015-07-07 18:31 ` Applied "regulator: pwm-regulator: Simplify voltage to duty-cycle call" to the regulator tree Mark Brown 2015-07-07 15:06 ` Lee Jones [this message] 2015-07-07 15:06 ` [PATCH v2 9/9] regulator: pwm-regulator: Don't assign structure attributes right away Lee Jones 2015-07-09 6:30 ` [PATCH v2 0/9] regulator: pwm-regulator: Introduce continuous-mode Boris Brezillon 2015-07-09 6:30 ` Boris Brezillon 2015-07-09 11:51 ` Lee Jones 2015-07-09 11:51 ` Lee Jones 2015-07-09 13:14 ` Boris Brezillon 2015-07-09 13:14 ` Boris Brezillon 2015-07-09 15:44 ` Lee Jones 2015-07-09 15:44 ` Lee Jones 2015-07-09 16:25 ` Doug Anderson 2015-07-09 16:25 ` Doug Anderson 2015-07-09 17:20 ` Lee Jones 2015-07-09 17:20 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1436281613-899-10-git-send-email-lee.jones@linaro.org \ --to=lee.jones@linaro.org \ --cc=broonie@kernel.org \ --cc=kernel@stlinux.com \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.