* [PATCH] Drop owner assignment from i2c_driver (and platform left-overs)
@ 2015-07-10 6:36 Krzysztof Kozlowski
2015-07-10 6:36 ` [PATCH 1/2] tty: serial: Drop owner assignment from platform_driver Krzysztof Kozlowski
2015-07-10 6:36 ` [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10 6:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Ralf Baechle,
Krzysztof Kozlowski, Paul Burton, linux-serial, linux-kernel
Hi,
The i2c drivers also do not have to set 'owner' field because
i2c_register_driver() will do it instead.
'owner' is removed from i2c drivers, which I was able to compile
with allyesconfig (arm, arm64, i386, x86_64, ppc64).
Only compile-tested.
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
Best regards,
Krzysztof
Krzysztof Kozlowski (2):
tty: serial: Drop owner assignment from platform_driver
tty: serial: Drop owner assignment from i2c_driver
drivers/tty/serial/8250/8250_ingenic.c | 1 -
drivers/tty/serial/sc16is7xx.c | 1 -
2 files changed, 2 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/2] tty: serial: Drop owner assignment from platform_driver
2015-07-10 6:36 [PATCH] Drop owner assignment from i2c_driver (and platform left-overs) Krzysztof Kozlowski
@ 2015-07-10 6:36 ` Krzysztof Kozlowski
2015-07-10 6:36 ` [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10 6:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Ralf Baechle,
Krzysztof Kozlowski, Paul Burton, linux-serial, linux-kernel
platform_driver does not need to set an owner because
platform_driver_register() will set it.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/tty/serial/8250/8250_ingenic.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_ingenic.c b/drivers/tty/serial/8250/8250_ingenic.c
index 21bf81fe794f..7c1e4be48e7b 100644
--- a/drivers/tty/serial/8250/8250_ingenic.c
+++ b/drivers/tty/serial/8250/8250_ingenic.c
@@ -252,7 +252,6 @@ MODULE_DEVICE_TABLE(of, of_match);
static struct platform_driver ingenic_uart_platform_driver = {
.driver = {
.name = "ingenic-uart",
- .owner = THIS_MODULE,
.of_match_table = of_match,
},
.probe = ingenic_uart_probe,
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver
2015-07-10 6:36 [PATCH] Drop owner assignment from i2c_driver (and platform left-overs) Krzysztof Kozlowski
2015-07-10 6:36 ` [PATCH 1/2] tty: serial: Drop owner assignment from platform_driver Krzysztof Kozlowski
@ 2015-07-10 6:36 ` Krzysztof Kozlowski
2015-07-10 8:57 ` Rama Kiran Kumar Indrakanti
1 sibling, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2015-07-10 6:36 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby, Ralf Baechle,
Krzysztof Kozlowski, Paul Burton, linux-serial, linux-kernel
i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
The coccinelle script which generated the patch was sent here:
http://www.spinics.net/lists/kernel/msg2029903.html
---
drivers/tty/serial/sc16is7xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 9e6576004a42..bbeb33561737 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1369,7 +1369,6 @@ MODULE_DEVICE_TABLE(i2c, sc16is7xx_i2c_id_table);
static struct i2c_driver sc16is7xx_i2c_uart_driver = {
.driver = {
.name = SC16IS7XX_NAME,
- .owner = THIS_MODULE,
.of_match_table = of_match_ptr(sc16is7xx_dt_ids),
},
.probe = sc16is7xx_i2c_probe,
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver
2015-07-10 6:36 ` [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver Krzysztof Kozlowski
@ 2015-07-10 8:57 ` Rama Kiran Kumar Indrakanti
0 siblings, 0 replies; 5+ messages in thread
From: Rama Kiran Kumar Indrakanti @ 2015-07-10 8:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Greg Kroah-Hartman, Jiri Slaby,
Ralf Baechle, Paul Burton, linux-serial, linux-kernel
<br><br>> From: k.kozlowski@samsung.com<br>> To: gregkh@linuxfoundation.org; jslaby@suse.cz; ralf@linux-mips.org; k.kozlowski@samsung.com; paul.burton@imgtec.com; linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org<br>> Subject: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver<br>> Date: Fri, 10 Jul 2015 15:36:20 +0900<br>> <br>> i2c_driver does not need to set an owner because i2c_register_driver()<br>> will set it.<br>> <br>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com><br>> <br>> ---<br>> <br>> The coccinelle script which generated the patch was sent here:<br>> http://www.spinics.net/lists/kernel/msg2029903.html<br>> ---<br>> drivers/tty/serial/sc16is7xx.c | 1 -<br>> 1 file changed, 1 deletion(-)<br>> <br>> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c<br>> index 9e6576004a42..bbeb33561737 100644<br>> --- a/drivers/tty/serial/sc16is7xx.c<br>> +++ b/drivers/tty/serial/sc16is7xx.c<br>> @@ -1369,7 +1369,6 @@ MODULE_DEVICE_TABLE(i2c, sc16is7xx_i2c_id_table);<br>> static struct i2c_driver sc16is7xx_i2c_uart_driver = {<br>> .driver = {<br>> .name = SC16IS7XX_NAME,<br>> - .owner = THIS_MODULE,<br><br>Okay, is there an issue by doing this. Or its just a over doing things ?<br><br>> .of_match_table = of_match_ptr(sc16is7xx_dt_ids),<br>> },<br>> .probe = sc16is7xx_i2c_probe,<br>> -- <br>> 1.9.1<br>> <br>> --<br>> To unsubscribe from this list: send the line "unsubscribe linux-serial" in<br>> the body of a message to majordomo@vger.kernel.org<br>> More majordomo info at http://vger.kernel.org/majordomo-info.html<br>
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver
@ 2015-07-10 8:57 ` Rama Kiran Kumar Indrakanti
0 siblings, 0 replies; 5+ messages in thread
From: Rama Kiran Kumar Indrakanti @ 2015-07-10 8:57 UTC (permalink / raw)
To: Krzysztof Kozlowski, Greg Kroah-Hartman, Jiri Slaby,
Ralf Baechle, Paul Burton, linux-serial, linux-kernel
<br><br>> From: k.kozlowski@samsung.com<br>> To: gregkh@linuxfoundation.org; jslaby@suse.cz; ralf@linux-mips.org; k.kozlowski@samsung.com; paul.burton@imgtec.com; linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org<br>> Subject: [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver<br>> Date: Fri, 10 Jul 2015 15:36:20 +0900<br>> <br>> i2c_driver does not need to set an owner because i2c_register_driver()<br>> will set it.<br>> <br>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com><br>> <br>> ---<br>> <br>> The coccinelle script which generated the patch was sent here:<br>> http://www.spinics.net/lists/kernel/msg2029903.html<br>> ---<br>> drivers/tty/serial/sc16is7xx.c | 1 -<br>> 1 file changed, 1 deletio
n(-)<br>> <br>> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c<br>> index 9e6576004a42..bbeb33561737 100644<br>> --- a/drivers/tty/serial/sc16is7xx.c<br>> +++ b/drivers/tty/serial/sc16is7xx.c<br>> @@ -1369,7 +1369,6 @@ MODULE_DEVICE_TABLE(i2c, sc16is7xx_i2c_id_table);<br>> static struct i2c_driver sc16is7xx_i2c_uart_driver = {<br>> .driver = {<br>> .name = SC16IS7XX_NAME,<br>> - .owner = THIS_MODULE,<br><br>Okay, is there an issue by doing this. Or its just a over doing things ?<br><br>> .of_match_table = of_match_ptr(sc16is7xx_dt_ids),<br>> },<br>> .probe = sc16is7xx_i2c_probe,<br>> -- <br>> 1.9.1<br>> <br>> --<br>> To unsubscribe from this list: send the line "unsubscribe linux-serial"
in<br>> the body of a message to majordomo@vger.kernel.org<br>> More majordomo info at http://vger.kernel.org/majordomo-info.html<br>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-10 9:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-10 6:36 [PATCH] Drop owner assignment from i2c_driver (and platform left-overs) Krzysztof Kozlowski
2015-07-10 6:36 ` [PATCH 1/2] tty: serial: Drop owner assignment from platform_driver Krzysztof Kozlowski
2015-07-10 6:36 ` [PATCH 2/2] tty: serial: Drop owner assignment from i2c_driver Krzysztof Kozlowski
2015-07-10 8:57 ` Rama Kiran Kumar Indrakanti
2015-07-10 8:57 ` Rama Kiran Kumar Indrakanti
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.