All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] oeqa/runtime: Added one automated runtime testcase.
@ 2015-07-15 14:42 Daniel Istrate
  2015-07-15 16:07 ` Christopher Larson
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Istrate @ 2015-07-15 14:42 UTC (permalink / raw)
  To: openembedded-core

testcase 240: Checks that bash is installed in image.

Signed-off-by: Daniel Istrate <daniel.alexandrux.istrate@intel.com>
---
 meta/lib/oeqa/runtime/bash.py | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 meta/lib/oeqa/runtime/bash.py

diff --git a/meta/lib/oeqa/runtime/bash.py b/meta/lib/oeqa/runtime/bash.py
new file mode 100644
index 0000000..2a261a3
--- /dev/null
+++ b/meta/lib/oeqa/runtime/bash.py
@@ -0,0 +1,23 @@
+from oeqa.oetest import oeRuntimeTest
+from oeqa.utils.decorators import *
+
+
+class BashTest(oeRuntimeTest):
+
+    @testcase(240)
+    @skipUnlessPassed("test_ssh")
+    def test_check_bash_in_image(self):
+        """
+        Summary:     check bash in image
+        Expected:    bash command should exist in image
+        Product:     BSPs
+        Author:      Alexandru Georgescu <alexandru.c.georgescu@intel.com>
+        AutomatedBy: Daniel Istrate <daniel.alexandrux.istrate@intel.com>
+        """
+
+        cmd = 'which bash'
+        expected_ret = '/bin/bash'
+
+        (status, output) = self.target.run(cmd)
+        self.assertEqual(0, status, 'Failed to send cmd "{}"'.format(cmd))
+        self.assertEqual(str(output), expected_ret, 'Found "{}", instead of "{}"'.format(output, expected_ret))
-- 
2.1.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] oeqa/runtime: Added one automated runtime testcase.
  2015-07-15 14:42 [PATCH] oeqa/runtime: Added one automated runtime testcase Daniel Istrate
@ 2015-07-15 16:07 ` Christopher Larson
  0 siblings, 0 replies; 2+ messages in thread
From: Christopher Larson @ 2015-07-15 16:07 UTC (permalink / raw)
  To: Daniel Istrate; +Cc: Patches and discussions about the oe-core layer

[-- Attachment #1: Type: text/plain, Size: 688 bytes --]

On Wed, Jul 15, 2015 at 7:42 AM, Daniel Istrate <
daniel.alexandrux.istrate@intel.com> wrote:

> testcase 240: Checks that bash is installed in image.
>
> Signed-off-by: Daniel Istrate <daniel.alexandrux.istrate@intel.com>
>

This commit message summary is not particularly informative. Generic
messages like that are not ideal, IMO. “oeqa/runtime: Added one automated
runtime testcase.” says nothing about what’s being tested. It leads to a
shortlog which tells very little about what’s really being done.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1214 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-07-15 16:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-15 14:42 [PATCH] oeqa/runtime: Added one automated runtime testcase Daniel Istrate
2015-07-15 16:07 ` Christopher Larson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.